On Thu, 03 Feb 2011 21:04:51 +0100 Charles Vejnar <ce@vejnar.org> wrote:
I agree 100%. I am saying that, in case auto root-login is activated, adding with the script something to .bash_profile compared the submited patch is a better solution.
Not sure what you mean. the submitted patch only enables the script hook, so the patch would be a necessity before you can even add something to .bash_profile from the script.
but first address the concerns..
If I am not missing one, and if auto root-login is activated on tty1 then your only remaining concerns was about error handling (stat_error in case the script isn't retrieved correctly). Is that right ?
you should really look at the script yourself and imagine any possible thing that could go wrong, and make sure the script handles it properly. my other concern is: if the user wants to run an automatic or interactive install (configured by the script): - the actual installation should not happen during the init process. - it should be run when the environment is set up correctly (i.e. user is logged in, .bash_profile and .bashrc are sourced) - it should be run after the MOTD has shown I want to see 2 working scripts which actually implement starting an automatic and an interactive install (properly, as explained above). We could ship those as example scripts in the archiso repository (I considered putting them in the overlay directory, so they end up on the images, but I don't think that's useful). Also, the documentation needs to be updated for this: 1) the official installation guide (in AIF repository) 2) Maybe also the archiso README, I let Djgera decide on that Dieter