February 2008 - Aur-dev - lists.archlinux.org

[aur-dev] [PATCH] Fix for information leak in login logic.
by eliott 20 Feb '08

20 Feb '08

--- web/lang/en/index_po.inc | 7 +++---- web/lib/aur.inc | 6 ++---- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/web/lang/en/index_po.inc b/web/lang/en/index_po.inc index 66a7834..bdeb87f 100644 --- a/web/lang/en/index_po.inc +++ b/web/lang/en/index_po.inc @@ -35,16 +35,12 @@ $_t["en"]["For now, it's just a place holder."] = "For now, it's just a place ho $_t["en"]["It's more important to get the login functionality finished."] = "It's more important to get the login functionality finished."; -$_t["en"]["Error looking up username, %s."] = "Error looking up username, %s."; - $_t["en"]["Login"] = "Login"; $_t["en"]["Though we can't vouch for their contents, we provide a %hlist of user repositories%h for your convenience."] = "Though we can't vouch for their contents, we provide a %hlist of user repositories%h for your convenience."; $_t["en"]["If you have feedback about the AUR, please leave it in %hFlyspray%h."] = "If you have feedback about the AUR, please leave it in %hFlyspray%h."; -$_t["en"]["Incorrect password for username, %s."] = "Incorrect password for username, %s."; - $_t["en"]["Latest Packages:"] = "Latest Packages:"; $_t["en"]["Discussion about the AUR takes place on the %sTUR Users List%s."] = "Discussion about the AUR takes place on the %sTUR Users List%s."; @@ -94,6 +90,9 @@ $_t["en"]["The most popular packages will be provided as binary packages in [com $_t["en"]["Packages added or updated in the past 7 days"] = "Packages added or updated in the past 7 days"; $_t["en"]["Out-of-date"] = "Out-of-date"; + $_t["en"]["DISCLAIMER"] = "DISCLAIMER: Unsupported PKGBUILDs are user produced content, by downloading them you agree to do so at your own risk."; +$_t["en"]["Login failure: Bad user or pass."] = "Login failure: Bad user or pass."; + ?> diff --git a/web/lib/aur.inc b/web/lib/aur.inc index 5dec6e3..5cfb3c8 100644 --- a/web/lib/aur.inc +++ b/web/lib/aur.inc @@ -363,13 +363,11 @@ function html_header($title="") { $q.= "AND Passwd = '" . mysql_real_escape_string($_POST["pass"]) . "'"; $result = db_query($q, $dbh); if (!$result) { - $login_error = __("Error looking up username, %s.", - array(htmlspecialchars($_POST["user"]))); + $login_error = __("Login failure: Bad user or pass."); } else { $row = mysql_fetch_row($result); if (empty($row)) { - $login_error = __("Incorrect password for username, %s.", - array(htmlspecialchars($_POST["user"]))); + $login_error = __("Login failure: Bad user or pass."); } elseif ($row[1]) { $login_error = __("Your account has been suspended."); } -- 1.5.3.7

3 7

[aur-dev] [Translation] Another small fix to Italian translation
by Giovanni Scafora 19 Feb '08

19 Feb '08

Hi Simo, I'm sorry but I forget to fix a message. Please could you apply the patch in attachment too? Thanks. -- Giovanni Scafora Arch Linux Trusted User (voidnull) http://www.archlinux.org linuxmania(a)gmail.com

1 0

[aur-dev] [Translation] Small updates to Italian translation
by Giovanni Scafora 19 Feb '08

19 Feb '08

Hi Simo, please could you apply the patch in attachment? Thanks. -- Giovanni Scafora Arch Linux Trusted User (voidnull) http://www.archlinux.org linuxmania(a)gmail.com

1 0

[aur-dev] AUR Release 1.5.0
by Simo Leone 19 Feb '08

19 Feb '08

I will be updating the AUR on main site sometime this evening. There might be intermittent downtime and maintenance messages, but downtime will be minimal. This is a really big release, and I do mean big. This release brings a json interface, the brand new arch look, a tu voting back-end, tons of changes under the hood, and the removal of safe flags, among tons of other changes. See the shortlog for the nitty gritty. Enjoy -S ====================================================== commit 32be42aee109c2bb8a12b474f364a9d10d2b9da5 Author: Simo Leone <simo(a)archlinux.org> Bump version to 1.5.0 commit a1c1ebb3152c588b717a49f46d34adfbfe5bf2f1 Author: Gerhard Brauer <gerbra(a)archlinux.de> Updated de translation commit a4dcb7d38fb9d46ed09d039e40f20d63b3553c9e Author: Giovanni Scafora <linuxmania(a)gmail.com> Updated Italian translation commit 036f286f1937e2d8c2dbe9b6005e5905f6f65f77 Author: Simo Leone <simo(a)archlinux.org> Removed redundant VERSIONS.txt commit 249d92f5aa32ea0f117bf49931355984f066054e Author: eliott <eliott(a)cactuswax.net> Cleaned up the front page. commit 4d9d5d39666addc2afbb61bb04b00dc1ed707ecc Author: eliott <eliott(a)cactuswax.net> Fix for information leak in login logic. commit aedf2ab6a390b62f1a0de8afe18a5aa53075b9ef Author: eliott <eliott(a)cactuswax.net> Fix for 'More' and 'Less' paging breakage. commit 7bad8a8357773e7918e0b794dbec8a36ee9154ad Author: Simo Leone <simo(a)archlinux.org> Removed QBUG and DBUG commit 2bcd8ff1db2b590121d14a616c8969348ca1dfe6 Author: Simo Leone <simo(a)archlinux.org> Fix package detail action buttons commit 675e5fc84107a7a9b11ccd89265dfa32c9bec104 Author: Simo Leone <simo(a)archlinux.org> Added rss caches to gitignore commit d14def92ff34122bffa4de1fac01598b1d913648 Author: Callan Barrett <wizzomafizzo(a)gmail.com> Turn action bar into drop box commit 52a770e7e7c9a1701e96aa3c66f25d810394aeaf Author: Callan Barrett <wizzomafizzo(a)gmail.com> Fix login error and translation bug commit aa2517ebfc4acf18d17a48eb79b377aa4f65c0ac Author: eliott <eliott(a)cactuswax.net> some more tweaks to make it look less like I worked on it. commit 6edbef61c18bd5b652a726e2cb64090e4a59cb97 Author: eliott <eliott(a)cactuswax.net> Hacky attempt to fix lang and navigation bars commit 14ecbf5fd577995a93f4437ce5d60069fd7cc771 Author: Callan Barrett <wizzomafizzo(a)gmail.com> Add search result information commit 8ab823728c729e9780820bf15aad3585078c8342 Author: Callan Barrett <wizzomafizzo(a)gmail.com> More cleanup, add TU link to header commit 2f56688b56757a3365ee4cc48f1bd139216c74f9 Author: Callan Barrett <wizzomafizzo(a)gmail.com> Prefill category upon upload error and fix bug in last patch commit 11f7c682dbe850c9a2a776fc4979fbcfc463b813 Author: Thayer Williams <thayerw(a)gmail.com> Fixed a couple typos in arch.css commit a9ea2bd89dd62a9766efae0f118b58bca6df6f17 Author: eliott <eliott(a)cactuswax.net> updates to header. Manual addition of thayers previous patch. commit d4faaaf3195535ea63ac52d2701cf95dea590d15 Author: Thayer Williams <thayerw(a)gmail.com> Template update for new Arch logo commit 6683f3ceebcb712c6e3ba4a1bf09c85190c4d0f2 Author: eliott <eliott(a)cactuswax.net> poop commit 0eb2997a82b1817124bbfb6986be8058134879ea Author: Dan McGee <dan(a)archlinux.org> Allow pkgsubmit to accept any tar* file commit 379e16eebda1ba9bfc45de486e99e480843d086a Author: Callan Barrett <wizzomafizzo(a)gmail.com> Support for verbose page titles commit d4b07f2b334dada626e4743951cdd6adab87f62e Author: Callan Barrett <wizzomafizzo(a)gmail.com> Tweaks of various page layouts and handling of data commit dbbf50ac9024dddb5ce70b8aa42c828596eb66d3 Author: Callan Barrett <wizzomafizzo(a)gmail.com> Removes need for name, overwrite and comment fields from pkgsubmit.php commit ce225727f67f5b65b5f92ec96b074712c290ea63 Author: Callan Barrett <wizzomafizzo(a)gmail.com> Bug in uploading PKGBUILDs and aur schema commit 8c94552042115d2a7bb04de3b4f66cdf95f2a5de Author: Callan Barrett <wizzomafizzo(a)gmail.com> Add notify column in search results and notify button commit bf5c28cf2260df822efa72095af69cc119170a3e Author: Callan Barrett <wizzomafizzo(a)gmail.com> Fix bug with botched AURSID values commit 0e4b25211bc2d9629f0f848ea25a4c2fbcbfe339 Author: Callan Barrett <wizzomafizzo(a)gmail.com> Removes timeout page and moves login form to header commit 9a83e56b69bff3ef1921d3f8dab0b2daabb4d4c3 Author: Callan Barrett <wizzomafizzo(a)gmail.com> Adds support for TUs and devs to disown packages they do not own commit 5f4afcc8cb6dcc5dcbe4d5161fad5372eb5f6435 Author: Callan Barrett <wizzomafizzo(a)gmail.com> Add support for variable length votes in voting application commit a8e574ef2897e9ca709c2cfa5ff78d2f69464092 Author: Callan Barrett <wizzomafizzo(a)gmail.com> AUR Voting Application commit 32b863203fcda13f322aa0802bc64eec64dcaa51 Author: eliott <eliott(a)cactuswax.net> Modified to get details based on an exact package name, or based on a package id. commit 47e80c24afa539d23f9060ee876303e24a1b1c89 Author: eliott <eliott(a)cactuswax.net> Removed reference to 'safe' commit f4bfe44876c9d7c62395fbd0c065a5c28d9f33be Author: eliott <eliott(a)cactuswax.net> Comments are listed in reverse order (latest first) commit d245f691eea12a2307d5c49f81d1d8ee7b415251 Author: eliott <eliott(a)cactuswax.net> Fixes to disclaimer text. commit c17b629a4d6e52e137afc9cb0f9c5dd3edc9ece3 Author: eliott <eliott(a)cactuswax.net> Fix for safe-removal. commit a9837329d697a9e18401309a1496cc3b5015bc6a Author: eliott <eliott(a)cactuswax.net> Hand diff of simo's patch to remove flag safe functionality. commit 6dbe12264ac0998ac4b69a507c0b7c1b55c03c1f Author: Dan McGee <dan(a)archlinux.org> Remove dummy data from GIT commit ba51e17482a04922e7974541373a96f2dba1bfcc Author: Paul Mattal <paul(a)mattal.com> Updated favicon.ico to match the main site. commit b23b51fbbd3c84a493a68da8c88bde8807c894bc Author: eliott <eliott(a)cactuswax.net> Removed beta.html Seems old. commit 36dd7736c993cbcf61228f6e06466a6614939c97 Author: eliott <eliott(a)cactuswax.net> Moved usage documentation out of the class. Fixed an issue in the handle class. commit 5e38e3d3d0eff20f8d46bad67c4944a6a1d92ea4 Author: eliott <eliott(a)cactuswax.net> Added AurJSON code. commit 0cda12132d5b28b3a10a27bcad56bc823116817b Author: eliott <eliott(a)cactuswax.net> Updated .gitignore again commit 9274f54287853c7bb1042b25e61c8084d4350098 Author: Paul Mattal <paul(a)mattal.com> Revert "Move "Add Comment" button to Actions bar." commit e9de45954ae404fe1952fec067aad57bcd787a96 Author: Loui Chang <louipc.ist(a)gmail.com> Several functions added to web/lib/acctfuncs.inc Weeere back! commit b2816c13cfe9bee50220d63685f78788467e990e Author: Loui Chang <louipc.ist(a)gmail.com> Make sure short_open_tag = Off via .htaccess commit da9d2b9e0db7a3c65a1a1945e82e724d04d7d631 Author: Loui Chang <louipc.ist(a)gmail.com> Make "Out of Date" pkgs more NOTICABLE. commit a21b8c120958007fe45c80bcab6dee976d5c6d91 Author: Loui Chang <louipc.ist(a)gmail.com> Opera doesn't give the buttons any padding. Let's giver some. commit d06163269bd88ee7fd5e48fd7d43a8b249ffd2d8 Author: tardo <tardo(a)nagi-fanboi.net> Move "Add Comment" button to Actions bar. commit c404c278cc8b4184f2104e6525baf092ed60b27c Author: Loui Chang <louipc.ist(a)gmail.com> Revert "Several functions added to web/lib/acctfuncs.inc" commit 6b3e9028517bbd8ffe6f1816b905585a88091052 Author: Loui Chang <louipc.ist(a)gmail.com> Several functions added to web/lib/acctfuncs.inc commit 8f7fb2b1cbd5e39a3f17b93afdd72e5eb34a56a8 Author: Loui Chang <louipc.ist(a)gmail.com> search_accounts_form() output is put into a template commit 878d0bb39a10c934740fac92335a36853286366b Author: Loui Chang <louipc.ist(a)gmail.com> Added header, footer, and login form templates commit 016e8796c367affe7de3874645adcf202a0f03fd Author: Simo Leone <simo(a)archlinux.org> Update tur-users -> aur-general

8 15

[aur-dev] Patches on the list
by Simo Leone 19 Feb '08

19 Feb '08

Alright, so we've got some confusion going on, let's straighten it out real quick. Can we agree on this stuff? - patches sent to the list should *always* apply against either the master or testing branches on projects.archlinux.org - patches that depend on something which wasn't yet committed to the repo should probably go in the same thread to avoid confusion, or be super duper explicit about it someplace in the message, maybe even link to the patch it depends on if it's in a new thread. - patches that revert things sent to the list but not yet comitted to the repo aren't needed at all. Since it hasn't been comitted yet, I think a short message to say "don't add this one!" is enough and will avoid a lot of confusion. - I don't always have as much free time as I wish I did, I'll start trying to set aside time just for the AUR and see if it gets me anywhere. - Tacos and Chipotle burritos are awesome. -Simo

3 2

[aur-dev] [PATCH] Fix for 'More' and 'Less' paging breakage.
by eliott 19 Feb '08

19 Feb '08

--- web/lib/pkgfuncs.inc | 7 ++----- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/web/lib/pkgfuncs.inc b/web/lib/pkgfuncs.inc index 3608012..1e92a90 100644 --- a/web/lib/pkgfuncs.inc +++ b/web/lib/pkgfuncs.inc @@ -655,7 +655,8 @@ function pkg_search_page($SID="") { # The search form # - print "<form action='/packages.php' method='get'>\n"; + print "<form action='/packages.php' method='post'>\n"; + #print "<form action='/packages.php' method='get'>\n"; print "<input type='hidden' name='O' value='".$O."'>\n"; print "<center>\n"; @@ -766,10 +767,8 @@ function pkg_search_page($SID="") { print "</tr>\n"; print "</table>\n"; print "</center>\n"; - print "</form>"; print "<br />\n"; - print "<form action='/packages.php' method='post'>\n"; # query to pull out package info # # $q = "SELECT Packages.*, IF(ISNULL(PackageID), 0, COUNT(*)) AS Votes "; @@ -881,8 +880,6 @@ function pkg_search_page($SID="") { $qnext = $q."LIMIT ".($O+$PP).", ".$PP; //next page's worth $q.= "LIMIT ".$O.", ".$PP; - - $result = db_query($q, $dbh); print "<center>\n"; -- 1.5.3.7

3 2

[aur-dev] [PATCH] Cleaned up the front page.
by eliott 19 Feb '08

19 Feb '08

Removed the blank box on the right of the front page, that was leftover from the change to the login form (move). --- web/html/index.php | 13 ++++--------- 1 files changed, 4 insertions(+), 9 deletions(-) diff --git a/web/html/index.php b/web/html/index.php index 7e04d59..895fc8a 100644 --- a/web/html/index.php +++ b/web/html/index.php @@ -14,23 +14,18 @@ echo "<div class=\"pgbox\">\n"; echo " <div class=\"pgboxtitle\"><span class=\"f3\">AUR ".__("Home")."</span></div>\n"; echo " <div class=\"frontpgboxbody\">\n"; echo "<table border='0' cellpadding='0' cellspacing='3' width='90%'>\n"; -echo "<tr>\n"; - -# MAIN: Top Left -print "<td class='boxSoft' valign='top'>"; +# MAIN: Top +echo "<tr>\n"; +print "<td class='boxSoft' valign='top' colspan='2'>"; print "<p>".__("Welcome to the AUR! Please read the %hAUR User Guidelines%h and %hAUR TU Guidelines%h for more information.", array('<a href="http://wiki.archlinux.org/index.php/AUR_User_Guidelines">', '</a>', '<a href="http://wiki.archlinux.org/index.php/AUR_Trusted_User_Guidelines">', '</a>'))."<br>"; print __("Contributed PKGBUILDs <b>must</b> conform to the %hArch Packaging Standards%h otherwise they will be deleted!", array('<a href="http://wiki.archlinux.org/index.php/Arch_Packaging_Standards">', '</a>'))."</p>"; print "<p>".__("Remember to vote for your favourite packages!")."<br>"; print __("The most popular packages will be provided as binary packages in [community].")."</p>"; - -# MAIN: Top Right print "</td>"; -print "<td class='boxSoft' valign='top'>"; +print "</tr>"; # MAIN: Bottom Left -print "</td>"; -print "</tr>"; print "<tr>"; print "<td class='boxSoft' valign='top'>"; -- 1.5.3.7

2 1

[aur-dev] whoah. weird git send-email issues
by eliott 18 Feb '08

18 Feb '08

Uhh.. having some git send-email issues. The last one was just failsauce. Disregard the previous few patches. I will rebase and squash into one patch, and resend.

4 9

[aur-dev] [PATCH] Better fix for paging
by eliott 17 Feb '08

17 Feb '08

The previous two patches didn't fix all that was needed. This patch removes those two patches' changes, and applies appropriate behavior.

1 1

[aur-dev] [PATCH] Fix for 'More' and 'Less' paging breakage.
by eliott 17 Feb '08

17 Feb '08

--- web/lib/pkgfuncs.inc | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/web/lib/pkgfuncs.inc b/web/lib/pkgfuncs.inc index 3608012..3b73b34 100644 --- a/web/lib/pkgfuncs.inc +++ b/web/lib/pkgfuncs.inc @@ -881,8 +881,6 @@ function pkg_search_page($SID="") { $qnext = $q."LIMIT ".($O+$PP).", ".$PP; //next page's worth $q.= "LIMIT ".$O.", ".$PP; - - $result = db_query($q, $dbh); print "<center>\n"; @@ -1053,6 +1051,7 @@ function pkg_search_page($SID="") { print "</tr>\n"; print "</table>\n"; # print "<input type='hidden' name='All_IDs' value='".$all_ids."'>\n"; + print "<input type='hidden' name='O' value='".$O."'>\n"; if ($_REQUEST["do_MyPackages"]) { print "<input type='hidden' name='do_MyPackages' value='1'>\n"; } -- 1.5.3.7

1 1