June 2008 - Aur-dev - lists.archlinux.org

[aur-dev] Considering a 1.5.2 release.
by Loui 29 Jul '08

29 Jul '08

Hey guys. I'm thinking we should just merge testing into master now. We can test master for a little bit and if it seems like there are no regressions push the new code into the running server. I'm bringing this up because someone has submitted a duplicate of what has been dubbed "The most annoying bug in the world." FS#10701 - Cannot upload new package to AUR. duplicates FS#8672 - Can't submit new package to AUR

4 10

[aur-dev] [PATCH] Remeber user between sessions (FS#8845)
by BaSh 08 Jul '08

08 Jul '08

Hi all, this patch add a checkbox for "remember me" action which create a cookie for 30 days. -- Andrea `BaSh` Scarpino Arch Linux Trusted User Linux User: #430842

4 4

[aur-dev] [PATCH] Redirect on package submission
by Callan Barrett 29 Jun '08

29 Jun '08

On a successful package submit there will be a redirect to the package details page of the packages, no more successful message Also got rid of the $warning stuff, what the hell was that for? Signed-off-by: Callan Barrett <wizzomafizzo(a)gmail.com> --- web/html/pkgsubmit.php | 46 ++++++++++++++++------------------------------ 1 files changed, 16 insertions(+), 30 deletions(-) diff --git a/web/html/pkgsubmit.php b/web/html/pkgsubmit.php index 4d15ebe..f1fec64 100644 --- a/web/html/pkgsubmit.php +++ b/web/html/pkgsubmit.php @@ -12,17 +12,6 @@ include("pkgfuncs.inc"); # package functions set_lang(); # this sets up the visitor's language check_sid(); # see if they're still logged in -html_header("Submit"); - -?> - -<div class="pgbox"> - <div class="pgboxtitle"> - <span class="f3"><?php print __("Submit"); ?></span> - </div> - <div class="pgboxbody"> - -<?php if ($_COOKIE["AURSID"]): @@ -342,6 +331,8 @@ if ($_COOKIE["AURSID"]): $q .= $pdata["ID"] . ", '" . mysql_real_escape_string($src) . "')"; db_query($q, $dbh); } + + header('Location: /packages.php?ID=' . $pdata['ID']); } else { @@ -385,6 +376,8 @@ if ($_COOKIE["AURSID"]): $q .= $packageID . ", '" . mysql_real_escape_string($src) . "')"; db_query($q, $dbh); } + + header('Location: /packages.php?ID=' . $packageID); } } @@ -392,7 +385,19 @@ if ($_COOKIE["AURSID"]): chdir($_SERVER['DOCUMENT_ROOT']); } +# Logic over, let's do some output + +html_header("Submit"); + +?> + +<div class="pgbox"> + <div class="pgboxtitle"> + <span class="f3"><?php print __("Submit"); ?></span> + </div> + <div class="pgboxbody"> +<?php if (!$_REQUEST["pkgsubmit"] || $error): # User is not uploading, or there were errors uploading - then # give the visitor the default upload form @@ -405,14 +410,6 @@ if ($_COOKIE["AURSID"]): <?php endif; - if ($warning): -?> - -<br><span class='error'><?php print $warning; ?></span><br /> -<br /> - -<?php - endif; $pkg_categories = pkgCategories(); $pkg_locations = pkgLocations(); @@ -461,17 +458,6 @@ if ($_COOKIE["AURSID"]): <?php endif; - else: - print __("Package upload successful."); - - if ($warning): -?> - -<span class='warning'><?php print $warning; ?></span><br /> -<br /> - -<?php - endif; endif; else: # Visitor is not logged in -- 1.5.5.3

1 0

[aur-dev] [PATCH] Fixed incorrect French translation of "Flag out-of-date"
by Loui 23 Jun '08

23 Jun '08

Pushing this to testing.

1 0

[aur-dev] [PATCH] Fixed incorrect polish translation of "Go".
by Loui 23 Jun '08

23 Jun '08

I'll push this into testing.

1 0

[aur-dev] AUR Coding recomendations IMPORTANT
by Angel Velásquez 21 Jun '08

21 Jun '08

Hi, I am writing this e-mail after reviewing the AUR code and some patches that people have been sending. As we know, AUR (like many applications) is still in development, and many of the things that are actually working weren't coded by any of us, and I can understand this. The purpose of my e-mail is to give some recommendations that should be adopted by everyone, I don't want to be arrogant or force you to do something without knowing why, so I will explain the reasons behind my recommendations and then you will probably agree with me. Singles quotes vs Doubles quotes ===================== Problem: In the past I sent an e-mail about this topic, but I think I was misunderstood. The correct way should be using singles quotes when you don't need to parse any kind of variable, that applies in any case. Examples: 1.- include "lib/whatever.inc.php"; // why double quotes ? just to waste resources and no more.. 2.- function myFunction($var) { return "Hello ".$var; // wrong concatenation AND using double quotes ?! # return 'Hello '.$var; // this is the correct use } echo myFunction("world"); // wrong # echo myFunction('world'); // Oh nice you know what i'm talking about. 3.- $_SESSION["myName"] = "MyNameIsWrong"; // and it certainly is wrong, thanks for wasting resources with double quotes! # $_SESSION['myName'] = 'Foo Bar'; // that's the way 4.- // the last example of a block of HTML print "<table>\n"; print "<tr>\n"; print "<td>".$title."</td>\n"; print "</tr>\n"; print "</table>\n"; // Come on!!!!, the following line does the same. echo "<table>\n<tr>\n<td>$title</td>\n</tr>\n</table>"; // Yes I know that placing plenty of \n's would render the code unreadable, but you can do it in one line with a simple echo. Overview: I recommend the use of double quotes in the case that you need to parse many variables so that the code doesn't become unreadable, or if you want to output HTML code in a sorted way. print vs echo ======== Problem: Many of us usually prefer to use print because we are used to the function name similarities from languages other than PHP, and we can't get used to *not* using it. Examples: 1.- print 'echo is ugly!'; // assuming that you've learned about singles and doubles quotes :D Overview: Print outputs the string and has an actual return value of TRUE or FALSE, so that converts print in a function slower than echo. See this thread for more information: http://codingforums.com/archive/index.php?t-41745.html To wrap this up, I just want to emphasize the fact that whereas this might look trivial and nearly irrelevant to some of you, it is important in order to make AUR a better tool. Cheers. -- Angel Velásquez angvp @ irc.freenode.net Linux Counter: #359909 Arch Linux Trusted User

4 4

[aur-dev] [PATCH] Use bash script to parse pkgbuilds
by Callan Barrett 20 Jun '08

20 Jun '08

Ok this is a test to get a bash script to parse pkgbuilds rather than the current crazy way it's done now. The pkgbuild is sent through a bash script (thanks Xilon) and the vars are output so the result can be evaluated by PHP, this way nothing can get missed and there are no bugs with what's parsed. This also gets rid of the package contents stuff, didn't really have a choice but it seems it's not used for anything, only wasted space. As far as I can tell this fixes about 4 bugs currently open on the bug tracker so aside from being a huge improvement over the current parsing stuff (has anyone ever looked at what that parses, wow) it also fixes a lot of bugs. The only downside to it is we can't tell whether a variable actually exists or is just empty so no more hand holding and doing some faux validation, we parse what we need and the rest of the pkgbuild is up to the maintainer. Although I'm not suggesting we apply *this* patch to the AUR I am suggesting we apply some cleaned up form of it since it would be a great improvement. This patch does work fine by the way it's just a bit messy. -- Callan Barrett

5 10

[aur-dev] [PATCH] Remove all vim mode lines. Add HACKING file.
by Loui 19 Jun '08

19 Jun '08

I made this patch after a little discussion on IRC. Please comment. Cheers!

3 4

[aur-dev] [PATCH] Reorganise web/README.txt and elaborate on PEAR and File_Find.
by Loui 17 Jun '08

17 Jun '08

I'll go ahead and push this, since it's a minor thing.

1 1

[aur-dev] [PATCH] Clean up of pkgsubmit.php
by Callan Barrett 15 Jun '08

15 Jun '08

Just general cleaning up of pkgsubmit.php -- Callan Barrett

1 1