February 2009 - Aur-dev - lists.archlinux.org

[aur-dev] [PATCH] Turn on package notification by default for new packages
by Callan Barrett 18 Jun '09

18 Jun '09

Version using package functions Signed-off-by: Callan Barrett <wizzomafizzo(a)gmail.com> --- web/html/pkgsubmit.php | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/web/html/pkgsubmit.php b/web/html/pkgsubmit.php index 78d6e50..450e9b6 100644 --- a/web/html/pkgsubmit.php +++ b/web/html/pkgsubmit.php @@ -328,6 +328,7 @@ if ($_COOKIE["AURSID"]): header('Location: packages.php?ID=' . $pdata['ID']); } else { + $uid = uid_from_sid($_COOKIE["AURSID"]); # This is a brand new package $q = sprintf("INSERT INTO Packages (Name, License, Version, CategoryID, Description, URL, LocationID, SubmittedTS, SubmitterUID, MaintainerUID, FSPath, URLPath) VALUES ('%s', '%s', '%s-%s', %d, '%s', '%s', 2, UNIX_TIMESTAMP(), %d, %d, '%s', '%s')", @@ -338,8 +339,8 @@ if ($_COOKIE["AURSID"]): mysql_real_escape_string($_REQUEST['category']), mysql_real_escape_string($new_pkgbuild['pkgdesc']), mysql_real_escape_string($new_pkgbuild['url']), - uid_from_sid($_COOKIE["AURSID"]), - uid_from_sid($_COOKIE["AURSID"]), + $uid, + $uid, mysql_real_escape_string(INCOMING_DIR . $pkg_name . "/" . $pkg_name . ".tar.gz"), mysql_real_escape_string(URL_DIR . $pkg_name . "/" . $pkg_name . ".tar.gz")); @@ -370,6 +371,8 @@ if ($_COOKIE["AURSID"]): $q .= $packageID . ", '" . mysql_real_escape_string($src) . "')"; db_query($q, $dbh); } + + pkg_notify(account_from_sid($_COOKIE["AURSID"]), array($packageID)); header('Location: packages.php?ID=' . $packageID); -- 1.6.0.2

2 1

[aur-dev] [PATCH] added links at My Statistic values
by Andrea Scarpino 02 Mar '09

02 Mar '09

Code is more clear than my bad English. This need my previous[1] patch. [1] http://www.archlinux.org/pipermail/aur-dev/2009-February/000732.html -- Andrea `BaSh` Scarpino Arch Linux Developer

2 1

[aur-dev] AUR2 API
by Sebastian Nowicki 21 Feb '09

21 Feb '09

Hi, I sent a similar mail over a year ago with no response, but this time I wrote up a draft on the wiki[1]. I'd like some suggestions and general feedback about the API, particularly from AUR client developers. I know there was some progress made on an API for the current AUR, but I can't find any end-user documentation for it. Is it finished? If the current interface is nice, there's no point re- designing it. It would be better to maintain compatibility if API clients already exist. As noted in the wiki, I think a well designed API is vital. This would allow a lot of neat tools for managing packages (uploading, updating, TU management) and easier integration with the makepkg/pacman toolchain for installing packages. It is quite possibly more important than the website itself. It occurred to me that we could eliminate the /api/ url part, and use the same URLs for various resources, but simply use different content types[2] to return HTML or JSON/XML/YAML/etc. I.e., we could have http://aur.archlinux.org/packages.html , which shows the normal HTML page users would see, but if we change to http://aur.archlinux.org/packages.json, we get only the data in JSON format. If the extension is not supplied, it could default to the html output. I'm not sure if this is a good idea or not, but it would make sense, since the business logic is identical, only the output differs. [1]: http://wiki.archlinux.org/index.php/AUR_2#Draft [2]: http://wiki.archlinux.org/index.php/AUR_2#Content_Types

1 0

[aur-dev] Method to get all packages
by Lukas Appelhans 19 Feb '09

19 Feb '09

Hey all! Loui Chang pointed me here since I prepared a patch to get all packages from AUR via the rpc-Interface... The reason why I need to get all packages is to build a list of available packages (which gets cached then...), the user can search in it then... (or just dig a bit in it...). This all is for the AUR-Intergration into Shaman2 (you might probably already know the 1.x version which is in community...)... Now the patch is attached, it's not tested at all and I don't have much knowledge of php/sql/json at all, so it's mostly a copy-over from the other methods... Lukas

3 6

[aur-dev] [PATCH] add Out-of-Date detail in search form
by Andrea Scarpino 18 Feb '09

18 Feb '09

I think this is useful. -- Andrea `BaSh` Scarpino Arch Linux Developer

2 1

[aur-dev] [PATCH] Fix: FS#13122 - simpler commented line removal
by Gergely Imreh 17 Feb '09

17 Feb '09

Hi, This patch should fix the way commented lines are removed. Should generally work with all lines (variables) AUR cares about. Removed previous (incomplete) method. Cheers, Greg

2 11

[aur-dev] AUR2 Direction
by Sebastian 16 Feb '09

16 Feb '09

Hi guys, I've picked up AUR2 development once again, and made it work with Django 1.0+. I want to start working on binary package support, but I'm unsure as to how to go about it. The current AUR depends on background scripts which populate the database. I really don't like this idea. It's fine for them to exist, but AUR2 should not depend on them. I was thinking of writing a parser for binary packages[1] and using the same upload interface for binary packages as for PKGBUILD packages. Permissions to upload would obviously be restricted to specific groups. This generalization would also allow me to get get rid of some hard coded logic for the "unsupported" repository, and make AUR2 a generic pacman package/PKGBUILD web interface, allowing more than one binary/PKGBUILD repository. [1] http://www.github.com/sebnow/parched

3 2

[aur-dev] [PATCH] Fix: FS#13189, infinite variable replacement cycle
by Gergely Imreh 15 Feb '09

15 Feb '09

Hi, Bug report FS#13189 brought to light a situation when certain lines in the PKGBUILD would cause the pkgbuild.php end up in an infinite cycle. Example is a line such as: foo=$foo or as in the bug report: CXXFLAGS=$CXXFLAGS' -fpic' In the first case, e.g. $foo would be recognized as a call for replacement for "foo", and then replaced with "$foo", then checked again for values to replace.... you can guess how well it goes... This patch removes this situation by setting the variable value to empty (to ""), if it recognizes that there would be such a cycle. This behaviour is not exactly what bash would do, since e.g. if there are two lines in the PKGBUILD such as: foo=something foo=$foo then in bash in the end foo would have a proper value ("something"), while in our case it would be empty. In my opinion this is not a problem, since generally these kind of PKGBUILDs could be considered malformed..... The eval type parameter substitution is not changed at the moment, since even if does not give the same value as bash, it does not cause such cycle as the normal substitution. Cheers, Greg

3 7

[aur-dev] [PATCH] rpc: delay getting DB connection until absolutely necessary
by Dan McGee 15 Feb '09

15 Feb '09

Signed-off-by: Dan McGee <dan(a)archlinux.org> --- web/lib/aurjson.class.php | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/web/lib/aurjson.class.php b/web/lib/aurjson.class.php index 81c0831..425748d 100644 --- a/web/lib/aurjson.class.php +++ b/web/lib/aurjson.class.php @@ -33,8 +33,6 @@ class AurJSON { public function handle($http_data) { // set content type header to json header('content-type: application/json'); - // set up db connection. - $this->dbh = db_connect(); // handle error states if ( !isset($http_data['type']) || !isset($http_data['arg']) ) { @@ -43,6 +41,9 @@ class AurJSON { // do the routing if ( in_array($http_data['type'], $this->exposed_methods) ) { + // set up db connection. + $this->dbh = db_connect(); + // ugh. this works. I hate you php. $json = call_user_func_array(array(&$this,$http_data['type']), $http_data['arg']); @@ -103,7 +104,7 @@ class AurJSON { $search_data = array(); while ( $row = mysql_fetch_assoc($result) ) { array_push($search_data, $row); - } + } mysql_free_result($result); return $this->json_results('search', $search_data); -- 1.6.1.3

2 1

[aur-dev] Patch: Who voted on a Prosal
by Angel Velásquez 13 Feb '09

13 Feb '09

Hi, First of all I would like to discuss this patch. The idea of this patch is to know who voted on a proposal, not "not to know who voted for that", the vote should be secret. Why do I think this feature is necessary? Because it will help to determine who is voting on the SVP and who isn't, is every TU's job to vote on all SVP even though there is an abstain vote option for every TU that might feel unsecure about his vote. If this patch is considered a good feature, I propose to change the line if (mysql_num_rows($result) > 0) by something like if (mysql_num_rows($result) >= $n) and $n should be a variable returned by the query SELECT COUNT(*) .... which should return the total numbers of TUs.. Comments? -- Angel Velásquez angvp @ irc.freenode.net Linux Counter: #359909 Arch Linux Trusted User

3 3