July 2009 - Aur-dev - lists.archlinux.org

[aur-dev] Putting php 5.3 into [testing]?
by Pierre Schmitz 05 Sep '09

05 Sep '09

Hi all, are thee any big rebuilds planned? Otherwise I would like to put version 5.3 of PHP into testing. There is still an issue with suhosin but this way people would have more time to check their scripts. We should also make sure that our Scripts (like AUR) work with the new PHP version. I could help here if there are problems. The good thing is that we don't provide packages with php scripts; so from our side everything is fine. ;-) But seriously: this version has great potential to break lots of especially very old PHP scripts. Pierre -- Pierre Schmitz, http://users.archlinux.de/~pierre

3 4

Re: [aur-dev] Translation Czech in AUR
by darek zabdyr 30 Jul '09

30 Jul '09

Hello, ok, I still ask. where do I find a translation extension under *po. Which together can translate. Thanks Dariusz

2 1

[aur-dev] Translation Czech in AUR
by darek zabdyr 30 Jul '09

30 Jul '09

On Sun, Jul 26, 2009 at 3:44 PM, darek zabdyr<zabdyr(a)gmail.com> wrote: > Hello, > We have own websites Czech www.archlinux.cz . It is quite lacking for the > translation of the AUR. Were you pleased about the interest of the Czech for > AUR http://aur.archlinux.org/index.php?setlang=cs ? > > Thanks Dariusz Zabdyr

2 1

[aur-dev] Fixed and added string to AUR Translation zh_CN.po
by Mod Gao 28 Jul '09

28 Jul '09

<aur-dev(a)archlinux.org>Hello, Here is the AUR Translation zh_CN.po that fixed some string, and added many string grabbed from other .po so all visible English are translated. (except "The AUR no longer manages the community repo. Entries on this site may be out of date." i can't even find it in web/html/index.php) attached a tar.gz include git diff and a complete zh_CN.po for avoid errors maybe on my git diff:) ('git commit -s' don't recognize EDITOR=gvim) Thanks!

2 6

[aur-dev] CVS freeze and move to SVN/official tools
by Aaron Griffin 15 Jul '09

15 Jul '09

Hey guys, I'd like to put a freeze on community CVS later today. Sadly, CVS doesn't respect files set to RO, so there's not too much I can do server-side. I'm going to do the SVN conversion in approx 8 hours or so, maybe sooner, if I get some time while at work. In the meantime, this document should explain the usage of the offical tools and svn: http://wiki.archlinux.org/index.php/DeveloperWiki:HOWTO_Be_A_Packager Let me know if there are any questions. Sorry for the long delay on this one. Cheers, Aaron

2 1

[aur-dev] Updated AUR translation of zh_CN
by Mod_Gao 10 Jul '09

10 Jul '09

Attachment is a mostly completed AUR translation of zh_CN, done by me and another one(see file), i don't know how to do a git patch or it got some failure (i already read documents but still don't know), so here is the file directly. all string about "proposal" are not translated because never see this string before. Is this OK? thx!

3 2

[aur-dev] [patch] russian translation minor fixes
by Sergej Pupykin 10 Jul '09

10 Jul '09

Hi, Here is small fixes for RU translation.

2 1

[aur-dev] [PATCH] Add confirmation to package deletion from packages page
by Callan Barrett 10 Jul '09

10 Jul '09

Signed-off-by: Callan Barrett <wizzomafizzo(a)gmail.com> --- web/lib/pkgfuncs.inc | 4 ++++ web/template/actions_form.php | 4 +++- 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/web/lib/pkgfuncs.inc b/web/lib/pkgfuncs.inc index a4a2dfc..80775a2 100644 --- a/web/lib/pkgfuncs.inc +++ b/web/lib/pkgfuncs.inc @@ -649,6 +649,10 @@ function pkg_delete ($atype, $ids) { return __("You must be logged in before you can disown packages."); } + if ($_POST['form_type'] == 'bar' && empty($_POST['confirm_del'])) { + return __("You need to confirm the deletion of this package."); + } + if (empty($ids)) { return __("You did not select any packages to delete."); } diff --git a/web/template/actions_form.php b/web/template/actions_form.php index de77645..c8a9964 100644 --- a/web/template/actions_form.php +++ b/web/template/actions_form.php @@ -1,5 +1,6 @@ <div class="pgbox"> <form action="packages.php?ID=<?php echo $row['ID'] ?>" method="post"> + <input type="hidden" name="form_type" value="bar"> <input type='hidden' name='IDs[<?php echo $row['ID'] ?>]' value='1'> <input type='hidden' name='ID' value="<?php echo $row['ID'] ?>"> <?php @@ -46,7 +47,8 @@ if ($row["MaintainerUID"] == 0) { if ($atype == "Trusted User" || $atype == "Developer") { echo "<input type='submit' class='button' name='do_Delete'"; - echo " value='".__("Delete Packages")."'>\n"; + echo " value='".__("Delete Packages")."'>"; + echo " <input type='checkbox' name='confirm_del'> <span class='f5'>" . __("Confirm delete?") . "</span>"; } ?> -- 1.6.0.4

2 1

[aur-dev] Using curl to upload to the AUR
by Xyne 05 Jul '09

05 Jul '09

I am not sure if this is related to the recent move to a new server but I am no longer able to use curl to upload to the AUR (via aurploader). I can't see anything different in the package submit form but attempting to upload a package now returns this page: <?xml version="1.0" encoding="iso-8859-1"?> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en"> <head> <title>417 - Expectation Failed</title> </head> <body> <h1>417 - Expectation Failed</h1> </body> </html> As the aurploader code has not changed in months, this must be due either to a change in curl or in the AUR. I am still able to login using aurploader and retrieve the page with the submit form. Googling suggests that this is a lighttpd server error. I will keep trying to find a workaround for curl if this is the case, but could someone please check it it's possible to resolve this serverside? Thanks. Xyne

3 3

[aur-dev] [PATCH] Add a logging function and logging fixins through the code
by Callan Barrett 01 Jul '09

01 Jul '09

Signed-off-by: Callan Barrett <wizzomafizzo(a)gmail.com> --- web/html/pkgsubmit.php | 2 ++ web/lib/acctfuncs.inc | 2 ++ web/lib/aur.inc | 36 ++++++++++++++++++++++++++++++++++++ web/lib/config.inc.proto | 2 ++ web/lib/pkgfuncs.inc | 8 ++++++++ web/template/pkg_comment_form.php | 2 ++ 6 files changed, 52 insertions(+), 0 deletions(-) diff --git a/web/html/pkgsubmit.php b/web/html/pkgsubmit.php index a3394af..04c1542 100644 --- a/web/html/pkgsubmit.php +++ b/web/html/pkgsubmit.php @@ -369,6 +369,7 @@ if ($_COOKIE["AURSID"]): } } + if (LOGGING) { logit(2, username_from_sid($_COOKIE['AURSID']), pkgname_from_id($pdata['ID'])); } header('Location: packages.php?ID=' . $pdata['ID']); } else { @@ -419,6 +420,7 @@ if ($_COOKIE["AURSID"]): } pkg_notify(account_from_sid($_COOKIE["AURSID"]), array($packageID)); + if (LOGGING) { logit(1, username_from_sid($_COOKIE['AURSID']), pkgname_from_id($packageID)); } header('Location: packages.php?ID=' . $packageID); diff --git a/web/lib/acctfuncs.inc b/web/lib/acctfuncs.inc index 9ed4f22..661b081 100644 --- a/web/lib/acctfuncs.inc +++ b/web/lib/acctfuncs.inc @@ -290,6 +290,8 @@ function process_account_form($UTYPE,$TYPE,$A,$U="",$T="",$S="",$E="", } else { # account created/modified, tell them so. # + if (LOGGING) { logit(4, username_from_sid($U)); } + print __("The account, %h%s%h, has been successfully created.", "<b>", $U, "</b>"); print "<p>\n"; diff --git a/web/lib/aur.inc b/web/lib/aur.inc index 517abe3..6a07d69 100644 --- a/web/lib/aur.inc +++ b/web/lib/aur.inc @@ -437,3 +437,39 @@ function mkurl($append) { return substr($out, 5); } + +/** + * Log whatever you like to a table + * + * Basic function so we can get some stats about stuff, we'll just dump + * everything into a table and make up some numbers for different actions + * + * Some Numbers®: + * 1 = upload new package + * 2 = update package + * 3 = delete package + * 4 = register account + * 5 = comment somewhere + * 6 = I dunno lol (I had search here for some reason) + * (maybe we don't need to log this much, I'll make some numbers up anyway) + * 7 = vote/unvote + * 8 = flag/unflag + * 9 = adopt/disown + * + * @param int $action Put your magic number here that represents whatever + * action you're logging + * @param string $who Optional string to log who did the action, normal username + * not the ID + * @param string $pkg Optional string of what package an action happened to, + * actual package names not IDs + */ +function logit($action, $who='', $pkg='') +{ + $dbh = db_connect(); + $q = sprintf("INSERT INTO Log (`action`, `when`, `who`, `pkg`) VALUES (%d, UNIX_TIMESTAMP(), '%s', '%s')", + $action, + mysql_real_escape_string($who), + mysql_real_escape_string($pkg) + ); + db_query($q, $dbh); +} diff --git a/web/lib/config.inc.proto b/web/lib/config.inc.proto index 89b4fe5..6b2b73a 100644 --- a/web/lib/config.inc.proto +++ b/web/lib/config.inc.proto @@ -39,3 +39,5 @@ $SUPPORTED_LANGS = array( # Idle seconds before timeout $LOGIN_TIMEOUT = 7200; +# Shall we log everything? +define("LOGGING", FALSE); diff --git a/web/lib/pkgfuncs.inc b/web/lib/pkgfuncs.inc index 80775a2..699d6e3 100644 --- a/web/lib/pkgfuncs.inc +++ b/web/lib/pkgfuncs.inc @@ -599,6 +599,8 @@ function pkg_flag ($atype, $ids, $action = True) { } else { $flag .= ", " . $pid; } + + if (LOGGING) { logit(8, username_from_sid($_COOKIE['AURSID']), pkgname_from_id($pid)); } } $ood = $action ? 1 : 0; @@ -699,6 +701,8 @@ function pkg_delete ($atype, $ids) { # These are the packages that are safe to delete foreach ($ids_to_delete as $id) { + if (LOGGING) { logit(3, username_from_sid($_COOKIE['AURSID']), pkgname_from_id($id)); } + $q = "DELETE FROM PackageVotes WHERE PackageID = " . $id; $result = db_query($q, $dbh); @@ -757,6 +761,8 @@ function pkg_adopt ($atype, $ids, $action = True) { } else { $pkg .= ", ".$pid; } + + if (LOGGING) { logit(9, username_from_sid($_COOKIE['AURSID']), pkgname_from_id($pid)); } } $field = "MaintainerUID"; @@ -840,6 +846,8 @@ function pkg_vote ($atype, $ids, $action = True) { } } } + + if (LOGGING) { logit(7, username_from_sid($_COOKIE['AURSID']), pkgname_from_id($pid)); } } # only vote for packages the user hasn't already voted for diff --git a/web/template/pkg_comment_form.php b/web/template/pkg_comment_form.php index 70570da..213cc81 100644 --- a/web/template/pkg_comment_form.php +++ b/web/template/pkg_comment_form.php @@ -11,6 +11,8 @@ if (isset($_REQUEST['comment'])) { $q.= 'UNIX_TIMESTAMP())'; db_query($q, $dbh); + if (LOGGING) { logit(5, username_from_sid($_COOKIE['AURSID']), pkgname_from_id(intval($_REQUEST['ID']))); } + # Send email notifications $q = 'SELECT CommentNotify.*, Users.Email '; $q.= 'FROM CommentNotify, Users '; -- 1.6.0.4

3 5