November 2011 - Aur-dev - lists.archlinux.org

[aur-dev] [PATCH 0/5] Package details view layout changes
by Lukas Fleischer 17 Dec '11

17 Dec '11

This patch set basically syncs the package details layout with what archweb uses and makes the rendered page, as well as the source code, look cleaner and more consistent. I plan to put more efforts in cleaning up our HTML and making the AUR integrate well with the rest of www.archlinux.org. We might eventually just use "archweb.css" with a few AUR-specific extensions. Any objections from the "Arch Linux/AUR segregation" front..? Dan, any objections? Lukas Fleischer (5): pkg_details.php: Use a table for package details pkg_details.php: Add link to category search pkg_details.php: Sync metadata layout with archweb pkg_details.php: Sync package actions layout with archweb pkg_details.php: Use sane format for date strings web/html/css/arch.css | 3 - web/html/css/containers.css | 81 +++++++++++++++ web/template/pkg_details.php | 226 +++++++++++++++++++++--------------------- 3 files changed, 196 insertions(+), 114 deletions(-) -- 1.7.7.2

2 9

[aur-dev] [PATCH] Remove maxlength on password fields
by Stein Magnus Jodal 02 Dec '11

02 Dec '11

>From c5798e0914075de8eba05ba57992ff23252bd491 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal <stein.magnus(a)jodal.no> Date: Thu, 24 Nov 2011 22:51:05 +0100 Subject: [PATCH] Remove maxlength on password fields The password field for login had a maxlength of 128 chars, while the password fields for account creation and modification, and for password resetting, had a maxlength of 32 chars. After this change, they will all behave in the same way. Users with password managers will often use passwords longer than 32 characters, which was the previous maxlength when creating an account. Because of the password length, they will copy-paste the password into the browser. Most browsers does not notify the user that the text he pasted was cut of after a limit. If the login form also cuts of the password at the same length, the user will not notice anything until the site is changed to accept longer passwords, and his full password no longer matches the password the site has stored. In AUR's case, the login form accepted passwords of 128 characters length, so users trying to use longer passwords than 32 characters will notice the problem when first trying to log in. Setting a maximum length on input fields makes sense where the input is stored directly to a database where the database field got a limited length. In the case of password fields, limiting the length make little sense as the password is hashed before being stored. The hash function's output has constant length, irrespective of the length of the input. --- web/html/passreset.php | 4 ++-- web/lib/acctfuncs.inc.php | 4 ++-- web/lib/config.inc.php.proto | 1 - web/template/login_form.php | 2 +- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/web/html/passreset.php b/web/html/passreset.php index 82be3ef..0792f72 100644 --- a/web/html/passreset.php +++ b/web/html/passreset.php @@ -109,11 +109,11 @@ html_header(__("Password Reset")); </tr> <tr> <td><?php echo __("Enter your new password:"); ?></td> - <td><input type="password" name="password" size="30" maxlength="32" /></td> + <td><input type="password" name="password" size="30" /></td> </tr> <tr> <td><?php echo __("Confirm your new password:"); ?></td> - <td><input type="password" name="confirm" size="30" maxlength="32" /></td> + <td><input type="password" name="confirm" size="30" /></td> </tr> </table> <br /> diff --git a/web/lib/acctfuncs.inc.php b/web/lib/acctfuncs.inc.php index 512e66c..b724580 100644 --- a/web/lib/acctfuncs.inc.php +++ b/web/lib/acctfuncs.inc.php @@ -84,7 +84,7 @@ function display_account_form($UTYPE,$A,$U="",$T="",$S="", print "<tr>"; print "<td align='left'>".__("Password").":</td>"; - print "<td align='left'><input type='password' size='30' maxlength='32'"; + print "<td align='left'><input type='password' size='30'"; print " name='P' value='".$P."' />"; if ($A != "UpdateAccount") { print " (".__("required").")"; @@ -93,7 +93,7 @@ function display_account_form($UTYPE,$A,$U="",$T="",$S="", print "<tr>"; print "<td align='left'>".__("Re-type password").":</td>"; - print "<td align='left'><input type='password' size='30' maxlength='32'"; + print "<td align='left'><input type='password' size='30'"; print " name='C' value='".$C."' />"; if ($A != "UpdateAccount") { print " (".__("required").")"; diff --git a/web/lib/config.inc.php.proto b/web/lib/config.inc.php.proto index 1f19651..aef2e34 100644 --- a/web/lib/config.inc.php.proto +++ b/web/lib/config.inc.php.proto @@ -15,7 +15,6 @@ define( "URL_DIR", "/packages/" ); define( "USERNAME_MIN_LEN", 3 ); define( "USERNAME_MAX_LEN", 16 ); define( "PASSWD_MIN_LEN", 4 ); -define( "PASSWD_MAX_LEN", 128 ); # Default language for displayed messages in the web interface. define("DEFAULT_LANG", "en"); diff --git a/web/template/login_form.php b/web/template/login_form.php index 21bdaa7..194083d 100644 --- a/web/template/login_form.php +++ b/web/template/login_form.php @@ -19,7 +19,7 @@ elseif (!$DISABLE_HTTP_LOGIN || (isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'])) print htmlspecialchars($_POST['user'], ENT_QUOTES); } ?>" /> <label for="passwd"><?php print __('Password') . ':'; ?></label> - <input type="password" name="passwd" id="passwd" size="30" maxlength="<?php print PASSWD_MAX_LEN; ?>" /> + <input type="password" name="passwd" id="passwd" size="30" /> <input type="checkbox" name="remember_me" id="remember_me" /> <label for="remember_me"><?php print __("Remember me"); ?></label> <input type="submit" class="button" value="<?php print __("Login"); ?>" /> -- 1.7.5.4

3 7

Re: [aur-dev] replace categories with tags (was: New user, introduction and proposal)
by Connor Behan 18 Nov '11

18 Nov '11

I would standardize the list of tags in a combo box in the AUR and not just the wiki. Don't let random users create their own tags at all unless they ask on a mailing list. -- Sent from my Macbook Wheel <http://www.theonion.com/video/apple-introduces-revolutionary-new-laptop-wit…>

1 0

[aur-dev] Removed two of my dated packages & picking up an abandoned one.
by Jason 17 Nov '11

17 Nov '11

First time sending to this list, so apologies in advance for any mistakes/breaches in etiquette :) I posted some questions on the AUR section of the BBS and was informed I should send an email here: 1. I have two old packages I'd like to get removed from the AUR: gwclient32 & gwclient64. They were my first attempt at doing stuff in the AUR and I later made a single dual architecture PKGBUILD, which I'm still maintaining (gwclient). 2. I'd like to become the maintainer for citrix-client, and remove bin32-citrix-client entirely. I needed this for work and made a single PKDBUILD for both architectures, which I've attached here as a tarball (Though I haven't tested the 32 bit version, in fairness). Cheers, -- ~Jason

2 2

[aur-dev] New user introduction and proposal
by Joaquín Ignacio Aramendía 17 Nov '11

17 Nov '11

Hi there! I'd like to introduce myself first then add a request/proposal with a patch attached. I'm Joaquín from Argentina, I'm relatively new to Arch but in this time I've been reading and reading and really I like this community, I feel I'm learning every day. I don't think I could ever move away from Arch or any other Arch-based distribution, and I've been testing a few now. My proposal is not really big or even important (that why I'm submitting a one-line patch) but for me is a way to sort some things out. I've noticed in the AUR that there are a bunch of categories, not random or bad ones but kind of misleading in some ways. I don't even know if people actually uses those categories when searching for packages, but when someone submits a package of any sort, a category is required. That's great actually, I like to tag things because they are way easier to sort out and I could see some logic (please correct me if I'm wrong) on those categories related with the package purpose: There are categories related with some utilities, some related to system, libraries, even with individual desktops environments, games. But when it comes to art, there is only one category 'multimedia'. As that's maybe related to some artistic data, is more related to utilities to access or reproduce that data. Then when it comes to artistic "viewable" data, and I mean icon sets, wallpapers, splash-screens, there is no category that fits. For example: some icon theme is related to X11 but is not really an added functionality to it, maybe related to multimedia but is not an utility to reproduce videos, audio or pictures; it also could be attached to gnome, kde or lxde but is not as desktop specific. Same things happen to splash screens and wallpapers. They are Eyecandy for our beloved distribution. So I was thinking about editing the categories list to add 'eyecandy' as a way to enclose all icon-sets, splash-screens themes, {gtk,metacity,shell,whatever}-themes, wallpapers and so on. I hope I don't bother too much with this. So behold... the one line patch. -- Joaquín Ignacio Aramendía <samsagax(a)gmail.com>

2 2

[aur-dev] Mail info@chakra-project.org
by Manuel Tortosa 14 Nov '11

14 Nov '11

Somehow we are receiving mails from AUR notifications to info@chalra- project.org. ----------------------------------- >from https://aur.archlinux.org/packages.php?ID=31996 >ottoshmidt wrote: > >crashes when opening preferences !! > >--- >If you no longer wish to receive notifications about this package, >please go the the above package page and click the UnNotify button. ---------------------------------- I don't even know who installed this or who is using this mail account at the AUR. i didn't set-up this in the AUR at all and i check the Jan' Mette's account and does not use this mail either. Could you be so kind to search from where this comes and remove the notifications? We use this mail account for helping our users and for our social networks. Also will be nice if you remove the "funkyou" account from Jan Mette, i have the password but i cannot remove the account there. If this is not the place to ask for help, please fordward me to the correct place. Thanks in advance. ----------------------------------------------- Manuel Tortosa manutortosa(a)chakra-project.org

2 2

[aur-dev] [PATCH] Use sane date format strings everywhere
by Lukas Fleischer 07 Nov '11

07 Nov '11

We fixed this for the fields displayed on the package details page in commit 6f5cf272f63f667cdc1c136617969a1723e838b1. This should fix the remaining ones. Signed-off-by: Lukas Fleischer <archlinux(a)cryptocrack.de> --- web/template/pkg_comments.php | 2 +- web/template/stats/updates_table.php | 4 ++-- web/template/tu_details.php | 4 ++-- web/template/tu_list.php | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/web/template/pkg_comments.php b/web/template/pkg_comments.php index 6480ea6..66c176c 100644 --- a/web/template/pkg_comments.php +++ b/web/template/pkg_comments.php @@ -8,7 +8,7 @@ while (list($indx, $carr) = each($comments)) { ?> $carr['UserName'] = "<a href=\"account.php?Action=AccountInfo&ID={$carr['UsersID']}\">{$carr['UserName']}</a>"; } - $commentHeader = '<p style="display:inline;">' . __('Comment by: %s on %s', $carr['UserName'], gmdate('r', $carr['CommentTS'])) . '</p>'; + $commentHeader = '<p style="display:inline;">' . __('Comment by: %s on %s', $carr['UserName'], gmdate('Y-m-d H:i', $carr['CommentTS'])) . '</p>'; if (canDeleteCommentArray($carr, $atype, $uid)) { $durl = '<form method="post" action="packages.php?ID='.$row['ID'].'">'; diff --git a/web/template/stats/updates_table.php b/web/template/stats/updates_table.php index a8cdf5a..d27d25e 100644 --- a/web/template/stats/updates_table.php +++ b/web/template/stats/updates_table.php @@ -21,9 +21,9 @@ $mod_int = intval($row["ModifiedTS"]); $sub_int = intval($row["SubmittedTS"]); if ($mod_int == $sub_int): - $modstring = '<img src="images/new.gif" alt="New!" /> ' . gmdate("r", $sub_int); + $modstring = '<img src="images/new.gif" alt="New!" /> ' . gmdate("Y-m-d H:i", $sub_int); else: - $modstring = gmdate("r", $mod_int); + $modstring = gmdate("Y-m-d H:i", $mod_int); endif; ?> diff --git a/web/template/tu_details.php b/web/template/tu_details.php index c71c6b9..571692b 100644 --- a/web/template/tu_details.php +++ b/web/template/tu_details.php @@ -17,8 +17,8 @@ if ($isrunning == 1) { ?> N/A <?php } ?> </b><br /> -<?php print __("Submitted: %s by %s", "<b>" . gmdate("r", $row['Submitted']) . "</b>", "<b>" . username_from_id($row['SubmitterID']) . "</b>") ?><br /> -<?php print __('End') ?>: <b><?php print gmdate("r", $row['End']) ?></b></p> +<?php print __("Submitted: %s by %s", "<b>" . gmdate("Y-m-d H:i", $row['Submitted']) . "</b>", "<b>" . username_from_id($row['SubmitterID']) . "</b>") ?><br /> +<?php print __('End') ?>: <b><?php print gmdate("Y-m-d H:i", $row['End']) ?></b></p> <p> <?php print str_replace("\n", "<br />\n", htmlspecialchars($row['Agenda'])) ?> diff --git a/web/template/tu_list.php b/web/template/tu_list.php index f99c632..cb17af6 100644 --- a/web/template/tu_list.php +++ b/web/template/tu_list.php @@ -22,8 +22,8 @@ ?> <a href='tu.php?id=<?php print $row['ID'] ?>'><?php print $row["Agenda"] ?></a></span></span> </td> - <td class='<?php print $c ?>'><span class='f5'><span class='blue'><?php print gmdate("j M y", $row["Submitted"]) ?></span></span></td> - <td class='<?php print $c ?>'><span class='f5'><span class='blue'><?php print gmdate("j M y", $row["End"]) ?></span></span></td> + <td class='<?php print $c ?>'><span class='f5'><span class='blue'><?php print gmdate("Y-m-d", $row["Submitted"]) ?></span></span></td> + <td class='<?php print $c ?>'><span class='f5'><span class='blue'><?php print gmdate("Y-m-d", $row["End"]) ?></span></span></td> <td class='<?php print $c ?>'><span class='f6'><span class='blue'> <?php if (!empty($row['User'])) { -- 1.7.7.2

1 0

[aur-dev] [PATCH 1/4] arch.css: Sync default color and font with archweb
by Lukas Fleischer 04 Nov '11

04 Nov '11

Signed-off-by: Lukas Fleischer <archlinux(a)cryptocrack.de> --- web/html/css/arch.css | 9 ++++----- 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/web/html/css/arch.css b/web/html/css/arch.css index 23b8aa7..a7cb74d 100644 --- a/web/html/css/arch.css +++ b/web/html/css/arch.css @@ -1,11 +1,10 @@ * { margin: 0; padding: 0; } * ul { padding: 20px; } body { - min-width: 600px; - background-color: white; - color: #555; - font-family: "DejaVu Sans", sans-serif; - font-size: 12px; + min-width: 650px; + background: #f6f9fc;; + color: #222; + font: normal 100% sans-serif; } /* Divs */ #title { -- 1.7.7.2

1 3

[aur-dev] [PATCH] RPC: Do not return an error on 0 results
by Lukas Fleischer 03 Nov '11

03 Nov '11

Return an empty array and set the result count to zero instead. Before: $ curl 'http://localhost/rpc.php?type=search&arg=raboof' {"type":"error","resultcount":0,"results":"No results found"} After: $ curl 'http://localhost/rpc.php?type=search&arg=raboof' {"type":"search","resultcount":0,"results":[]} Signed-off-by: Lukas Fleischer <archlinux(a)cryptocrack.de> --- web/lib/aurjson.class.php | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/web/lib/aurjson.class.php b/web/lib/aurjson.class.php index 4b97d2b..c1b079a 100644 --- a/web/lib/aurjson.class.php +++ b/web/lib/aurjson.class.php @@ -152,7 +152,7 @@ class AurJSON { return $this->json_results($type, $resultcount, $search_data); } else { - return $this->json_error('No results found'); + return $this->json_results($type, 0, array()); } } -- 1.7.7.2

1 0

[aur-dev] [RFC] aurjson: add result count to JSON result
by Dave Reisner 03 Nov '11

03 Nov '11

We already ask for the result count, but only use it as a basis for testing query success or failure. Add the value to the JSON reply. Signed-off-by: Dave Reisner <dreisner(a)archlinux.org> --- I call this an RFC because: a) I don't have a test environment setup b) I don't know PHP ...but I really like the idea of knowing ahead of time how many results you're about to receive. web/lib/aurjson.class.php | 11 ++++++----- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/web/lib/aurjson.class.php b/web/lib/aurjson.class.php index 234a3c4..23eb854 100644 --- a/web/lib/aurjson.class.php +++ b/web/lib/aurjson.class.php @@ -103,7 +103,7 @@ class AurJSON { private function json_error($msg) { // set content type header to app/json header('content-type: application/json'); - return $this->json_results('error', $msg); + return $this->json_results('error', 0, $msg); } /** @@ -112,8 +112,8 @@ class AurJSON { * @param $data The result data to return * @return mixed A json formatted result response. **/ - private function json_results($type, $data) { - return json_encode( array('type' => $type, 'results' => $data) ); + private function json_results($type, $count, $data) { + return json_encode( array('type' => $type, 'resultcount' => $count, 'results' => $data) ); } private function process_query($type, $where_condition) { @@ -124,7 +124,8 @@ class AurJSON { "WHERE ${where_condition}"; $result = db_query($query, $this->dbh); - if ( $result && (mysql_num_rows($result) > 0) ) { + $resultcount = mysql_num_rows($result); + if ( $result && $resultcount > 0 ) { $search_data = array(); while ( $row = mysql_fetch_assoc($result) ) { $name = $row['Name']; @@ -148,7 +149,7 @@ class AurJSON { } mysql_free_result($result); - return $this->json_results($type, $search_data); + return $this->json_results($type, $resultcount, $search_data); } else { return $this->json_error('No results found'); -- 1.7.7.1

3 4