May 2012 - Aur-dev - lists.archlinux.org

[aur-dev] [PATCH] HTML/DOM fixes
by Dario Giovannetti 31 May '12

31 May '12

While developing a bot for the ArchWiki, I've noticed that some AUR pages cannot be parsed as text/xml documents because of 2 errors in the HTML code, both addressed by the attached patch. The change to pkg_comments.php is self explaining. The change to pkgfuncs.inc.php is due to the fact that <body> shouldn't have a text node as a child. As this patch is safe can you consider uploading the edited files directly to the server, instead of waiting for the next AUR release? Bug report: https://bugs.archlinux.org/task/29966 Patch: https://bugs.archlinux.org/task/29966?getfile=8802 Thank you Dario

2 1

[aur-dev] Drop packages
by Petronio Padilha 16 May '12

16 May '12

Hello there!! On the 15th and 16th May I did upload three packages: archscript, archsysinfo, and finally archsysinfo-git (the ok-version!). So,let's start from the beginning... First... i did upload my source named: *archscript*. After I upload, someone told me I could not leave the package without "-git" in its name and that there is also a script called archscript. So I decided to change the package name, but I made a mistake again... I identified a little problem with PKGBUILD and with the git code. So finally I uploaded the final version archsysinfo-git. I would like to stay with *archsysinfo-git *and remove *archscript *and * archsysinfo* Sorry for the confusion.

3 2

[aur-dev] [PATCH] user_table optimization
by Dan McGee 06 May '12

06 May '12

Rather than looking up by username, it makes more sense to look the stats up by user ID to reduce the number of needed joins. Signed-off-by: Dan McGee <dan(a)archlinux.org> --- web/html/index.php | 4 ++-- web/lib/stats.inc.php | 11 +++++------ 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/web/html/index.php b/web/html/index.php index 0d513d3..21de99d 100644 --- a/web/html/index.php +++ b/web/html/index.php @@ -58,8 +58,8 @@ echo __( <td class='boxSoft' valign='top'> <?php if (!empty($_COOKIE["AURSID"])) { - $user = username_from_sid($_COOKIE["AURSID"]); - user_table($user, $dbh); + $userid = uid_from_sid($_COOKIE["AURSID"]); + user_table($userid, $dbh); echo '<br />'; } diff --git a/web/lib/stats.inc.php b/web/lib/stats.inc.php index 8f0f770..6659f6d 100644 --- a/web/lib/stats.inc.php +++ b/web/lib/stats.inc.php @@ -18,18 +18,17 @@ function updates_table($dbh) include('stats/updates_table.php'); } -function user_table($user, $dbh) +function user_table($userid, $dbh) { - $escuser = db_escape_string($user); - $base_q = "SELECT count(*) FROM Packages,Users WHERE Packages.MaintainerUID = Users.ID AND Users.Username='" . $escuser . "'"; + $base_q = "SELECT count(*) FROM Packages WHERE Packages.MaintainerUID = " . $userid; $maintainer_unsupported_count = db_cache_value($base_q, $dbh, - 'user_unsupported_count:' . $escuser); + 'user_unsupported_count:' . $userid); - $q = "SELECT count(*) FROM Packages,Users WHERE Packages.OutOfDateTS IS NOT NULL AND Packages.MaintainerUID = Users.ID AND Users.Username='" . $escuser . "'"; + $q = "SELECT count(*) FROM Packages WHERE Packages.OutOfDateTS IS NOT NULL AND Packages.MaintainerUID = " . $userid; $flagged_outdated = db_cache_value($q, $dbh, - 'user_flagged_outdated:' . $escuser); + 'user_flagged_outdated:' . $userid); # If the user is a TU calculate the number of the packages $atype = account_from_sid($_COOKIE["AURSID"]); -- 1.7.10.1

2 1

[aur-dev] [PATCH] web/html/packages.php: Remove duplicate code
by Lukas Fleischer 06 May '12

06 May '12

Retrieve the package ID early and merge the if-branches calling package_details(). Signed-off-by: Lukas Fleischer <archlinux(a)cryptocrack.de> --- web/html/packages.php | 24 ++++++++++-------------- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/web/html/packages.php b/web/html/packages.php index 8f3b143..aa1d04c 100644 --- a/web/html/packages.php +++ b/web/html/packages.php @@ -89,28 +89,24 @@ html_header($title); <?php if (isset($_GET['ID'])) { - include('pkg_search_form.php'); - if (!$_GET['ID'] = intval($_GET['ID'])) { - print __("Error trying to retrieve package details.")."<br />\n"; - } else { - if (isset($_COOKIE["AURSID"])) { - package_details($_GET['ID'], $_COOKIE["AURSID"]); - } - else { - package_details($_GET['ID'], null); - } - } + $pkgid = intval($_GET['ID']); } else if (isset($_GET['N'])) { + $pkgid = pkgid_from_name($_GET['N']); +} else { + unset($pkgid); +} + +if (isset($pkgid)) { include('pkg_search_form.php'); - if (!$pkgid = pkgid_from_name($_GET['N'])) { - print __("Error trying to retrieve package details.")."<br />\n"; - } else { + if ($pkgid) { if (isset($_COOKIE["AURSID"])) { package_details($pkgid, $_COOKIE["AURSID"]); } else { package_details($pkgid, null); } + } else { + print __("Error trying to retrieve package details.")."<br />\n"; } } else { if (!isset($_GET['K']) && !isset($_GET['SB'])) { -- 1.7.10.1

1 0