August 2019 - Aur-dev - lists.archlinux.org

[PATCH] notify.py: Use a/an correctly when sending request notifications
by Lars Rustand 19 Aug '19

19 Aug '19

Will no longer send notifications about "a orphan request", but determine whether to use a/an based on the first character of the request type. Signed-off-by: Lars Rustand <rustand.lars(a)gmail.com> --- aurweb/scripts/notify.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/aurweb/scripts/notify.py b/aurweb/scripts/notify.py index d975086..ace6614 100755 --- a/aurweb/scripts/notify.py +++ b/aurweb/scripts/notify.py @@ -414,8 +414,9 @@ class RequestOpenNotification(Notification): (self._user, self._pkgbase, self._merge_into) body += '\n\n' + self._text else: - body = '%s [1] filed a %s request for %s [2]:' % \ - (self._user, self._reqtype, self._pkgbase) + an = ["a","an"][self._reqtype[0] in "aeiou"] + body = '%s [1] filed %s %s request for %s [2]:' % \ + (self._user, an, self._reqtype, self._pkgbase) body += '\n\n' + self._text return body -- 2.22.0

3 3

[aur-dev][PATCH] Move permission for LIST_COMMENTS to dev/tu block
by Eli Schwartz 18 Aug '19

18 Aug '19

In commit 3578e77ad4e9258495eed7e786b7dc3aebcf1b63 we implemented listing of comments from the account details page , but this was intended to only be available to TUs and Devs. As the comment says: "display the comment list if they're a TU/dev" The credential checking code, however, set this credential for all users, contrary to the intention of the commit. Signed-off-by: Eli Schwartz <eschwartz(a)archlinux.org> --- web/lib/credentials.inc.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/lib/credentials.inc.php b/web/lib/credentials.inc.php index c125119..96c7233 100644 --- a/web/lib/credentials.inc.php +++ b/web/lib/credentials.inc.php @@ -49,7 +49,6 @@ function has_credential($credential, $approved_users=array()) { $atype = account_from_sid($_COOKIE['AURSID']); switch ($credential) { - case CRED_ACCOUNT_LIST_COMMENTS: case CRED_PKGBASE_FLAG: case CRED_PKGBASE_NOTIFY: case CRED_PKGBASE_VOTE: @@ -60,6 +59,7 @@ function has_credential($credential, $approved_users=array()) { case CRED_ACCOUNT_CHANGE_TYPE: case CRED_ACCOUNT_EDIT: case CRED_ACCOUNT_LAST_LOGIN: + case CRED_ACCOUNT_LIST_COMMENTS: case CRED_ACCOUNT_SEARCH: case CRED_COMMENT_DELETE: case CRED_COMMENT_UNDELETE: -- 2.23.0

2 4

kodi-devel-bin
by Паша 10 Aug '19

10 Aug '19

Hey guys! Am I wrong or package kodi-devel-bin really breaks guidelines? It looks like it compiles kodi from scratch every time Pasha

2 1

Re: [PATCH] notify.py: Use a/an correctly when sending request notifications
by Eli Schwartz 09 Aug '19

09 Aug '19

On 8/9/19 2:08 PM, Lars Rustand wrote: > Argh, gmail replies to the wrong address. > > On Fri, Aug 9, 2019, 20:06 Lars Rustand <rustand.lars(a)gmail.com> wrote: > >> Thank you for the feedback, I totally agree with your remarks. I might be >> a little too fond of codegolfing, that's where I got the idea to use True >> as an index. >> I posted an updated patch where I added your changes. No problem. ;) Thanks. As an aside, I have now seen int(True)-indexed lists used "in the wild"! A clever fox saw what I wrote and PM'ed me a Fizzbuzz implementation which relied on that. -- Eli Schwartz Bug Wrangler and Trusted User

2 1