September 2020 - Aur-dev - lists.archlinux.org

[PATCH] Adding color highlighting to orphaned packages on result list
by marcus＠tojoma.se 22 Sep '20

22 Sep '20

The following patch solves the issue addressed by me in a previous email, regarding the color of the word "orphan" when browsing packages. Signed-off-by: Marcus Andersson <marcus(a)tojoma.se> --- web/template/pkg_search_results.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) mode change 100644 => 100755 web/template/pkg_search_results.php diff --git a/web/template/pkg_search_results.php b/web/template/pkg_search_results.php old mode 100644 new mode 100755 index 7c5ad03b..61335560 --- a/web/template/pkg_search_results.php +++ b/web/template/pkg_search_results.php @@ -96,7 +96,7 @@ if (!$result): ?> <a href="<?= get_uri('/packages/'); ?>?K=<?= htmlspecialchars($row['Maintainer'], ENT_QUOTES) ?>& SeB=m"><?= htmlspecialchars($row['Maintainer']) ?></a> <?php endif; ?> <?php else: ?> - <span><?= __("orphan") ?></span> + <span class="error"><?= __("orphan") ?></span> <?php endif; ?> </td> </tr> -- 2.28.0 Regards, Marcus Andersson(mackilanu)

1 0

Re: Highlight orphaned packages in table (Marcus Andersson)
by marcus＠tojoma.se 22 Sep '20

22 Sep '20

Hi Lukas, No worries. Yes, exactly, changing the font color to red of the word "orphan". I think that the background color can stay the same, it will be easy enough to differentiate an orphaned package from a maintained one if the text color is different. Best Regards, Marcus Andersson (mackilanu) On Tue, Sep 22, 2020 at 12:00, aur-dev-request(a)archlinux.org wrote: > Send aur-dev mailing list submissions to > aur-dev(a)archlinux.org <mailto:aur-dev@archlinux.org> > > To subscribe or unsubscribe via the World Wide Web, visit > <https://lists.archlinux.org/listinfo/aur-dev> > or, via email, send a message with subject or body 'help' to > aur-dev-request(a)archlinux.org <mailto:aur-dev-request@archlinux.org> > > You can reach the person managing the list at > aur-dev-owner(a)archlinux.org <mailto:aur-dev-owner@archlinux.org> > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of aur-dev digest..." > > > Today's Topics: > > 1. Re: Highlight orphaned packages in table (Lukas Fleischer) > > > ---------------------------------------------------------------------- > > Message: 1 > Date: Mon, 21 Sep 2020 20:45:35 -0400 > From: Lukas Fleischer <lfleischer(a)archlinux.org > <mailto:lfleischer@archlinux.org>> > To: aur-dev(a)archlinux.org <mailto:aur-dev@archlinux.org> > Subject: Re: Highlight orphaned packages in table > Message-ID: <160073553521.155630.14274525589529055982@typhoon> > Content-Type: text/plain; charset="utf-8" > > Hi Marcus, > > Sorry, this somehow fell through the cracks. > > I like the idea in general. Do you have something more specific in > mind? > What would the highlighted entry look like? Red text color for the > word > "orphan"? > > Best, > Lukas > > > ------------------------------ > > Subject: Digest Footer > > _______________________________________________ > aur-dev mailing list > aur-dev(a)archlinux.org <mailto:aur-dev@archlinux.org> > <https://lists.archlinux.org/listinfo/aur-dev> > > > ------------------------------ > > End of aur-dev Digest, Vol 143, Issue 3 > ***************************************

2 1

Highlight orphaned packages in table
by Marcus Andersson 22 Sep '20

22 Sep '20

Hi! One minor feature that i personally would find helpful, is when you're scrolling thru the package list and "accidentally" find an orphaned package that you end up adopting; Unless you're specifically looking for packages to adopt, it's pretty hard to tell an orphaned package from a maintained one. Therefore I suggest a highlighting feature, making orphaned packages easier to spot as you scroll. Fore example, out of date package's version numbers is red when they are flagged like so, that behavior would be helpful for orphaned packages too. I am happy to implement this if it seems like a reasonable addition. Thanks! mackilanu

2 1

[PATCH] pkg_search_page: Limit number of results on package search
by foxboron＠archlinux.org 05 Sep '20

05 Sep '20

From: Morten Linderud <morten(a)linderud.pw> The current package search query is quite poorly optimized and becomes a resource hog when the offsets gets large enough. This DoSes the service. A quick fix is to just ensure we have some limit to the number of hits we return. The current hardcoding of 2500 is based on the following: * 250 hits pr page max * 10 pages We can maybe consider having it lower, but it seems easier to just have this a multiple of 250 in the first iteration. Signed-off-by: Morten Linderud <morten(a)linderud.pw> --- web/lib/pkgfuncs.inc.php | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/web/lib/pkgfuncs.inc.php b/web/lib/pkgfuncs.inc.php index 8c915711..948e716c 100644 --- a/web/lib/pkgfuncs.inc.php +++ b/web/lib/pkgfuncs.inc.php @@ -624,6 +624,10 @@ function pkg_search_page($params, $show_headers=true, $SID="") { $params['O'] = 0; } + if($params['O'] >= 2500){ + $params['O'] = 2500; + } + if (isset($params["PP"])) { $params["PP"] = bound(intval($params["PP"]), 50, 250); } else { @@ -772,6 +776,9 @@ function pkg_search_page($params, $show_headers=true, $SID="") { if ($result_t) { $row = $result_t->fetch(PDO::FETCH_NUM); $total = $row[0]; + if ($total >= 2500) { + $total = 2500; + } } else { $total = 0; -- 2.28.0

2 1