Bumping this thread since it probably has fallen through the cracks :) On Wed, Sep 23 2020 at 12:00:01 PM +0000, aur-dev-request@archlinux.org wrote:
Send aur-dev mailing list submissions to aur-dev@archlinux.org <mailto:aur-dev@archlinux.org>
To subscribe or unsubscribe via the World Wide Web, visit <https://lists.archlinux.org/listinfo/aur-dev> or, via email, send a message with subject or body 'help' to aur-dev-request@archlinux.org <mailto:aur-dev-request@archlinux.org>
You can reach the person managing the list at aur-dev-owner@archlinux.org <mailto:aur-dev-owner@archlinux.org>
When replying, please edit your Subject line so it is more specific than "Re: Contents of aur-dev digest..."
Today's Topics:
1. Re: Highlight orphaned packages in table (Marcus Andersson) (marcus@tojoma.se <mailto:marcus@tojoma.se>) 2. Re: Highlight orphaned packages in table (Marcus Andersson) (Lukas Fleischer) 3. [PATCH] Adding color highlighting to orphaned packages on result list (marcus@tojoma.se <mailto:marcus@tojoma.se>)
----------------------------------------------------------------------
Message: 1 Date: Tue, 22 Sep 2020 15:35:34 +0200 From: marcus@tojoma.se <mailto:marcus@tojoma.se> To: aur-dev@archlinux.org <mailto:aur-dev@archlinux.org> Subject: Re: Highlight orphaned packages in table (Marcus Andersson) Message-ID: <A3B2HQ.ZGUC0Y5RVNZX@tojoma.se <mailto:A3B2HQ.ZGUC0Y5RVNZX@tojoma.se>> Content-Type: text/plain; charset=us-ascii; format=flowed
Hi Lukas,
No worries.
Yes, exactly, changing the font color to red of the word "orphan". I think that the background color can stay the same, it will be easy enough to differentiate an orphaned package from a maintained one if the text color is different.
Best Regards, Marcus Andersson (mackilanu)
On Tue, Sep 22, 2020 at 12:00, aur-dev-request@archlinux.org <mailto:aur-dev-request@archlinux.org> wrote:
Send aur-dev mailing list submissions to aur-dev@archlinux.org <mailto:aur-dev@archlinux.org> <<mailto:aur-dev@archlinux.org>>
To subscribe or unsubscribe via the World Wide Web, visit <<https://lists.archlinux.org/listinfo/aur-dev>> or, via email, send a message with subject or body 'help' to aur-dev-request@archlinux.org <mailto:aur-dev-request@archlinux.org> <<mailto:aur-dev-request@archlinux.org>>
You can reach the person managing the list at aur-dev-owner@archlinux.org <mailto:aur-dev-owner@archlinux.org> <<mailto:aur-dev-owner@archlinux.org>>
When replying, please edit your Subject line so it is more specific than "Re: Contents of aur-dev digest..."
Today's Topics:
1. Re: Highlight orphaned packages in table (Lukas Fleischer)
----------------------------------------------------------------------
Message: 1 Date: Mon, 21 Sep 2020 20:45:35 -0400 From: Lukas Fleischer <lfleischer@archlinux.org <mailto:lfleischer@archlinux.org> <<mailto:lfleischer@archlinux.org>>> To: aur-dev@archlinux.org <mailto:aur-dev@archlinux.org> <<mailto:aur-dev@archlinux.org>> Subject: Re: Highlight orphaned packages in table Message-ID: <160073553521.155630.14274525589529055982@typhoon> Content-Type: text/plain; charset="utf-8"
Hi Marcus,
Sorry, this somehow fell through the cracks.
I like the idea in general. Do you have something more specific in mind? What would the highlighted entry look like? Red text color for the word "orphan"?
Best, Lukas
------------------------------
Subject: Digest Footer
_______________________________________________ aur-dev mailing list aur-dev@archlinux.org <mailto:aur-dev@archlinux.org> <<mailto:aur-dev@archlinux.org>> <<https://lists.archlinux.org/listinfo/aur-dev>>
------------------------------
End of aur-dev Digest, Vol 143, Issue 3 ***************************************
------------------------------
Message: 2 Date: Tue, 22 Sep 2020 09:57:44 -0400 From: Lukas Fleischer <lfleischer@archlinux.org <mailto:lfleischer@archlinux.org>> To: aur-dev@archlinux.org <mailto:aur-dev@archlinux.org> Subject: Re: Highlight orphaned packages in table (Marcus Andersson) Message-ID: <160078306465.168972.1930749137722452139@typhoon> Content-Type: text/plain; charset="utf-8"
On Tue, 22 Sep 2020 at 09:35:34, wrote:
Yes, exactly, changing the font color to red of the word "orphan". I think that the background color can stay the same, it will be easy enough to differentiate an orphaned package from a maintained one if the text color is different.
Yes, sounds good to me! You can send patches to this mailing list.
------------------------------
Message: 3 Date: Tue, 22 Sep 2020 17:42:40 +0200 From: marcus@tojoma.se <mailto:marcus@tojoma.se> To: aur-dev <aur-dev@archlinux.org <mailto:aur-dev@archlinux.org>> Subject: [PATCH] Adding color highlighting to orphaned packages on result list Message-ID: <4ZG2HQ.4ZZARZDKA3WT3@tojoma.se <mailto:4ZG2HQ.4ZZARZDKA3WT3@tojoma.se>> Content-Type: text/plain; charset=us-ascii; format=flowed
The following patch solves the issue addressed by me in a previous email, regarding the color of the word "orphan" when browsing packages.
Signed-off-by: Marcus Andersson <marcus@tojoma.se <mailto:marcus@tojoma.se>> --- web/template/pkg_search_results.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) mode change 100644 => 100755 web/template/pkg_search_results.php
diff --git a/web/template/pkg_search_results.php b/web/template/pkg_search_results.php old mode 100644 new mode 100755 index 7c5ad03b..61335560 --- a/web/template/pkg_search_results.php +++ b/web/template/pkg_search_results.php @@ -96,7 +96,7 @@ if (!$result): ?> <a href="<?= get_uri('/packages/'); ?>?K=<?= htmlspecialchars($row['Maintainer'], ENT_QUOTES) ?>& SeB=m"><?= htmlspecialchars($row['Maintainer']) ?></a> <?php endif; ?> <?php else: ?> - <span><?= __("orphan") ?></span> + <span class="error"><?= __("orphan") ?></span> <?php endif; ?> </td> </tr> -- 2.28.0
Regards, Marcus Andersson(mackilanu)
------------------------------
Subject: Digest Footer
_______________________________________________ aur-dev mailing list aur-dev@archlinux.org <mailto:aur-dev@archlinux.org> <https://lists.archlinux.org/listinfo/aur-dev>
------------------------------
End of aur-dev Digest, Vol 143, Issue 4 ***************************************