On Sat, 28 Nov 2015 at 16:01:06, Mark Weiman wrote:
[...] I was thinking that rather than having to retype the same information (or copy and paste), we could just pin a comment from anyone and if multiple comments have good information, we can pin all of them. Only 5 get displayed unless you go to the "comments=all" page.
Sounds good to me.
[...] To begin, the only reason I made two patches is because my Postfix server would complain when the patch got too long (lost connection after DATA error) while using git-send-email, so I made two smaller patches to get around that issue. Nothing I did could solve that problem.
Note that there is a patch size limit on this mailing list as well. However, there is nothing wrong with splitting such a large a patch into back and front end changes.
The idea I was going for was rather than removing the comment order below (preserving the readability of a conversation), just make a copy of it above. While doing that, make a new header above that says "Pinned Comments" above the pinned comments, then do the normal "Latest Comments" section. If you think it should be a single comment from the maintainer that is displaced, I can make that change.
Okay. Maybe we can still share a lot of code between the function that retrieves all comments and the function to retrieve pinned comments?
[...] I will for sure simplify that function, but if you think it's better to delete it altogether, I'll get to work on making it work. Perhaps also a rework the other two "array" functions (can_edit_comment_array() and can_delete_comment_array()) should be done in the future if the can_pin_comment_array() function is removed or the comment is changed. [...]
I am fine with simplifying the function. We can still refactor all the can_*_comment_array() functions in another patch series. Regards, Lukas