On Wed, 2015-05-27 at 13:52 +0200, Gordian Edenhofer wrote:
On Wed, 2015-05-27 at 13:33 +0200, Florian Pritz wrote:
Please use the -v2 argument (also -v3, -v4, ...) to git format -patch or git send-email next time so the subject will look like this: [PATCH
v2]
Also I'd suggest using --in-reply-to with a message ID from your old thread so that threading works as expected and it's easier to view previous discussion/versions. I tend to use the ID that started the thread so that each patch version gets it's own sub thread (well kind of), but they are nicely grouped.
On 27.05.2015 12:17, Gordian Edenhofer wrote:
[...]
Signed-off-by: Gordian Edenhofer <gordian.edenhofer@gmail.com> ---
I like to include a short summary of the changes to the previous version here so people don't have to remember what they should check for. This is especially helpful for larger patches that might not be reviewed
as quickly.
Something like the following:
v2: - merge login and package search change into one patch - use XHTML style option
You can easily add this by using the --annotate option of send -email or by editing the file generated by format-patch. Note that such comments will not be included in the commit (if it's applied from the mail) since they are after the --- marker.
Thanks for the hints. I will keep them in mind when submitting further patches.
Is it too optimistic to assume this patch might be included in AUR 4.0 or is it unlikely it will be added at this point? Kind regards, Gordian