Hey Lukas, Awesome! I do like the sound better of using the same exact search sql for both RPC and Web, and so your suggestion seems like a great idea to me. I'll start looking at this today! On Sat, Jul 4, 2020 at 5:30 PM Lukas Fleischer <lfleischer@archlinux.org> wrote:
On Sat, 04 Jul 2020 at 17:14:26, Kevin Morris wrote:
API Version 6 modifies `type=search` functionality: Split `arg` into keywords separated by spaces (quoted keywords are preserved). [...] Signed-off-by: Kevin Morris <kevr.gtalk@gmail.com> --- doc/rpc.txt | 4 +++ web/lib/aurjson.class.php | 60 +++++++++++++++++++++++++++++++++------ 2 files changed, 56 insertions(+), 8 deletions(-)
Thanks for the quick revision. Looks great now, I merged this as
Support conjunctive keyword search in RPC interface
to pu (I think it is better to refer to the new feature in the subject line and put aside "Bump RPC API Version" for patches that just bump the API version in case it was forgotten in a previous patch).
Now that this is implemented, I just wanted to suggest implementing the same functionality for the web interface until I noticed that we already do and it's even more powerful: we additionally support "OR" and "NOT" there; see construct_keyword_search() in pkgfuncs.inc.php. Would you be open to working on another revision of this patch that refactors construct_keyword_search() a little bit (to make it usable for the RPC interface) and then uses that for API version 6 instead?
-- Kevin Morris Software Developer Personal Inquiries: kevr.gtalk@gmail.com Personal Phone: (415) 583-9687 Technologies: C, C++, Python, Django, Ruby, Rails, ReactJS, jQuery, Javascript, SQL, Redux