On Mon, 2020-06-01 at 18:16 -0400, Lukas Fleischer wrote:
On Mon, 01 Jun 2020 at 16:51:05, Filipe Laíns wrote:
Signed-off-by: Filipe Laíns <lains@archlinux.org> --- aurweb/git/auth.py | 1 - aurweb/git/serve.py | 14 +- aurweb/git/update.py | 4 +- aurweb/l10n.py | 2 +- aurweb/schema.py | 2 +- aurweb/scripts/rendercomment.py | 3 +- .../versions/f47cad5d6d03_initial_revision.py | 4 +- schema/gendummydata.py | 349 +++++++++--------- setup.cfg | 4 + 9 files changed, 195 insertions(+), 188 deletions(-) create mode 100644 setup.cfg
Thanks, much appreciated. Would it be possible to split the formatting/style changes from the flake8 setup (fix style first, set up flake8 next)?
Sure.
diff --git a/migrations/versions/f47cad5d6d03_initial_revision.py b/migrations/versions/f47cad5d6d03_initial_revision.py index 9e99490f..ec5ecb67 100644 --- a/migrations/versions/f47cad5d6d03_initial_revision.py +++ b/migrations/versions/f47cad5d6d03_initial_revision.py @@ -1,12 +1,10 @@ """initial revision
Revision ID: f47cad5d6d03 -Revises: +Revises: Create Date: 2020-02-23 13:23:32.331396
""" -from alembic import op -import sqlalchemy as sa
Do we want to enforce this on generated code?
My position on generated code is that it shouldn't be committed, but in the case on alembic I guess it makes sense. The code still has to be committed so one could argue that it should be enforced, however I don't really thing it matters as you probably aren't going to be looking at the code. I'll drop this. Cheers, Filipe Laíns