On Wed, Feb 11, 2009 at 01:02:51AM +1930, Angel Velásquez wrote:
Hi,
First of all I would like to discuss this patch.
The idea of this patch is to know who voted on a proposal, not "not to know who voted for that", the vote should be secret.
Why do I think this feature is necessary? Because it will help to determine who is voting on the SVP and who isn't, is every TU's job to vote on all SVP even though there is an abstain vote option for every TU that might feel unsecure about his vote.
If this patch is considered a good feature, I propose to change the line if (mysql_num_rows($result) > 0) by something like if (mysql_num_rows($result) >= $n) and $n should be a variable returned by the query SELECT COUNT(*) .... which should return the total numbers of TUs..
Comments?
Thanks for the patch Angel. I've pushed a modified version. It will only list who voted once the proposal has closed, so you won't be able to figure out what the votes are. I'm just keeping the status quo, though I don't agree with secret votes when it comes to the TU system.