On 07/21/2017 04:57 PM, Lukas Fleischer wrote:
Oh, and talking about documentation, it might be a good idea to add a sentence on AUR_OVERWRITE/AUR_FORCE_PUSH to the git-serve section in doc/git-interface.txt as well...
Will do
I know I said earlier that the warning is a good idea. However, thinking about it again, it seems fairly awkward to ask "are you absolutely sure you mean this?" after the TU said "I really want to force push!" by repeating "force" twice in `AUR_FORCE_PUSH=1 git push --force`. So could you please resend this as a separate patch, based on master instead 1/2 in this series?
Sure, that and a better commit message. To be honest, I wrote patch #1 several weeks ago and then figured out how to implement #2 yesterday, while reading more of the aurweb module. So it was basically tacked on, and I wasn't even sure whether you would want it etc. So I will redo it keeping all your feedback in mind, probably on Sunday. Thanks for going over this! -- Eli Schwartz