On Fri, 2015-06-26 at 19:46 +0200, Lukas Fleischer wrote:
On Fri, 26 Jun 2015 at 17:41:20, Gordian Edenhofer wrote:
The function html_action_link closes its link with </a> hence there is no need for closing them again after invoking the function. --- web/template/pkgbase_actions.php | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/web/template/pkgbase_actions.php b/web/template/pkgbase_actions.php index 757b063..a659c88 100644 --- a/web/template/pkgbase_actions.php +++ b/web/template/pkgbase_actions.php @@ -29,18 +29,18 @@ <?php endif; ?>
<?php if (has_credential(CRED_PKGBASE_EDIT_COMAINTAINERS, array($row["MaintainerUID"]))): ?> - <li><?= html_action_link($base_uri . 'comaintainers/', __('Manage Co-Maintainers')) ?></a></li> + <li><?= html_action_link($base_uri . 'comaintainers/', __('Manage Co-Maintainers')) ?></li> <?php endif; ?> [...]
Good catch. I'll squash this into my original patch and add your Signed-off-by if you're fine with that.
Thanks!
Sure, go ahead!