On Sat, Sep 15, 2012 at 12:38:06PM -0400, canyonknight wrote:
Hello all,
I've been doing quite a bit of testing lately and have collected a few patches. Note that the PDO patch isn't present because it is too large for the mailing list.
I merged all of your patches into my working branch, including the PDO patch. Good job!
The following things still need to be fixed: - Account registration needs to be modified to work with URL rewriting
The registration form works for me with virtual URLs enabled. Am I missing something?
- When a user is logged out they get the "adopt package" button on orphan package pages
Good catch -- we should probably wrap the whole form in an if-statement that checks the login status.
- "View PKGBUILD" and "Download tarball" appear to be broken by rewriting
I don't think we should deal with that in the code. The virtual URL feature requires specific rewrite rules anyway; exceptions, such as any files in the upload area, can be easily declared using rewrite conditions or "blacklist" rewrite rules.
- Move delete and merge to "Package Actions" so that the actions bar is deprecated (maybe?)
Yes, I intended to do that. Initially, I even planned to move the package deletion form (including removal options, such as the confirmation check box and the target name of a merge operation) to a separate page. I'm not sure whether this breaks the "mass-deletion" feature (using check boxes and the "Actions" drop-down list on the package search results page), though.
- Fix undefined notice when a logged out user navigates to a package page
+1. That's a one-liner.
- The "Latest Comments" link appends "?comments=all" to URL on every click
Yes, should be easy to fix as well.
Anything else?
canyonknight (13): Migrate all DB code to use PDO Adjust user directions after registering to reflect new login page logout.php: Fix PHP undefined variable notice Add the new package icon back to the front page Use the "new" icon from archweb for the recent updates table Remove unused image "titlelogo.png" pkg_comment_form.php: Fix PHP undefined variable notice for package "ID" Fix account search page results routing to /account/ Use URL rewriting for user info page Use URL rewriting for user editing page Use URL rewriting for user account update page Overhaul ability to edit own account header.php: Update account editing link
INSTALL | 2 +- UPGRADING | 2 + web/html/account.php | 34 +--- web/html/images/new.gif | Bin 116 -> 0 bytes web/html/images/new.png | Bin 0 -> 378 bytes web/html/images/titlelogo.png | Bin 4502 -> 0 bytes web/html/index.php | 21 ++- web/html/logout.php | 2 +- web/html/voters.php | 2 +- web/lib/acctfuncs.inc.php | 245 +++++++++++++------------ web/lib/aur.inc.php | 154 ++++++---------- web/lib/aurjson.class.php | 26 ++- web/lib/cachefuncs.inc.php | 4 +- web/lib/config.inc.php.proto | 3 +- web/lib/pkgfuncs.inc.php | 304 +++++++++++++++++--------------- web/lib/routing.inc.php | 17 ++ web/lib/stats.inc.php | 4 +- web/lib/translator.inc.php | 6 +- web/template/account_edit_form.php | 2 +- web/template/account_search_results.php | 8 +- web/template/header.php | 5 +- web/template/pkg_comment_form.php | 2 +- web/template/pkg_comments.php | 2 +- web/template/search_accounts_form.php | 2 +- web/template/stats/updates_table.php | 3 + 25 files changed, 414 insertions(+), 436 deletions(-) delete mode 100644 web/html/images/new.gif create mode 100644 web/html/images/new.png delete mode 100644 web/html/images/titlelogo.png
-- 1.7.12