* Lukas Fleischer <lfleischer@archlinux.org> (Mon, 18 Jan 2016 19:16:06 +0100):
+function pkgbase_delete_comment($undelete=false) {
Missing documentation for that new parameter?
Correct.
Do we really need a new function for this? How about simply using has_credential(CRED_COMMENT_UNDELETE) at all call sites instead?
I thought it looks more logical/in line with the other function(s), but I see we use has_credential directly at other places in these files. I'll use that syntax here, too.
I wonder why this is not located next to the other comment action icons? Ideally, there should be a "undelete" icon at the location where we usually have the delete icon. On IRC, you mentioned that placing it there helps "prevent erroneously clicking" but I do not think it really does. In which way is the restore icon different to the delete icon?
You're right, and if a TU or dev erroneously clicks on the undelete button, they can simply deleted the comment again. Regards, Marcel