On Wed, 2017-02-08 at 07:30 +0100, Lukas Fleischer wrote:
On Wed, 08 Feb 2017 at 02:33:48, Mark Weiman wrote:
If PATH_INFO is unset, then it will always return "/", so it would be fairly obvious that something's wrong if you are only getting the root page when you visit other pages.
True, it would be obvious that something is wrong. However, it would be harder to pinpoint the actual issue. Right now, if the server does not set PATH_INFO, the user gets a warning explicitly stating that. After your patch, there won't be such a notice and the user does not get any hint.
Can you think of a way where you could have an instance where a rewrite to /index.php/* is done and PATH_INFO is unset? If it isn't done correctly, you would just get your web server's generic 404 page with no notice either (other than this file doesn't exist), so I really don't see why this is important to consider.
Maybe it's not too bad, though. And I cannot think of a way to make the notice disappear when using `php -S` while keeping it for "real" web servers. Or maybe there is an option to php which tells it to redirect everything to index.php unconditionally and always specify PATH_INFO?
To extend, QUERY_STRING is unset for many pages as well when using `php -S` and I keep meaning to see if this happens with a setup on Nginx. This one makes sense because on some pages, there really isn't a QUERY_STRING.
That second paragraph is not entirely true, you can still set up an SSH/Git interface separate from the web interface. There's nothing too special about the web interface that the SSH/Git interface depends on.
True, let's replace "SSH/Git interface" with "cgit interface" then.
Even right now, INSTALL does not mention how to set up cgit either. Perhaps some instruction on that should be added?
I think that while we are talking about testing installations, perhaps some information on how to populate a database using sqlite instead of MySQL should be added.
Good idea, maybe some TESTING document in addition to INSTALL (and a reference to TESTING before the actual instructions in INSTALL)?
I can get to work on writing such a document.