On Sun, Jun 8, 2008 at 1:49 AM, Loui <louipc.ist@gmail.com> wrote:
On Sun, 8 Jun 2008 01:18:30 +0800 "Callan Barrett" <wizzomafizzo@gmail.com> wrote:
I've applied the first patch (what quotes you use isn't really vital) and my own, this one splits the html entirely from the index page and puts it in a template file. If you want please please take a look at this, what you're already doing is awesome and that template is html soup. I couldn't even indent it.
Just to clarify what I mean is: When moving code if you find PHP logic and things that could be functions in web/html those parts should be moved to web/lib. If you find copius amounts of HTML in web/lib those parts should be moved to web/template. So you really shouldn't move HTML that's in web/html to template unless you want to make it into a widget like login form, search form, updated packages info box, etc.
Ok, bit of an accident that I also applied my own patch. Reverted now and Michael's patch is applied. I'll make a new thread with my patch, we'll figure out how it should look. -- Callan Barrett