[aur-dev] AUR - Patch - Aur-dev - lists.archlinux.org

[aur-dev] AUR - Patch

older
[aur-dev] Proposal: AUR bug fix...

BaSh

22 Mar 2008 22 Mar '08

1:14 a.m.

Hi ML, I've make a patch for AUR. I've added a button to see out-of-date's package and I've fixed the mode to view the packages: It doesn't lost the sorting mode when moving to the next (or previous) page. This is the patch, it speaks better than me :P Please examine it, ask questions, tell what I need to change to improve it etc. Regards, Andrea -- Andrea `BaSh` Scarpino Arch Linux Trusted User Linux User: #430842

Attachments:

aur_fix_bash.patch.gz (application/x-gzip — 1.2 KB)

Show replies by date

Simo Leone

22 Mar 22 Mar

9:49 a.m.

On Sat, Mar 22, 2008 at 01:14:25AM +0100, BaSh wrote:

...

Hi ML, I've make a patch for AUR. I've added a button to see out-of-date's package and I've fixed the mode to view the packages: It doesn't lost the sorting mode when moving to the next (or previous) page. This is the patch, it speaks better than me :P Please examine it, ask questions, tell what I need to change to improve it etc.

Code looks fine. One thing I don't like is adding another GET variable, but there isn't really a better way. Also adding another button to the UI isn't the prettiest thing in the world. I'm gonna hold off on applying this just yet, in case someone thinks of a better way of doing it. Otherwise I'll push it after this release. -S

BaSh

3:07 p.m.

2008/3/22, Simo Leone :

...

Code looks fine. One thing I don't like is adding another GET variable, but there isn't really a better way. Also adding another button to the UI isn't the prettiest thing in the world.

I'm gonna hold off on applying this just yet, in case someone thinks of a better way of doing it. Otherwise I'll push it after this release. Well, I've improved the GET variable.

I've added a patch for pkgsubmit, I think that every package must have a category. Thanks -- Andrea `BaSh` Scarpino Arch Linux Trusted User Linux User: #430842

Callan Barrett

3:50 p.m.

On Sat, Mar 22, 2008 at 11:07 PM, BaSh wrote:

...

Well, I've improved the GET variable.

I've added a patch for pkgsubmit, I think that every package must have a category.

Can anyone else open this file? I can't extract anything in it. Could you just send them without compression? -- Callan 'wizzomafizzo' Barrett

BaSh

3:57 p.m.

2008/3/22, Callan Barrett :

...

Can anyone else open this file? I can't extract anything in it. Could you just send them without compression? Uhm...you can try this

-- Andrea `BaSh` Scarpino Arch Linux Trusted User Linux User: #430842

Simo Leone

23 Mar 23 Mar

10:58 a.m.

On Sat, Mar 22, 2008 at 03:57:31PM +0100, BaSh wrote:

...

2008/3/22, Callan Barrett :

...
Can anyone else open this file? I can't extract anything in it. Could you just send them without compression? Uhm...you can try this

I'll be including a modified version of the out-of-date search patch soon. As for forcing a package category, it seems like a good idea, but what do we do about the other ~100 packages already in the AUR without categories? I think it might be better not to start forcing it now, and it's reasonable to allow non-categorized packages. Opinions on this one? -S Also for the future, try to label your patches so they're easier to read over quickly, and don't compress them (unless it's a UTF8 encoded translation). You might want to take a look at http://projects.archlinux.org/git/?p=pacman.git;a=blob;f=submitting-patches;... to get an idea of what I mean.

Loui

10:59 p.m.

On Sun, 23 Mar 2008 04:58:45 -0500 Simo Leone wrote:

...

As for forcing a package category, it seems like a good idea, but what do we do about the other ~100 packages already in the AUR without categories? I think it might be better not to start forcing it now, and it's reasonable to allow non-categorized packages. Opinions on this one?

I don't have a problem with non-categorized packages. It's really just corollary to the package description which is the important one.

5884

Age (days ago)

5885

Last active (days ago)

List overview

Download

6 comments

4 participants

participants (4)

BaSh
Callan Barrett
Loui
Simo Leone

[aur-dev] AUR - Patch

BaSh

Simo Leone

BaSh

Callan Barrett

BaSh

Simo Leone

Loui

tags

participants (4)