[aur-dev] [PATCH 1/2] aur.inc: remove unused code
Signed-off-by: Dan McGee
There is really no need to use persistent connections to the database in
this day and age. Most PHP development guides recommend against it, and the
new mysqli interface doesn't even include the functionality.
Add a matching but currently unused db_disconnect() function while we are at
it. Reference counting will cover us for the most part, however.
Signed-off-by: Dan McGee
On Mon, Dec 29, 2008 at 08:46:06PM -0600, Dan McGee wrote:
There is really no need to use persistent connections to the database in this day and age. Most PHP development guides recommend against it, and the new mysqli interface doesn't even include the functionality.
Add a matching but currently unused db_disconnect() function while we are at it. Reference counting will cover us for the most part, however.
Signed-off-by: Dan McGee
--- web/lib/aur.inc | 19 +++++++++++++++---- 1 files changed, 15 insertions(+), 4 deletions(-)
Pushed.
On Mon, Dec 29, 2008 at 08:46:05PM -0600, Dan McGee wrote:
Signed-off-by: Dan McGee
--- If this is a bogus patch and we do need this code around, let me know. A quick git annotate shows that it is from 2004/2005 and is just old garbage.
Pushed.
participants (2)
-
Dan McGee
-
Loui Chang