[aur-dev] [PATCH] Changed some URL's using mod_rewrite
hi, Changed some URL's and used mod_rewrite to make them look nicer. I left the search function of packages. But I still work on it.
On Sun, Mar 7, 2010 at 1:27 PM, psykal@gulli.com <psykal@gulli.com> wrote:
hi, Changed some URL's and used mod_rewrite to make them look nicer. I left the search function of packages. But I still work on it.
We don't use Apache to run the AUR site, so back to the drawing board? Especially not via .htaccess. Lighttpd is currently the webserver being used, but tying that down to anything is not desired. -Dan
hi, fixed FS#12681. http://bugs.archlinux.org/task/12681?project=2 used radio-buttons and added empty() so you can use the do_UnNotify finction without leaving a comment.
On Mon 08 Mar 2010 12:05 +0100, psykal@gulli.com wrote:
fixed FS#12681. http://bugs.archlinux.org/task/12681?project=2
used radio-buttons and added empty() so you can use the do_UnNotify finction without leaving a comment.
I think you missed something. Did you forget to attach the patch?
Am 09.03.2010 17:00, schrieb Loui Chang:
On Mon 08 Mar 2010 12:05 +0100, psykal@gulli.com wrote:
fixed FS#12681. http://bugs.archlinux.org/task/12681?project=2
used radio-buttons and added empty() so you can use the do_UnNotify finction without leaving a comment.
I think you missed something. Did you forget to attach the patch?
Oh yes, sorry. Here it comes again. By the way. It's okay, that i send you patches? Or should i do something bevor? I would like do more patches to give something back :P
On Wed, Mar 10, 2010 at 3:57 PM, psykal@gulli.com <psykal@gulli.com> wrote:
Am 09.03.2010 17:00, schrieb Loui Chang:
On Mon 08 Mar 2010 12:05 +0100, psykal@gulli.com wrote:
fixed FS#12681. http://bugs.archlinux.org/task/12681?project=2
used radio-buttons and added empty() so you can use the do_UnNotify finction without leaving a comment.
I think you missed something. Did you forget to attach the patch?
Oh yes, sorry. Here it comes again. By the way. It's okay, that i send you patches? Or should i do something bevor? I would like do more patches to give something back :P
I think it's ok, Loui will review it from here as well, and other contributors can do it too. Best Regards, Laszlo Papp
On Wednesday 10 March 2010 17:00:27 Laszlo Papp wrote:
I think it's ok, Loui will review it from here as well, and other contributors can do it too. Maybe I did not understand the point here, but I think the patch is wrong.
Why did you add an hidden field? And, do we really need 2 checkbox? One is enough. The empty() checks are fine. -- Andrea
Am 10.03.2010 17:16, schrieb Andrea Scarpino:
On Wednesday 10 March 2010 17:00:27 Laszlo Papp wrote:
I think it's ok, Loui will review it from here as well, and other contributors can do it too. Maybe I did not understand the point here, but I think the patch is wrong.
Why did you add an hidden field? And, do we really need 2 checkbox? One is enough. The empty() checks are fine.
I added the hidden field, cause of the IDs array in the "html/packages.php". I don't want to change too many thinks, so others don't have to change their scripts like aurvote or somethink linke this. If i only use one checkbox, i have to change more of the scripts like: -add in the packages.php if($_POST['do_Notify']=="On") $output = pkg_notify($atype, $ids); else $output = pkg_notify($atype, $ids, False); I'm a bit afraid to change too much and I don't really know what depends on some variables or Requests. If there is only one radiobutton, you can't use the function do_UnNotify. If You like to use only one checkbox, i would like to make a patch. greets Psykal
participants (5)
-
Andrea Scarpino
-
Dan McGee
-
Laszlo Papp
-
Loui Chang
-
psykal＠gulli.com