[aur-dev] [PATCH] Do not display current votes in All Votes
Subject says everything. -- Andrea Scarpino Arch Linux Developer
On Tue, Nov 02, 2010 at 05:47:12PM +0100, Andrea Scarpino wrote:
<?php - $q = "SELECT * FROM TU_VoteInfo ORDER BY Submitted " . $order . $lim; + $q = "SELECT * FROM TU_VoteInfo WHERE End < " . time() . " ORDER BY Submitted " . $order . $lim; $result = db_query($q, $dbh);
$type = __("All Votes");
Looks good in general but why should current votes not be listed in the "All Votes" section? I'd suggest renaming "All Votes" to "Closed Votes" or something similar then.
On Tuesday 02 November 2010 20:09:53 Lukas Fleischer wrote:
On Tue, Nov 02, 2010 at 05:47:12PM +0100, Andrea Scarpino wrote:
<?php
- $q = "SELECT * FROM TU_VoteInfo ORDER BY Submitted " . $order . $lim; + $q = "SELECT * FROM TU_VoteInfo WHERE End < " . time() . " ORDER BY Submitted " . $order . $lim;
$result = db_query($q, $dbh);
$type = __("All Votes");
Looks good in general but why should current votes not be listed in the "All Votes" section? I'd suggest renaming "All Votes" to "Closed Votes" or something similar then. You are right. I suggest to rename it as "Closed Votes" and apply this patch.
-- Andrea Scarpino Arch Linux Developer
On Tuesday 02 November 2010 20:39:14 Andrea Scarpino wrote:
You are right. I suggest to rename it as "Closed Votes" and apply this patch. Do not display current votes in All Votes and rename it as Past Votes.
From d417ea0ba7b48fe685b1932c5bda7acbe0230e7f Mon Sep 17 00:00:00 2001 From: Andrea Scarpino <andrea@archlinux.org> Date: Thu, 18 Nov 2010 09:49:37 +0100 Subject: [PATCH] Do not display current votes in All Votes, and rename it as Past Votes --- web/html/tu.php | 4 ++-- web/lang/it.po | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/web/html/tu.php b/web/html/tu.php index f0038a5..65f00c0 100644 --- a/web/html/tu.php +++ b/web/html/tu.php @@ -130,10 +130,10 @@ if ($atype == "Trusted User" OR $atype == "Developer") { ?> <?php - $q = "SELECT * FROM TU_VoteInfo ORDER BY Submitted " . $order . $lim; + $q = "SELECT * FROM TU_VoteInfo WHERE End < " . time() . " ORDER BY Submitted " . $order . $lim; $result = db_query($q, $dbh); - $type = __("All Votes"); + $type = __("Past Votes"); include("tu_list.php"); $qnext = "SELECT ID FROM TU_VoteInfo"; diff --git a/web/lang/it.po b/web/lang/it.po index 4bd0727..cfcdc48 100644 --- a/web/lang/it.po +++ b/web/lang/it.po @@ -703,7 +703,7 @@ $_t["Back"] = "Indietro"; $_t["Submit a proposal to vote on."] = "Invia una proposta di voto."; -$_t["All Votes"] = "Tutti i voti"; +$_t["Past Votes"] = "Vecchi voti"; $_t["Could not retrieve proposal details."] = "Impossibile recuperare i dettagli della proposta."; -- 1.7.3.2 -- Andrea Scarpino Arch Linux Developer
On Thu 18 Nov 2010 09:52 +0100, Andrea Scarpino wrote:
On Tuesday 02 November 2010 20:39:14 Andrea Scarpino wrote:
You are right. I suggest to rename it as "Closed Votes" and apply this patch. Do not display current votes in All Votes and rename it as Past Votes.
From d417ea0ba7b48fe685b1932c5bda7acbe0230e7f Mon Sep 17 00:00:00 2001 From: Andrea Scarpino <andrea@archlinux.org> Date: Thu, 18 Nov 2010 09:49:37 +0100 Subject: [PATCH] Do not display current votes in All Votes, and rename it as Thanks. I pushed this.
participants (3)
-
Andrea Scarpino
-
Loui Chang
-
Lukas Fleischer