[aur-dev] [PATCH] Removes timeout page and moves login form to header
This removes the need for a timeout page (and probably hacker.php) and moves the login form and status to the header. If your login times out you won't lose your place anymore and links will always work. Works for me but at the moment index_po.php is imported in aur.inc which has to stay until the translations from it for login are moved to aur_po.php. -- Callan 'wizzomafizzo' Barrett
On Jan 3, 2008 10:27 AM, Callan Barrett <wizzomafizzo@gmail.com> wrote:
This removes the need for a timeout page
I love you
On Jan 3, 2008 10:27 AM, Callan Barrett <wizzomafizzo@gmail.com> wrote:
This removes the need for a timeout page (and probably hacker.php) and moves the login form and status to the header. If your login times out you won't lose your place anymore and links will always work. Works for me but at the moment index_po.php is imported in aur.inc which has to stay until the translations from it for login are moved to aur_po.php.
Quick comment. All the git tools expect the following commit message format:
[One line description]
[Body description with long text and sign-off lines] <<<<< This is why your patch shows "Signed off by..." as the filename/title of the patch.
On Jan 4, 2008 2:30 AM, Aaron Griffin <aaronmgriffin@gmail.com> wrote:
Quick comment.
All the git tools expect the following commit message format:
[One line description]
[Body description with long text and sign-off lines] <<<<<
This is why your patch shows "Signed off by..." as the filename/title of the patch.
Oh right, gotta remember that next time. Thanks. -- Callan 'wizzomafizzo' Barrett
On 1/3/08, Callan Barrett <wizzomafizzo@gmail.com> wrote:
This removes the need for a timeout page (and probably hacker.php) and moves the login form and status to the header. If your login times out you won't lose your place anymore and links will always work. Works for me but at the moment index_po.php is imported in aur.inc which has to stay until the translations from it for login are moved to aur_po.php.
-- Callan 'wizzomafizzo' Barrett
Applied to my testing branch. I would like to mirror Aaron's sentiments. Maybe...without the uncomfortably long hug though.. ;)
Hey Callan. I guess you're working off of the testing branch? Please have a look at web/template/login_form.php :D I put down the mechanics but I didn't actually put it into use. I couldn't be sure if a log in form on every page is necessary. Maybe you only really need a login form when you need to log in, like if you want to post a comment.
On Jan 4, 2008 8:24 AM, Loui <louipc.ist@gmail.com> wrote:
Hey Callan. I guess you're working off of the testing branch? Please have a look at web/template/login_form.php :D I put down the mechanics but I didn't actually put it into use. I couldn't be sure if a log in form on every page is necessary. Maybe you only really need a login form when you need to log in, like if you want to post a comment.
Hello Loui, I am working off the testing branch, didn't notice the login form template though. I'll take a look at it and I think it's an alright idea to split this up into two files but I don't really agree with only having the login form on just a few pages, I think it should still stay in the header (or in its own function called on every page, but html_header already does that and it would mean changing most of the code related). I'll give an example, if I'm given a url to package details page that I need to delete or orphan but I've been logged out it would be way more convenient if I could log back in using that page, not a whole lot to disrupt the work flow. This isn't really uncommon and can be applied basically anywhere on the AUR because let's face it, there's really only about 5 "pages" on the AUR and at least as a TU they all need to be used logged in. A good example of how convenient this is is on the bug tracker and I doubt that takes any extra resources. -- Callan 'wizzomafizzo' Barrett
participants (4)
-
Aaron Griffin
-
Callan Barrett
-
eliott
-
Loui