[aur-dev] [PATCH] Replace task references in comments with actual links
Search comments for references to Flyspray tasks (in the format FS#???)
and make them into clickable links.
Signed-off-by: Ragnis Armus
I think your mail client borked your message. You should try sending the patch via `git send-email`. If not, I would probably recommend looking at the rest of the file and following its style along with the guidelines [1]. Mark Weiman [1] https://git.archlinux.org/aurweb.git/tree/doc/CodingGuidelines
On Fri, 21 Apr 2017 at 11:15:34, Ragnis Armus via aur-dev wrote:
Search comments for references to Flyspray tasks (in the format FS#???) and make them into clickable links.
Signed-off-by: Ragnis Armus
--- conf/config.proto | 1 + web/lib/aur.inc.php | 34 +++++++++++++++++++++++++++++++++- 2 files changed, 34 insertions(+), 1 deletion(-) [...]
This reminded me of a previous attempt to move comment rendering to an external script which makes the comment parser much more pleasant to read and also makes it much easier to add extended functionality. I just revived the code I had written a while ago and built a patch series that I am going to submit in a minute. Unfortunately, this makes your patch kind of obsolete, but maybe you want to redo it based on the new implementation? If you do, please also use git-send-email(1) as Mark suggested. Thank you for contributing! Regards, Lukas
participants (3)
-
Lukas Fleischer
-
Mark Weiman
-
Ragnis Armus