[aur-dev] [PATCH] Remove 'new' tag from updates table
Signed-off-by: Marcel Korpel <marcel.korpel@gmail.com> --- web/html/css/aurweb.css | 8 -------- web/lib/stats.inc.php | 2 +- web/template/stats/updates_table.php | 5 ----- 3 files changed, 1 insertion(+), 14 deletions(-) diff --git a/web/html/css/aurweb.css b/web/html/css/aurweb.css index 4c3fbe5..56158d2 100644 --- a/web/html/css/aurweb.css +++ b/web/html/css/aurweb.css @@ -16,10 +16,6 @@ margin: 0 .25em; } -#pkg-updates td.pkg-new { - padding: 0 .5em; -} - #pkg-stats td.stat-desc { white-space: normal; } @@ -45,10 +41,6 @@ text-overflow: ellipsis; } -#pkg-updates td.pkg-new { - width: 16px; -} - #pkg-updates td.pkg-date { text-align:right; } diff --git a/web/lib/stats.inc.php b/web/lib/stats.inc.php index 5a24591..80619fe 100644 --- a/web/lib/stats.inc.php +++ b/web/lib/stats.inc.php @@ -11,7 +11,7 @@ function updates_table() { $dbh = DB::connect(); $key = 'recent_updates'; if(!($newest_packages = get_cache_value($key))) { - $q = 'SELECT Packages.Name, Version, ModifiedTS, SubmittedTS '; + $q = 'SELECT Packages.Name, Version, ModifiedTS '; $q.= 'FROM Packages INNER JOIN PackageBases ON '; $q.= 'Packages.PackageBaseID = PackageBases.ID '; $q.= 'WHERE PackageBases.PackagerUID IS NOT NULL '; diff --git a/web/template/stats/updates_table.php b/web/template/stats/updates_table.php index cecfb9f..9c295c0 100644 --- a/web/template/stats/updates_table.php +++ b/web/template/stats/updates_table.php @@ -9,11 +9,6 @@ <td class="pkg-name"> <a href="<?= get_pkg_uri($row["Name"]); ?>" title="<?= htmlspecialchars($row["Name"]) . ' ' . htmlspecialchars($row["Version"]); ?>"><?= htmlspecialchars($row["Name"]) . ' ' . htmlspecialchars($row["Version"]); ?></a> </td> - <td class="pkg-new"> - <?php if ($row["ModifiedTS"] - $row["SubmittedTS"] < 3600): ?> - <img src="images/new.svg" alt="New!" /> - <?php endif; ?> - </td> <td class="pkg-date"> <span><?= gmdate("Y-m-d H:i", intval($row["ModifiedTS"])); ?></span> </td> -- 2.7.0
On Sun, 31 Jan 2016 at 19:48:15, Marcel Korpel wrote:
Signed-off-by: Marcel Korpel <marcel.korpel@gmail.com> --- web/html/css/aurweb.css | 8 -------- web/lib/stats.inc.php | 2 +- web/template/stats/updates_table.php | 5 ----- 3 files changed, 1 insertion(+), 14 deletions(-) [...]
It would be nice to have the rationale in the commit message (icon was not easy to recognize, consistency with archweb, not very useful in the first place). Also, shouldn't this patch remove web/html/images/new.svg from the source tree?
It was hard to make it consistent with the other new icons from Open Iconic and it hadn't much use after all. Signed-off-by: Marcel Korpel <marcel.korpel@gmail.com> --- Changes since v1: * Removed icon web/html/images/new.svg * Elaborated in commit message web/html/css/aurweb.css | 8 -------- web/html/images/new.svg | 3 --- web/lib/stats.inc.php | 2 +- web/template/stats/updates_table.php | 5 ----- 4 files changed, 1 insertion(+), 17 deletions(-) delete mode 100644 web/html/images/new.svg diff --git a/web/html/css/aurweb.css b/web/html/css/aurweb.css index 4c3fbe5..56158d2 100644 --- a/web/html/css/aurweb.css +++ b/web/html/css/aurweb.css @@ -16,10 +16,6 @@ margin: 0 .25em; } -#pkg-updates td.pkg-new { - padding: 0 .5em; -} - #pkg-stats td.stat-desc { white-space: normal; } @@ -45,10 +41,6 @@ text-overflow: ellipsis; } -#pkg-updates td.pkg-new { - width: 16px; -} - #pkg-updates td.pkg-date { text-align:right; } diff --git a/web/html/images/new.svg b/web/html/images/new.svg deleted file mode 100644 index 87f1a4c..0000000 --- a/web/html/images/new.svg +++ /dev/null @@ -1,3 +0,0 @@ -<svg xmlns="http://www.w3.org/2000/svg" width="8" height="8" viewBox="0 0 8 8"> - <path style="fill:#66aa22;fill-opacity:1" d="M4 0c-2.21 0-4 1.79-4 4s1.79 4 4 4 4-1.79 4-4-1.79-4-4-4zm0 1l3 3h-2v3h-2v-3h-2l3-3z" /> -</svg> diff --git a/web/lib/stats.inc.php b/web/lib/stats.inc.php index 5a24591..80619fe 100644 --- a/web/lib/stats.inc.php +++ b/web/lib/stats.inc.php @@ -11,7 +11,7 @@ function updates_table() { $dbh = DB::connect(); $key = 'recent_updates'; if(!($newest_packages = get_cache_value($key))) { - $q = 'SELECT Packages.Name, Version, ModifiedTS, SubmittedTS '; + $q = 'SELECT Packages.Name, Version, ModifiedTS '; $q.= 'FROM Packages INNER JOIN PackageBases ON '; $q.= 'Packages.PackageBaseID = PackageBases.ID '; $q.= 'WHERE PackageBases.PackagerUID IS NOT NULL '; diff --git a/web/template/stats/updates_table.php b/web/template/stats/updates_table.php index cecfb9f..9c295c0 100644 --- a/web/template/stats/updates_table.php +++ b/web/template/stats/updates_table.php @@ -9,11 +9,6 @@ <td class="pkg-name"> <a href="<?= get_pkg_uri($row["Name"]); ?>" title="<?= htmlspecialchars($row["Name"]) . ' ' . htmlspecialchars($row["Version"]); ?>"><?= htmlspecialchars($row["Name"]) . ' ' . htmlspecialchars($row["Version"]); ?></a> </td> - <td class="pkg-new"> - <?php if ($row["ModifiedTS"] - $row["SubmittedTS"] < 3600): ?> - <img src="images/new.svg" alt="New!" /> - <?php endif; ?> - </td> <td class="pkg-date"> <span><?= gmdate("Y-m-d H:i", intval($row["ModifiedTS"])); ?></span> </td> -- 2.7.0
On Sun, 31 Jan 2016 at 20:07:45, Marcel Korpel wrote:
It was hard to make it consistent with the other new icons from Open Iconic and it hadn't much use after all.
Signed-off-by: Marcel Korpel <marcel.korpel@gmail.com> --- Changes since v1: * Removed icon web/html/images/new.svg * Elaborated in commit message
web/html/css/aurweb.css | 8 -------- web/html/images/new.svg | 3 --- web/lib/stats.inc.php | 2 +- web/template/stats/updates_table.php | 5 ----- 4 files changed, 1 insertion(+), 17 deletions(-) delete mode 100644 web/html/images/new.svg [...]
Looks good now. Applied, thanks!
participants (2)
-
Lukas Fleischer
-
Marcel Korpel