[aur-dev] [PATCH] Add CDATA markers
--- web/html/home.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/web/html/home.php b/web/html/home.php index 0b51d55..e857b8d 100644 --- a/web/html/home.php +++ b/web/html/home.php @@ -109,7 +109,7 @@ $dbh = db_connect(); </div> <script type="text/javascript" src="https://ajax.googleapis.com/ajax/libs/jquery/1.8.2/jquery.min.js"></script> <script type="text/javascript" src="/js/bootstrap-typeahead.js"></script> -<script type="text/javascript"> +<script type="text/javascript">//<![CDATA[ $(document).ready(function() { $('#pkgsearch-field').typeahead({ source: function(query, callback) { @@ -123,6 +123,6 @@ $(document).ready(function() { items: 20 }).attr('autocomplete', 'off'); }); -</script> +//]]></script> <?php html_footer(AUR_VERSION); -- 1.8.1.1
On Fri, Feb 1, 2013 at 9:19 AM, Marcel Korpel <marcel.lists@gmail.com> wrote:
---
Was expecting to find a "why" in here somewhere.
web/html/home.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/web/html/home.php b/web/html/home.php index 0b51d55..e857b8d 100644 --- a/web/html/home.php +++ b/web/html/home.php @@ -109,7 +109,7 @@ $dbh = db_connect(); </div> <script type="text/javascript" src="https://ajax.googleapis.com/ajax/libs/jquery/1.8.2/jquery.min.js"></script> <script type="text/javascript" src="/js/bootstrap-typeahead.js"></script> -<script type="text/javascript"> +<script type="text/javascript">//<![CDATA[ $(document).ready(function() { $('#pkgsearch-field').typeahead({ source: function(query, callback) { @@ -123,6 +123,6 @@ $(document).ready(function() { items: 20 }).attr('autocomplete', 'off'); }); -</script> +//]]></script> <?php html_footer(AUR_VERSION); -- 1.8.1.1
On Fri, Feb 1, 2013 at 11:22 PM, Dan McGee <dpmcgee@gmail.com> wrote:
On Fri, Feb 1, 2013 at 9:19 AM, Marcel Korpel <marcel.lists@gmail.com> wrote:
---
Was expecting to find a "why" in here somewhere.
Because the AUR is using XHTML, we should properly add CDATA markers. See http://dorward.me.uk/www/comments-cdata/
On Fri, Feb 1, 2013 at 10:19 AM, Marcel Korpel <marcel.lists@gmail.com> wrote:
---
Does this change have any noticeable effects on browsers? The Content-Type on the AUR is actually text/html and not application/xhtml+xml, which in my brief searching seemed to suggest CDATA wouldn't be needed.
web/html/home.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/web/html/home.php b/web/html/home.php index 0b51d55..e857b8d 100644 --- a/web/html/home.php +++ b/web/html/home.php @@ -109,7 +109,7 @@ $dbh = db_connect(); </div> <script type="text/javascript" src="https://ajax.googleapis.com/ajax/libs/jquery/1.8.2/jquery.min.js"></script> <script type="text/javascript" src="/js/bootstrap-typeahead.js"></script> -<script type="text/javascript"> +<script type="text/javascript">//<![CDATA[ $(document).ready(function() { $('#pkgsearch-field').typeahead({ source: function(query, callback) { @@ -123,6 +123,6 @@ $(document).ready(function() { items: 20 }).attr('autocomplete', 'off'); }); -</script> +//]]></script> <?php html_footer(AUR_VERSION); -- 1.8.1.1
On Sun, Feb 3, 2013 at 3:39 PM, canyonknight <canyonknight@gmail.com> wrote:
On Fri, Feb 1, 2013 at 10:19 AM, Marcel Korpel <marcel.lists@gmail.com> wrote: Does this change have any noticeable effects on browsers? The Content-Type on the AUR is actually text/html and not application/xhtml+xml, which in my brief searching seemed to suggest CDATA wouldn't be needed.
Yeah, that's true. Then just trash this patch.
participants (3)
-
canyonknight
-
Dan McGee
-
Marcel Korpel