[aur-dev] [PATCH] Make whitespace significant in comments. Fixes FS#14391.
Originally reported the bug [1] a while ago, but butted heads into it again recently [2]. Here's my rather small patch to fix the issue. Note that this would cause the column to stretch out to fit its contents, possibly breaking layout. However, I felt that to be an adequate compromise given the goal of altering comments as little as possible. [1] http://bugs.archlinux.org/task/14391 [2] http://aur.archlinux.org/packages.php?ID=14301 --- web/html/css/arch.css | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/web/html/css/arch.css b/web/html/css/arch.css index de871be..830c84f 100644 --- a/web/html/css/arch.css +++ b/web/html/css/arch.css @@ -360,6 +360,7 @@ blockquote.code { margin-left: 5px; padding: 2px; font-family: monospace; + white-space: pre; } .pkgoutput { -- 1.6.6
On Thu 14 Jan 2010 00:30 -0500, Ronuk Raval wrote:
Originally reported the bug [1] a while ago, but butted heads into it again recently [2]. Here's my rather small patch to fix the issue.
Note that this would cause the column to stretch out to fit its contents, possibly breaking layout. However, I felt that to be an adequate compromise given the goal of altering comments as little as possible.
While I don't like altering comments, I also don't like people posting large PKGBUILDs and patches in that section as they quickly become obsolete. That's why I never bothered changing it. The proper text is still preserved in the emails and database. I'd think maintainers would sooner extract PKGBUILDs and patches from their email, but I could be wrong. I wouldn't mind applying this patch anymore though. I can just put a big message asking people to use email or pastebin to suggest changes to maintainers. Hopefully people can follow that practice. Please check your email client. Somehow it altered the patch and tabs were converted to spaces, so this won't apply.
On Thu, Feb 4, 2010 at 10:01 PM, Loui Chang
On Thu 14 Jan 2010 00:30 -0500, Ronuk Raval wrote:
Originally reported the bug [1] a while ago, but butted heads into it again recently [2]. Here's my rather small patch to fix the issue.
Note that this would cause the column to stretch out to fit its contents, possibly breaking layout. However, I felt that to be an adequate compromise given the goal of altering comments as little as possible.
While I don't like altering comments, I also don't like people posting large PKGBUILDs and patches in that section as they quickly become obsolete.
Why not limit the comment length then? Just add a note saying "comments over X characters in length will be truncated. if you are looking to put a whole PKGBUILD here, you probably shouldn't..." -Dan
participants (3)
-
Dan McGee
-
Loui Chang
-
Ronuk Raval