[aur-dev] some patches for cleanup and other stuff
In response to a forum thread about stagnating aur development, I worked on the aur a bit when I was bored today. The first patch is probably the most invasive, and I must admit that I haven't tested it (offline -- not dev sandbox). I think the spirit of this patch, if not the implementation of it, is needed. The rss2 -> rss rename would require a simple apache rewrite rule should it go to production. I made notes on the patch itself for my reasoning as to the rename. The rest are misc patches and smaller cleanup elements. Feel free to use some, none, or all of them. -- elij (cactus)
--- web/html/index.php | 2 - web/html/pkgsubmit.php | 5 +- web/lib/aurjson.class.php | 2 +- web/lib/pkgfuncs.inc | 76 +++++----------------------- web/lib/stats.inc | 10 ++-- web/template/pkg_details.php | 17 ++---- web/template/pkg_search_form.php | 2 +- web/template/pkg_search_results.php | 4 -- web/template/stats/general_stats_table.php | 4 +- web/template/stats/user_table.php | 4 +- 10 files changed, 32 insertions(+), 94 deletions(-)
--- tupkg/README.txt | 99 ------- tupkg/client/communitypkg | 132 --------- tupkg/client/tupkg | 216 -------------- tupkg/scripts/run-tupkgs | 4 - tupkg/scripts/run-tupkgupdate | 19 -- tupkg/scripts/stop-tupkgs | 3 - tupkg/server/tupkgs | 329 ---------------------- tupkg/server/tupkgs.conf | 10 - tupkg/update/tupkgupdate | 622 ----------------------------------------- tupkg/update/tupkgupdate-lite | 513 --------------------------------- tupkg/update/tupkgupdate64 | 579 -------------------------------------- 11 files changed, 0 insertions(+), 2526 deletions(-) delete mode 100644 tupkg/README.txt delete mode 100644 tupkg/client/communitypkg delete mode 100755 tupkg/client/tupkg delete mode 100755 tupkg/scripts/run-tupkgs delete mode 100755 tupkg/scripts/run-tupkgupdate delete mode 100755 tupkg/scripts/stop-tupkgs delete mode 100755 tupkg/server/tupkgs delete mode 100644 tupkg/server/tupkgs.conf delete mode 100755 tupkg/update/tupkgupdate delete mode 100755 tupkg/update/tupkgupdate-lite delete mode 100755 tupkg/update/tupkgupdate64
- removed excessive string catenation, replaced with variable substitution - consolidated http/https protocol checks - simplified host header parse (centralized) - moved cache file to /tmp, to remove need to custom permission directory in webdir --- web/html/rss2.php | 31 ++++++++++++------------------- web/html/xml/README.txt | 2 -- 2 files changed, 12 insertions(+), 21 deletions(-) delete mode 100644 web/html/xml/README.txt
--- web/README | 15 ++++----------- 1 files changed, 4 insertions(+), 11 deletions(-)
--- web/lib/stats.inc | 6 ++-- web/template/stats/general_stats_table.php | 32 ----------------------- web/template/stats/updates_table.php | 39 ---------------------------- web/template/stats/user_table.php | 31 ---------------------- web/template/stats_general_table.php | 32 +++++++++++++++++++++++ web/template/stats_updates_table.php | 39 ++++++++++++++++++++++++++++ web/template/stats_user_table.php | 31 ++++++++++++++++++++++ 7 files changed, 105 insertions(+), 105 deletions(-) delete mode 100644 web/template/stats/general_stats_table.php delete mode 100644 web/template/stats/updates_table.php delete mode 100644 web/template/stats/user_table.php create mode 100644 web/template/stats_general_table.php create mode 100644 web/template/stats_updates_table.php create mode 100644 web/template/stats_user_table.php
--- README | 107 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ README.txt | 107 ------------------------------------------------------------ 2 files changed, 107 insertions(+), 107 deletions(-) create mode 100644 README delete mode 100644 README.txt
jsonp callback should have a content type of text/javascipt, since it specifies a callback function wrapping json data, and is not soley json data. --- web/lib/aurjson.class.php | 12 ++++++++---- 1 files changed, 8 insertions(+), 4 deletions(-)
changed file name, as the 2 is relatively meaningless. I think at one time it qualified it as a rss2.0 feed, but the distinction is valueless at this point, since the generated xml itself declares the rss version. make sure to set an apache rewrite rule for any production systems that require it. --- web/html/rss.php | 48 ++++++++++++++++++++++++++++++++++++++++++++++++ web/html/rss2.php | 48 ------------------------------------------------ 2 files changed, 48 insertions(+), 48 deletions(-) create mode 100644 web/html/rss.php delete mode 100644 web/html/rss2.php
Kind of pointless to keep it around. Especially in here. --- web/html/user_docs.html | 160 ----------------------------------------------- 1 files changed, 0 insertions(+), 160 deletions(-) delete mode 100644 web/html/user_docs.html
oh noes! one of my patches was too large, and is waiting moderator approval. ha! [2/9] will arrive once/if someone approves it apparently. ;) On Sun, Sep 27, 2009 at 4:40 PM, elij <elij.mx@gmail.com> wrote:
In response to a forum thread about stagnating aur development, I worked on the aur a bit when I was bored today.
The first patch is probably the most invasive, and I must admit that I haven't tested it (offline -- not dev sandbox). I think the spirit of this patch, if not the implementation of it, is needed.
The rss2 -> rss rename would require a simple apache rewrite rule should it go to production. I made notes on the patch itself for my reasoning as to the rename.
The rest are misc patches and smaller cleanup elements. Feel free to use some, none, or all of them.
-- elij (cactus)
On Sun 27 Sep 2009 16:40 -0700, elij wrote:
In response to a forum thread about stagnating aur development, I worked on the aur a bit when I was bored today.
The first patch is probably the most invasive, and I must admit that I haven't tested it (offline -- not dev sandbox). I think the spirit of this patch, if not the implementation of it, is needed.
The rss2 -> rss rename would require a simple apache rewrite rule should it go to production. I made notes on the patch itself for my reasoning as to the rename.
The rest are misc patches and smaller cleanup elements. Feel free to use some, none, or all of them.
I pushed most of these, in a different order. Hah. Thanks for the contribution.
participants (2)
-
elij
-
Loui Chang