[aur-dev] Ghost comment notifications
I have received two of these so far, is there a bug in AUR? I don't know whether comments have actually been posted to a package of mine, or these are just blanks.
To: Subject: AUR Comment Notification for Sender: nobody <nobody@archlinux.org>
A comment has been added to , you may view it at: http://aur.archlinux.org/packages.php?do_Details=1&ID=
--- You received this e-mail because you chose to recieve notifications of new comments on this package, if you no longer wish to recieve notifications about this package, please go the the above package page and click the UnNotify.
-- Sebastian Nowicki
On Tue, 2008-05-06 at 22:53 +0800, Sebastian Nowicki wrote:
I have received two of these so far, is there a bug in AUR? I don't know whether comments have actually been posted to a package of mine, or these are just blanks.
I also get that sometimes. I guess the poster deletes the comments before I read it. Would maybe be good to have the comment in the mail, so that nothing gets hidden/lost....
On 06/05/2008, at 11:25 PM, Timm Preetz wrote:
On Tue, 2008-05-06 at 22:53 +0800, Sebastian Nowicki wrote:
I have received two of these so far, is there a bug in AUR? I don't know whether comments have actually been posted to a package of mine, or these are just blanks.
I also get that sometimes.
I guess the poster deletes the comments before I read it.
Would maybe be good to have the comment in the mail, so that nothing gets hidden/lost....
There's no ID in the URL for the package, or package names in the email subject and body. If that is the case then there must be some weird caching going on, and the email shouldn't be set anyway. I'm not really sure what could cause this, but I haven't really looked into the scripts that send these emails either. -- Sebastian Nowicki
On Wed, 2008-05-07 at 00:17 +0800, Sebastian Nowicki wrote:
There's no ID in the URL for the package, or package names in the email subject and body. If that is the case then there must be some weird caching going on, and the email shouldn't be set anyway. I'm not really sure what could cause this, but I haven't really looked into the scripts that send these emails either.
Ahh, ok. I must admit, I didn't read your mail very closely the first time. This must be even more annoying than my case.
Looking at the script pkgedit.php, receiving the comment through email is simply a matter of doing something like : Changing this : $body = "A comment has been added to ".$row['Name'].", you may view it at:\nhttp://aur.archlinux.org/packages.php?do_Details=1&ID=".$_REQUEST["ID"]."\n\n\n---\nYou received this e-mail because you chose to recieve notifications of new comments on this package, if you no longer wish to recieve notifications about this package, please go the the above package page and click the UnNotify."; To : $body = $row['Name'] . " has been commented as follow :\n\n" $body. = $_REQUEST['comment']."\n\n" $body = "You may also view it at:\nhttp://aur.archlinux.org/packages.php?do_Details=1&ID=".$_REQUEST["ID"]."\n\n\n---\nYou received this e-mail because you chose to recieve notifications of new comments on this package, if you no longer wish to recieve notifications about this package, please go the the above package page and click the UnNotify."; But: The comment must be sanitized before sending to suscribers. Maybe retrieve it after it is inserted in the DB. Mario On Tue, May 6, 2008 11:25 am, Timm Preetz wrote:
On Tue, 2008-05-06 at 22:53 +0800, Sebastian Nowicki wrote:
I have received two of these so far, is there a bug in AUR? I don't know whether comments have actually been posted to a package of mine, or these are just blanks.
I also get that sometimes.
I guess the poster deletes the comments before I read it.
Would maybe be good to have the comment in the mail, so that nothing gets hidden/lost....
participants (3)
-
mario.stg＠sympatico.ca
-
Sebastian Nowicki
-
Timm Preetz