[aur-dev] [PATCH] Add explanation for Popularity field in search results.
Fixes FS#45327 Signed-off-by: Leonidas Spyropoulos <artafinde@gmail.com> --- web/html/css/aurweb.css | 4 ++++ web/template/pkg_search_results.php | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/web/html/css/aurweb.css b/web/html/css/aurweb.css index a3f43bd..5394281 100644 --- a/web/html/css/aurweb.css +++ b/web/html/css/aurweb.css @@ -85,3 +85,7 @@ legend { p.important { font-weight: bold; } + +span.hover-help { + border-bottom: 1px dotted black; +} diff --git a/web/template/pkg_search_results.php b/web/template/pkg_search_results.php index 13d9bfc..42f79db 100644 --- a/web/template/pkg_search_results.php +++ b/web/template/pkg_search_results.php @@ -35,7 +35,7 @@ if (!$result): ?> <th><a href="?<?= mkurl('SB=n&SO=' . $SO_next) ?>"><?= __("Name") ?></a></th> <th><?= __("Version") ?></th> <th><a href="?<?= mkurl('SB=v&SO=' . $SO_next) ?>"><?= __("Votes") ?></a></th> - <th><a href="?<?= mkurl('SB=p&SO=' . $SO_next) ?>"><?= __("Popularity") ?></a></th> + <th><a href="?<?= mkurl('SB=p&SO=' . $SO_next) ?>"><?= __("Popularity") ?></a><span title="<?=__('Popularity is calculated as the sum of all votes with each vote being weighted with a factor of 0.98 per day since its creation.') ?>" class="hover-help"><sup>?</sup></span></th> <?php if ($SID): ?> <th><a href="?<?= mkurl('SB=w&SO=' . $SO_next) ?>"><?= __("Voted") ?></a></th> <th><a href="?<?= mkurl('SB=o&SO=' . $SO_next) ?>"><?= __("Notify") ?></a></th> -- 2.4.3
On Mon, 15 Jun 2015 at 10:45:19, Leonidas Spyropoulos wrote:
Fixes FS#45327
Clarification: We do not end the commit title with a full stop. Only sentences in the detailed description below. What I meant is that the commit message should look like Add explanation for Popularity field in search results Fixes FS#45327. I fixed it locally for now :)
Signed-off-by: Leonidas Spyropoulos <artafinde@gmail.com> --- web/html/css/aurweb.css | 4 ++++ web/template/pkg_search_results.php | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) [...]
Applied with a minor style fix. Thanks!
* Lukas Fleischer <lfleischer@archlinux.org> (Mon, 15 Jun 2015 10:58:50 +0200):
Applied with a minor style fix. Thanks!
Can you add a `cursor: help;` rule? The default text cursor completely overlaps the question mark and border and the usual cursor when a title text is available is the help cursor. Best, Marcel
On 15/06/15, Lukas Fleischer wrote:
On Mon, 15 Jun 2015 at 10:45:19, Leonidas Spyropoulos wrote:
Fixes FS#45327
Clarification: We do not end the commit title with a full stop. Only sentences in the detailed description below. What I meant is that the commit message should look like
Add explanation for Popularity field in search results
Fixes FS#45327.
I fixed it locally for now :)
Aha! Sorry for that.
Signed-off-by: Leonidas Spyropoulos <artafinde@gmail.com> --- web/html/css/aurweb.css | 4 ++++ web/template/pkg_search_results.php | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) [...]
Applied with a minor style fix. Thanks!
Thanks, Leonidas --
participants (3)
-
Leonidas Spyropoulos
-
Lukas Fleischer
-
Marcel Korpel