[aur-dev] [PATCH] pkg_comment_form.php: Remove redundant label for the comment box
Comment box already uses <h2> tag. Additional label is not needed. Reported-by: Dave Reisner <d@falconindy.com> Signed-off-by: canyonknight <canyonknight@gmail.com> --- web/template/pkg_comment_form.php | 1 - 1 file changed, 1 deletion(-) diff --git a/web/template/pkg_comment_form.php b/web/template/pkg_comment_form.php index 9315b0a..a0e7f68 100644 --- a/web/template/pkg_comment_form.php +++ b/web/template/pkg_comment_form.php @@ -12,7 +12,6 @@ if (isset($_REQUEST['comment']) && check_token()) { <input type="hidden" name="token" value="<?= htmlspecialchars($_COOKIE['AURSID']) ?>" /> </div> <p> - <label for="id_comment"><?= __("Comment") . ':' ?></label> <textarea id="id_comment" name="comment" cols="80" rows="10"></textarea> </p> <p> -- 1.7.12.2
On Mon, Oct 08, 2012 at 09:38:38PM -0400, canyonknight wrote:
Comment box already uses <h2> tag. Additional label is not needed.
Reported-by: Dave Reisner <d@falconindy.com> Signed-off-by: canyonknight <canyonknight@gmail.com> --- web/template/pkg_comment_form.php | 1 - 1 file changed, 1 deletion(-)
diff --git a/web/template/pkg_comment_form.php b/web/template/pkg_comment_form.php index 9315b0a..a0e7f68 100644 --- a/web/template/pkg_comment_form.php +++ b/web/template/pkg_comment_form.php @@ -12,7 +12,6 @@ if (isset($_REQUEST['comment']) && check_token()) { <input type="hidden" name="token" value="<?= htmlspecialchars($_COOKIE['AURSID']) ?>" /> </div> <p> - <label for="id_comment"><?= __("Comment") . ':' ?></label>
You should also remove the label of the submit button to remove the indentation. The other patches look fine to me.
<textarea id="id_comment" name="comment" cols="80" rows="10"></textarea> </p> <p> -- 1.7.12.2
Comment box already uses <h2> tag. Additional label is not needed. Also remove label for form submit button. Reported-by: Dave Reisner <d@falconindy.com> Signed-off-by: canyonknight <canyonknight@gmail.com> --- web/template/pkg_comment_form.php | 2 -- 1 file changed, 2 deletions(-) diff --git a/web/template/pkg_comment_form.php b/web/template/pkg_comment_form.php index 9315b0a..903173d 100644 --- a/web/template/pkg_comment_form.php +++ b/web/template/pkg_comment_form.php @@ -12,11 +12,9 @@ if (isset($_REQUEST['comment']) && check_token()) { <input type="hidden" name="token" value="<?= htmlspecialchars($_COOKIE['AURSID']) ?>" /> </div> <p> - <label for="id_comment"><?= __("Comment") . ':' ?></label> <textarea id="id_comment" name="comment" cols="80" rows="10"></textarea> </p> <p> - <label></label> <input type="submit" value="<?= __("Add Comment") ?>" /> </p> </fieldset> -- 1.7.12.2
participants (2)
-
canyonknight
-
Lukas Fleischer