[aur-dev] [PATCH] Usage of try_login() and login_form.php - Aur-dev - lists.archlinux.org

newer
[aur-dev] Mini Roadmap

[aur-dev] [PATCH] Usage of try_login() and login_form.php

older
[aur-dev] [PATCH] Fixed a couple...

Loui

7 Feb 2008 7 Feb '08

2:42 a.m.

I wrote a bunch of functions awhile ago to ease logins and username/passwd checking. This patch puts them into effect and taking the login code out of html_header(). Much cleaner methinks. Enjoy.

Attachments:

0001-Put-login-into-its-own-function.-Utilise-login-form.patch (text/x-patch — 7.9 KB)

Show replies by date

Callan Barrett

7 Feb 7 Feb

9:12 a.m.

On Feb 7, 2008 11:42 AM, Loui wrote:

I wrote a bunch of functions awhile ago to ease logins and username/passwd checking. This patch puts them into effect and taking the login code out of html_header(). Much cleaner methinks. Enjoy.

I haven't taken a good look at the code yet but I can't even log in with this patch applied, works fine without it. Is it working for you? -- Callan 'wizzomafizzo' Barrett

Loui

8 Feb 8 Feb

1:12 a.m.

hmm works fine for me... this patch is against testing On Thu, Feb 7, 2008 at 4:12 AM, Callan Barrett wrote:

On Feb 7, 2008 11:42 AM, Loui wrote:

...
I wrote a bunch of functions awhile ago to ease logins and username/passwd checking. This patch puts them into effect and taking the login code out of html_header(). Much cleaner methinks. Enjoy.

I haven't taken a good look at the code yet but I can't even log in with this patch applied, works fine without it. Is it working for you?

-- Callan 'wizzomafizzo' Barrett

Loui

1:18 a.m.

What kind of errors or oddities do you get? Could you point me to your test site? On Thu, Feb 7, 2008 at 8:12 PM, Loui wrote:

hmm works fine for me... this patch is against testing

Loui

10:24 p.m.

Hmm the password checking might be rejecting you if your passwd is less than PASSWD_MIN_LEN Here's a patch to so that it only checks for a non-empty passwd. Let me know how it goes. Thanks!

Loui

17 Feb 17 Feb

10:41 p.m.

Here she is. On Fri, Feb 8, 2008 at 5:24 PM, Loui wrote:

Hmm the password checking might be rejecting you if your passwd is less than PASSWD_MIN_LEN Here's a patch to so that it only checks for a non-empty passwd. Let me know how it goes. Thanks!

eliott

10:52 p.m.

On 2/17/08, Loui wrote:

Here she is.

Just the 0002 patch, or the 0001 patch as well?

Loui

10:59 p.m.

Both the 0002 patch makes the passwd checker only check for >0 char passwd rather than > PASSWD_MIN_LEN I guess some people might have reealy bad passwds heh. I can set up my git repo if that'd be more convenient for you too. On Sun, Feb 17, 2008 at 5:52 PM, eliott wrote:

On 2/17/08, Loui wrote:

...
Here she is.

Just the 0002 patch, or the 0001 patch as well?

Callan Barrett

21 Feb 21 Feb

12:35 p.m.

On Mon, Feb 18, 2008 at 7:59 AM, Loui wrote:

Both the 0002 patch makes the passwd checker only check for >0 char passwd rather than > PASSWD_MIN_LEN I guess some people might have reealy bad passwds heh.

I can set up my git repo if that'd be more convenient for you too.

On Sun, Feb 17, 2008 at 5:52 PM, eliott wrote:

...
On 2/17/08, Loui wrote:

...
Here she is.

Just the 0002 patch, or the 0001 patch as well?

I hate to be a buzzkill again but I still can't log in or log out (by logging in with on a previous revision) with this patch applied even with a password greater than PASSWD_MIN_LEN. I'm not getting any errors from either except for nothing happening. -- Callan 'wizzomafizzo' Barrett

Loui

12:56 p.m.

On 2/21/08, Callan Barrett wrote:

On Mon, Feb 18, 2008 at 7:59 AM, Loui wrote:

...
Both the 0002 patch makes the passwd checker only check for >0 char passwd rather than > PASSWD_MIN_LEN I guess some people might have reealy bad passwds heh.

I can set up my git repo if that'd be more convenient for you too.

On Sun, Feb 17, 2008 at 5:52 PM, eliott wrote:

...
On 2/17/08, Loui wrote:

...
Here she is.

Just the 0002 patch, or the 0001 patch as well?

I hate to be a buzzkill again but I still can't log in or log out (by logging in with on a previous revision) with this patch applied even with a password greater than PASSWD_MIN_LEN. I'm not getting any errors from either except for nothing happening.

Hmm that's the only thing I could think of immediately. Alright what's the username?

Callan Barrett

12:58 p.m.

On Thu, Feb 21, 2008 at 9:56 PM, Loui wrote:

On 2/21/08, Callan Barrett wrote:

...
On Mon, Feb 18, 2008 at 7:59 AM, Loui wrote:

...
Both the 0002 patch makes the passwd checker only check for >0 char passwd rather than > PASSWD_MIN_LEN I guess some people might have reealy bad passwds heh.

I can set up my git repo if that'd be more convenient for you too.

On Sun, Feb 17, 2008 at 5:52 PM, eliott wrote:

...
On 2/17/08, Loui wrote:

...
Here she is.

Just the 0002 patch, or the 0001 patch as well?

I hate to be a buzzkill again but I still can't log in or log out (by logging in with on a previous revision) with this patch applied even with a password greater than PASSWD_MIN_LEN. I'm not getting any errors from either except for nothing happening.

Hmm that's the only thing I could think of immediately. Alright what's the username?

It seems like it can be anything, I've tried tu, dev, user and about 10 or so of the fake accounts from the dummy data. Doesn't seem like it's a problem with the user name. -- Callan 'wizzomafizzo' Barrett

Loui

1:05 p.m.

On 2/21/08, Callan Barrett wrote:

It seems like it can be anything, I've tried tu, dev, user and about 10 or so of the fake accounts from the dummy data. Doesn't seem like it's a problem with the user name.

Can you create a user and try on my test site? http://aur.louipc.dontexist.org I don't know could be something with the config, or the DB Maybe I could try with a fresh AUR install and a fresh DB and see what happens.

Callan Barrett

4:16 p.m.

On Thu, Feb 21, 2008 at 10:05 PM, Loui wrote:

On 2/21/08, Callan Barrett wrote:

...
It seems like it can be anything, I've tried tu, dev, user and about 10 or so of the fake accounts from the dummy data. Doesn't seem like it's a problem with the user name.

Can you create a user and try on my test site? http://aur.louipc.dontexist.org

I don't know could be something with the config, or the DB Maybe I could try with a fresh AUR install and a fresh DB and see what happens.

Works perfectly on your copy but still nothing on mine, this is really confusing. :/ Can anyone else try this out on a fresh AUR? -- Callan 'wizzomafizzo' Barrett

Loui

5:56 p.m.

On 2/21/08, Callan Barrett wrote:

Works perfectly on your copy but still nothing on mine, this is really confusing. :/

Can anyone else try this out on a fresh AUR? I'm going to add some log messages and make a fresh copy I'm just wondering have you tried a browser other than Safari to test?

Loui

6:01 p.m.

On 2/21/08, Callan Barrett wrote:

Works perfectly on your copy but still nothing on mine, this is really confusing. :/

Can anyone else try this out on a fresh AUR? Did you also try putting the query string directly into the URL?

index.php?user=myuser&passwd=mypasswd Also if you don't mind IRC I'd be great if you could pop in #archlinux-aur for more interactive communication.

Simo Leone

6:25 p.m.

On Fri, Feb 22, 2008 at 01:16:50AM +0900, Callan Barrett wrote:

On Thu, Feb 21, 2008 at 10:05 PM, Loui wrote:

...
On 2/21/08, Callan Barrett wrote:

...
It seems like it can be anything, I've tried tu, dev, user and about 10 or so of the fake accounts from the dummy data. Doesn't seem like it's a problem with the user name.

Can you create a user and try on my test site? http://aur.louipc.dontexist.org

I don't know could be something with the config, or the DB Maybe I could try with a fresh AUR install and a fresh DB and see what happens.

Works perfectly on your copy but still nothing on mine, this is really confusing. :/

Can anyone else try this out on a fresh AUR?

It works on my test site at aur.neotuli.net . It's not exactly a fresh install, but the patches are applied and work fine. Ooo ooo and, slightly off topic, but my test site uses some git hook magic to show what branch and version of the AUR is running, since I flip my test site between my working tree and the testing tree pretty often. -S

Loui

6:43 p.m.

On 2/21/08, Simo Leone wrote:

It works on my test site at aur.neotuli.net . It's not exactly a fresh install, but the patches are applied and work fine.

Ooo ooo and, slightly off topic, but my test site uses some git hook magic to show what branch and version of the AUR is running, since I flip my test site between my working tree and the testing tree pretty often. Oh man that is spiffy.

5919

Age (days ago)

5933

Last active (days ago)

Download

16 comments

4 participants

tags

participants (4)

Callan Barrett
eliott
Loui
Simo Leone