[aur-dev] [PATCH] Fix for 'More' and 'Less' paging breakage.
--- web/lib/pkgfuncs.inc | 7 ++----- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/web/lib/pkgfuncs.inc b/web/lib/pkgfuncs.inc index 3608012..1e92a90 100644 --- a/web/lib/pkgfuncs.inc +++ b/web/lib/pkgfuncs.inc @@ -655,7 +655,8 @@ function pkg_search_page($SID="") { # The search form # - print "<form action='/packages.php' method='get'>\n"; + print "<form action='/packages.php' method='post'>\n"; + #print "<form action='/packages.php' method='get'>\n"; print "<input type='hidden' name='O' value='".$O."'>\n"; print "<center>\n"; @@ -766,10 +767,8 @@ function pkg_search_page($SID="") { print "</tr>\n"; print "</table>\n"; print "</center>\n"; - print "</form>"; print "<br />\n"; - print "<form action='/packages.php' method='post'>\n"; # query to pull out package info # # $q = "SELECT Packages.*, IF(ISNULL(PackageID), 0, COUNT(*)) AS Votes "; @@ -881,8 +880,6 @@ function pkg_search_page($SID="") { $qnext = $q."LIMIT ".($O+$PP).", ".$PP; //next page's worth $q.= "LIMIT ".$O.", ".$PP; - - $result = db_query($q, $dbh); print "<center>\n"; -- 1.5.3.7
On Sun, Feb 17, 2008 at 12:14:41PM -0800, eliott wrote:
--- web/lib/pkgfuncs.inc | 7 ++----- 1 files changed, 2 insertions(+), 5 deletions(-)
Applied in my working branch in favor of Callan's link version. Going to POST searches hides the functionality a little but it keeps the URLS looking pretty and is easier to modify (change one hidden input as opposed to a hidden input AND remembering to change get parameters on the links). This is open to discussion, but I like this solution for the time being. We can work on something else later. -S
On Feb 19, 2008 10:17 AM, Simo Leone <simo@archlinux.org> wrote:
On Sun, Feb 17, 2008 at 12:14:41PM -0800, eliott wrote:
--- web/lib/pkgfuncs.inc | 7 ++----- 1 files changed, 2 insertions(+), 5 deletions(-)
Applied in my working branch in favor of Callan's link version. Going to POST searches hides the functionality a little but it keeps the URLS looking pretty and is easier to modify (change one hidden input as opposed to a hidden input AND remembering to change get parameters on the links).
This is open to discussion, but I like this solution for the time being. We can work on something else later.
-S
I hate this so much and your weird fetish for pretty urls! I guess this is good for now, I might see what can be done otherwise, though. I think I was throwing around the idea of some sort of url generation function to use for this. Does anyone else have a different idea? -- Callan 'wizzomafizzo' Barrett
participants (3)
-
Callan Barrett
-
eliott
-
Simo Leone