[aur-dev] [PATCH] Add support for TU ninja edits
Trusted Users now have the ability to overwrite packages without
changing ownership. This allows for adding small fixes to PKGBUILDs
without disowning the package.
Implements FS#32807.
Signed-off-by: Lukas Fleischer
On 31.05.2014 12:04, Lukas Fleischer wrote:
Trusted Users now have the ability to overwrite packages without changing ownership. This allows for adding small fixes to PKGBUILDs without disowning the package.
This sounds like it is bound to cause regressions. I keep my aur packages in a git repo and if updates come I do my work there. Ninja edits will only really be useful if the maintainer isn't responsive so chances are they won't even notice the edit. Next time they bump the package they probably won't add the ninja edit so it will be lost.
On 31/05/14 09:18 AM, Florian Pritz wrote:
On 31.05.2014 12:04, Lukas Fleischer wrote:
Trusted Users now have the ability to overwrite packages without changing ownership. This allows for adding small fixes to PKGBUILDs without disowning the package.
This sounds like it is bound to cause regressions.
I keep my aur packages in a git repo and if updates come I do my work there. Ninja edits will only really be useful if the maintainer isn't responsive so chances are they won't even notice the edit. Next time they bump the package they probably won't add the ninja edit so it will be lost.
It can send a notification email with the diff if it doesn't already do that.
On 31.05.2014 15:24, Daniel Micay wrote:
On 31/05/14 09:18 AM, Florian Pritz wrote:
I keep my aur packages in a git repo and if updates come I do my work there. Ninja edits will only really be useful if the maintainer isn't responsive so chances are they won't even notice the edit. Next time they bump the package they probably won't add the ninja edit so it will be lost.
It can send a notification email with the diff if it doesn't already do that.
You think people are going to read that if they don't read other messages? Or is this features supposed to be used without first trying to get the maintainer to fix the package? (e.g. send them a mail)
On 31/05/14 09:34 AM, Florian Pritz wrote:
On 31.05.2014 15:24, Daniel Micay wrote:
On 31/05/14 09:18 AM, Florian Pritz wrote:
I keep my aur packages in a git repo and if updates come I do my work there. Ninja edits will only really be useful if the maintainer isn't responsive so chances are they won't even notice the edit. Next time they bump the package they probably won't add the ninja edit so it will be lost.
It can send a notification email with the diff if it doesn't already do that.
You think people are going to read that if they don't read other messages? Or is this features supposed to be used without first trying to get the maintainer to fix the package? (e.g. send them a mail)
One use case would be updating a package before the maintainer gets around to it. Security vulnerabilities make prompt updates very important, and a maintainer lagging a bit behind now and then isn't enough of a reason to disown the package.
On Sat, 31 May 2014 at 15:18:20, Florian Pritz wrote:
On 31.05.2014 12:04, Lukas Fleischer wrote:
Trusted Users now have the ability to overwrite packages without changing ownership. This allows for adding small fixes to PKGBUILDs without disowning the package.
This sounds like it is bound to cause regressions.
I keep my aur packages in a git repo and if updates come I do my work there. Ninja edits will only really be useful if the maintainer isn't responsive so chances are they won't even notice the edit. Next time they bump the package they probably won't add the ninja edit so it will be lost.
Agreed, I will discard this patch. The feature can still be added after switching to Git repositories. Users will then notice ninja edits because Git refuses to do non-fast-forwards by default (and non-fast-forwards will be disabled on the server anyway).
participants (3)
-
Daniel Micay
-
Florian Pritz
-
Lukas Fleischer