[aur-dev] [PATCH] tu_details.php: Avoid division by zero
Do not divide by zero if the number of active TUs is unknown. Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de> --- web/template/tu_details.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/web/template/tu_details.php b/web/template/tu_details.php index c09e30c..667956b 100644 --- a/web/template/tu_details.php +++ b/web/template/tu_details.php @@ -6,7 +6,9 @@ $active_tus = $row["ActiveTUs"]; $quorum = $row["Quorum"]; $total = $yes + $no + $abstain; -$participation = $total / $active_tus; +if ($active_tus > 0) { + $participation = $total / $active_tus; +} if ($yes > $active_tus / 2) { $vote_accepted = true; -- 1.8.4.rc3.500.gc3113b0
On 26.08.2013 17:56, Lukas Fleischer wrote:
Do not divide by zero if the number of active TUs is unknown.
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de> --- web/template/tu_details.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/web/template/tu_details.php b/web/template/tu_details.php index c09e30c..667956b 100644 --- a/web/template/tu_details.php +++ b/web/template/tu_details.php @@ -6,7 +6,9 @@ $active_tus = $row["ActiveTUs"]; $quorum = $row["Quorum"];
$total = $yes + $no + $abstain; -$participation = $total / $active_tus; +if ($active_tus > 0) { + $participation = $total / $active_tus; +}
You should probably set a default value of 0. I don't see those patches on projects.al.org (master branch) yet so I'm not sure if a default might be set earlier.
if ($yes > $active_tus / 2) { $vote_accepted = true;
Do not divide by zero if the number of active TUs is unknown. Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de> --- web/template/tu_details.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/web/template/tu_details.php b/web/template/tu_details.php index c09e30c..c546eb7 100644 --- a/web/template/tu_details.php +++ b/web/template/tu_details.php @@ -6,7 +6,11 @@ $active_tus = $row["ActiveTUs"]; $quorum = $row["Quorum"]; $total = $yes + $no + $abstain; -$participation = $total / $active_tus; +if ($active_tus > 0) { + $participation = $total / $active_tus; +} else { + $participation = 0; +} if ($yes > $active_tus / 2) { $vote_accepted = true; -- 1.8.4.rc3.500.gc3113b0
participants (2)
-
Florian Pritz
-
Lukas Fleischer