[aur-dev] [PATCH 1/6] pkg_details.php: Add missing XHTML close tags
Signed-off-by: canyonknight <canyonknight@gmail.com> --- web/template/pkg_details.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/web/template/pkg_details.php b/web/template/pkg_details.php index b286664..74f9257 100644 --- a/web/template/pkg_details.php +++ b/web/template/pkg_details.php @@ -117,6 +117,7 @@ if ($SID && ($uid == $row["MaintainerUID"] || <a href="<?= get_uri('/packages/'); ?>?C=<?= $row['CategoryID'] ?>"><?= $row['Category'] ?></a> <?php endif; ?> </td> + </tr> <tr> <th><?= __('License') . ': ' ?></th> <td><?= htmlspecialchars($license) ?></td> @@ -138,6 +139,7 @@ if ($row["SubmitterUID"]): <?php else: ?> <td>None</td> <?php endif; ?> + </tr> <tr> <th><?= __('Maintainer') .': ' ?></th> <?php @@ -160,9 +162,9 @@ if ($row["MaintainerUID"]): <th><?= __('Votes') . ': ' ?></th> <?php if ($atype == "Developer" || $atype == "Trusted User"): ?> <?php if ($USE_VIRTUAL_URLS): ?> - <td><a href="<?= get_pkg_uri($row['Name']); ?>voters/"><?= $votes ?></a> + <td><a href="<?= get_pkg_uri($row['Name']); ?>voters/"><?= $votes ?></a></td> <?php else: ?> - <td><a href="<?= get_uri('/voters/'); ?>?ID=<?= $pkgid ?>"><?= $votes ?></a> + <td><a href="<?= get_uri('/voters/'); ?>?ID=<?= $pkgid ?>"><?= $votes ?></a></td> <?php endif; ?> <?php else: ?> <td><?= $votes ?></td> -- 1.7.12.3
Signed-off-by: canyonknight <canyonknight@gmail.com> --- web/template/pkg_comment_form.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/template/pkg_comment_form.php b/web/template/pkg_comment_form.php index 903173d..da871ec 100644 --- a/web/template/pkg_comment_form.php +++ b/web/template/pkg_comment_form.php @@ -1,6 +1,6 @@ <div id="generic-form" class="box"> <h2><?= __("Add Comment"); ?></h2> - <form call="general-form" action="<?= $_SERVER['REQUEST_URI'] ?>" method="post"> + <form action="<?= $_SERVER['REQUEST_URI'] ?>" method="post"> <fieldset> <?php if (isset($_REQUEST['comment']) && check_token()) { -- 1.7.12.3
Signed-off-by: canyonknight <canyonknight@gmail.com> --- web/template/tu_list.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/template/tu_list.php b/web/template/tu_list.php index 566cb17..f80d2f5 100644 --- a/web/template/tu_list.php +++ b/web/template/tu_list.php @@ -25,7 +25,7 @@ ?> <tr class="<?= $c ?>"> <td><?php $row["Agenda"] = htmlspecialchars(substr($row["Agenda"], 0, $prev_Len)); ?> - <a href="<?= get_uri('/tu/'); ?>?id=<?= $row['ID'] ?>"><?= $row["Agenda"] ?></a></span></span> + <a href="<?= get_uri('/tu/'); ?>?id=<?= $row['ID'] ?>"><?= $row["Agenda"] ?></a> </td> <td><?= gmdate("Y-m-d", $row["Submitted"]) ?></td> <td><?= gmdate("Y-m-d", $row["End"]) ?></td> -- 1.7.12.3
* Add </option> close tags * Add VI delimiter to selected option * Add quotes to language codes Signed-off-by: canyonknight <canyonknight@gmail.com> --- web/template/account_edit_form.php | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/web/template/account_edit_form.php b/web/template/account_edit_form.php index 308913d..6c39d53 100644 --- a/web/template/account_edit_form.php +++ b/web/template/account_edit_form.php @@ -23,23 +23,25 @@ <label for="id_type"><?= __("Account Type") ?>:</label> <select name="T" id="id_type"> <?php if ($T == "User"): ?> - <option value="1" selected><?= __("Normal user") ?> + <option value="1" selected="selected"><?= __("Normal user") ?></option> <?php else: ?> - <option value="1"><?= __("Normal user") ?> + <option value="1"><?= __("Normal user") ?></option> <?php endif; ?> <?php if ($T == "Trusted User"): ?> - <option value="2" selected><?= __("Trusted user") ?> + <option value="2" selected="selected"><?= __("Trusted user") ?></option> <?php else: ?> - <option value="2"><?= __("Trusted user") ?> + <option value="2"><?= __("Trusted user") ?></option> <?php endif; ?> <?php # Only developers can make another account a developer if ($UTYPE == "Developer"): ?> <option value="3" - <?php $T == "Developer" ? print " selected>" : print ">"; + <?php $T == "Developer" ? print " selected=\"selected\">" : print ">"; print __("Developer")."\n"; ?> + </option> <?php endif; ?> + </select> </p> @@ -92,9 +94,9 @@ reset($SUPPORTED_LANGS); while (list($code, $lang) = each($SUPPORTED_LANGS)) { if ($L == $code) { - print "<option value=".$code." selected> ".$lang."\n"; + print "<option value=\"".$code."\" selected=\"selected\"> ".$lang."</option>"."\n"; } else { - print "<option value=".$code."> ".$lang."\n"; + print "<option value=\"".$code."\"> ".$lang."</option>"."\n"; } } ?> -- 1.7.12.3
Replace incorrect </td> tags with </th> tags Signed-off-by: canyonknight <canyonknight@gmail.com> --- web/template/account_details.php | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/web/template/account_details.php b/web/template/account_details.php index aa18f5b..fdebfb3 100644 --- a/web/template/account_details.php +++ b/web/template/account_details.php @@ -4,11 +4,11 @@ <h3><?= htmlspecialchars($row["Username"], ENT_QUOTES) ?></h3> <table class="bio"> <tr> - <th><?= __("Username") . ":" ?></td> + <th><?= __("Username") . ":" ?></th> <td><?= $row["Username"] ?></td> </tr> <tr> - <th><?= __("Account Type") . ":" ?></td> + <th><?= __("Account Type") . ":" ?></th> <td> <?php if ($row["AccountType"] == "User") { @@ -22,23 +22,23 @@ </td> </tr> <tr> - <th><?= __("Email Address") . ":" ?></td> + <th><?= __("Email Address") . ":" ?></th> <td><a href="mailto:<?= htmlspecialchars($row["Email"], ENT_QUOTES) ?>"><?= htmlspecialchars($row["Email"], ENT_QUOTES) ?></a></td> </tr> <tr> - <th><?= __("Real Name") . ":" ?></td> + <th><?= __("Real Name") . ":" ?></th> <td><?= htmlspecialchars($row["RealName"], ENT_QUOTES) ?></td> </tr> <tr> - <th><?= __("IRC Nick") . ":" ?></td> + <th><?= __("IRC Nick") . ":" ?></th> <td><?= htmlspecialchars($row["IRCNick"], ENT_QUOTES) ?></td> </tr> <tr> - <th><?= __("PGP Key Fingerprint") . ":" ?></td> + <th><?= __("PGP Key Fingerprint") . ":" ?></th> <td><?= html_format_pgp_fingerprint($row["PGPKey"]) ?></td> </tr> <tr> - <th><?= __("Last Voted") . ":" ?></td> + <th><?= __("Last Voted") . ":" ?></th> <td> <?= $row["LastVoted"] ? date("Y-m-d", $row["LastVoted"]) : __("Never"); ?> </td> -- 1.7.12.3
* Add missing <p> tag * Move <h4> outside of a <p> tag * Rename an id to avoid a conflict with an already existing id Signed-off-by: canyonknight <canyonknight@gmail.com> --- web/html/home.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/web/html/home.php b/web/html/home.php index f5a9afe..4d5b699 100644 --- a/web/html/home.php +++ b/web/html/home.php @@ -43,8 +43,8 @@ $dbh = db_connect(); <?= __('Remember to vote for your favourite packages!'); ?> <?= __('Some packages may be provided as binaries in [community].'); ?> </p> - <p> <h4><?= __('Discussion') ?></h4> + <p> <?php echo __( 'General discussion regarding the Arch User Repository (AUR) and Trusted User structure takes place on %saur-general%s. This list can be used for package orphan requests, merge requests, and deletion requests. For discussion relating to the development of the AUR, use the %saur-dev%s mailing list.', @@ -56,6 +56,7 @@ $dbh = db_connect(); ?> </p> <h4><?= __('Bug Reporting') ?></h4> + <p> <?php echo __( 'If you find a bug in the AUR, please fill out a bug report on our %sbug tracker%s. Use the tracker to report bugs in the AUR %sonly%s. To report packaging bugs contact the package maintainer or leave a comment on the appropriate package page.', @@ -107,7 +108,7 @@ $dbh = db_connect(); </tr> </table> </div> - <div id="pkg-updates" class="widget box"> + <div id="pkg-stats" class="widget box"> <table> <tr> <td class="pkg-name"> -- 1.7.12.3
On Thu, Oct 18, 2012 at 05:12:24PM -0400, canyonknight wrote:
Signed-off-by: canyonknight <canyonknight@gmail.com> --- web/template/pkg_details.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
[...]
Merged into master -- thanks!
participants (2)
-
canyonknight
-
Lukas Fleischer