[aur-dev] [PATCH] Add comment and submitted to notification emails for comments
Signed-off-by: Callan Barrett <wizzomafizzo@gmail.com> --- web/html/pkgedit.php | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/web/html/pkgedit.php b/web/html/pkgedit.php index 610113a..974f14b 100644 --- a/web/html/pkgedit.php +++ b/web/html/pkgedit.php @@ -91,7 +91,7 @@ if ($_REQUEST["add_Comment"]) { #TODO: native language emails for users, based on their prefs # Simply making these strings translatable won't work, users would be # getting emails in the language that the user who posted the comment was in - $body = "A comment has been added to ".$row['Name'].", you may view it at:\nhttp://aur.archlinux.org/packages.php?ID=".$_REQUEST["ID"]."\n\n\n---\nYou received this e-mail because you chose to recieve notifications of new comments on this package, if you no longer wish to recieve notifications about this package, please go the the above package page and click the UnNotify button."; + $body = "A comment has been added to ".$row['Name']." by " . username_from_sid($_COOKIE["AURSID"]) . ", you may view it at:\nhttp://aur.archlinux.org/packages.php?ID=".$_REQUEST["ID"]."\n\n\"" . $_POST['comment'] . "\"\n\n---\nYou received this e-mail because you chose to receive notifications of new comments on this package, if you no longer wish to recieve notifications about this package, please go the the above package page and click the UnNotify button."; $body = wordwrap($body, 70); $bcc = implode(', ', $bcc); $headers = "Bcc: $bcc\nReply-to: nobody@archlinux.org\nFrom:aur-notify@archlinux.org\nX-Mailer: PHP\nX-MimeOLE: Produced By AUR\n"; -- 1.6.0.2
On Wed, Oct 08, 2008 at 04:42:47AM +0800, Callan Barrett wrote:
Signed-off-by: Callan Barrett <wizzomafizzo@gmail.com> --- web/html/pkgedit.php | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/web/html/pkgedit.php b/web/html/pkgedit.php index 610113a..974f14b 100644 --- a/web/html/pkgedit.php +++ b/web/html/pkgedit.php @@ -91,7 +91,7 @@ if ($_REQUEST["add_Comment"]) { #TODO: native language emails for users, based on their prefs # Simply making these strings translatable won't work, users would be # getting emails in the language that the user who posted the comment was in - $body = "A comment has been added to ".$row['Name'].", you may view it at:\nhttp://aur.archlinux.org/packages.php?ID=".$_REQUEST["ID"]."\n\n\n---\nYou received this e-mail because you chose to recieve notifications of new comments on this package, if you no longer wish to recieve notifications about this package, please go the the above package page and click the UnNotify button."; + $body = "A comment has been added to ".$row['Name']." by " . username_from_sid($_COOKIE["AURSID"]) . ", you may view it at:\nhttp://aur.archlinux.org/packages.php?ID=".$_REQUEST["ID"]."\n\n\"" . $_POST['comment'] . "\"\n\n---\nYou received this e-mail because you chose to receive notifications of new comments on this package, if you no longer wish to recieve notifications about this package, please go the the above package page and click the UnNotify button."; $body = wordwrap($body, 70); $bcc = implode(', ', $bcc); $headers = "Bcc: $bcc\nReply-to: nobody@archlinux.org\nFrom:aur-notify@archlinux.org\nX-Mailer: PHP\nX-MimeOLE: Produced By AUR\n"; -- 1.6.0.2
I think it might be worth changing the whole wording of the notice and maybe put the commenter's nick in the email as well. Something like: louipc has made a comment on tomatoes: This game rocks so hard yo. You can also view the comment here: http:///aur.archlinux.org/packages.php?ID=7090 blah blah blah
I think it might be worth changing the whole wording of the notice and maybe put the commenter's nick in the email as well. Something like:
louipc has made a comment on tomatoes: This game rocks so hard yo.
You can also view the comment here: http:///aur.archlinux.org/packages.php?ID=7090
blah blah blah
Commenter's nick is in the patch now but rewriting it sounds like a good idea. -- Callan Barrett
On Thu, Oct 09, 2008 at 10:30:41AM +0800, Callan Barrett wrote:
I think it might be worth changing the whole wording of the notice and maybe put the commenter's nick in the email as well. Something like:
louipc has made a comment on tomatoes: This game rocks so hard yo.
You can also view the comment here: http:///aur.archlinux.org/packages.php?ID=7090
blah blah blah
Commenter's nick is in the patch now but rewriting it sounds like a good idea.
Oh shucks it is indeed in there.
On Thu, Oct 09, 2008 at 10:30:41AM +0800, Callan Barrett wrote:
I think it might be worth changing the whole wording of the notice and maybe put the commenter's nick in the email as well. Something like:
louipc has made a comment on tomatoes: This game rocks so hard yo.
You can also view the comment here: http:///aur.archlinux.org/packages.php?ID=7090
blah blah blah
Commenter's nick is in the patch now but rewriting it sounds like a good idea.
Alrighty. Pushed to testing.
participants (2)
-
Callan Barrett
-
Loui