[aur-dev] [PATCH] FS#45834 - Remove trailing slash from git https://link.git/ - Aur-dev

newer
[aur-dev] [PATCH] Update link to...

[aur-dev] [PATCH] FS#45834 - Remove trailing slash from git https://link.git/

Stefan Auditor

12 Aug 2015 12 Aug '15

11:20 a.m.

Signed-off-by: Stefan Auditor --- conf/config.proto | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/conf/config.proto b/conf/config.proto index 2fbc27a..b2198e5 100644 --- a/conf/config.proto +++ b/conf/config.proto @@ -18,8 +18,8 @@ persistent_cookie_timeout = 2592000 max_filesize_uncompressed = 8388608 disable_http_login = 1 aur_location = https://aur.archlinux.org -git_clone_uri_anon = https://aur.archlinux.org/%s.git/ -git_clone_uri_priv = ssh+git://aur@aur.archlinux.org/%s.git/ +git_clone_uri_anon = https://aur.archlinux.org/%s.git +git_clone_uri_priv = ssh+git://aur@aur.archlinux.org/%s.git max_rpc_results = 5000 aur_request_ml = aur-requests@archlinux.org request_idle_time = 1209600 -- 2.5.0

Show replies by date

Marcel Korpel

12 Aug 12 Aug

4:19 p.m.

New subject: [aur-dev] [PATCH] FS#45834 - Remove trailing slash from git https://link.git/

* Stefan Auditor (Wed, 12 Aug 2015 13:20:37 +0200):

...

Signed-off-by: Stefan Auditor

Next time, please don't add FS# in the subject, I think they belong in the body of the message, including a summary of the bug you fixed, so we don't have to look up an old bug report to see why this had to be changed. Like: Remove trailing slash from Git link Fixes FS#45834. The trailing slash made Git create directories with a .git suffix since Git 2.5.0.

Marcel Korpel

4:42 p.m.

New subject: [aur-dev] [PATCH] FS#45834 - Remove trailing slash from git https://link.git/

* Marcel Korpel (Wed, 12 Aug 2015 18:19:22 +0200):

...

[…] Like:

Remove trailing slash from Git link

Fixes FS#45834. The trailing slash made Git create directories with a .git suffix since Git 2.5.0.

Scratch that. Messages should be in imperative mood. See http://addamhardy.com/blog/2013/06/05/good-commit-messages-and-enforcing-the...

Loui Chang

13 Aug 13 Aug

3:45 a.m.

New subject: [aur-dev] [PATCH] FS#45834 - Remove trailing slash from git https://link.git/

On Wed 12 Aug 2015 18:19 +0200, Marcel Korpel wrote:

...

* Stefan Auditor (Wed, 12 Aug 2015 13:20:37 +0200):

...
Signed-off-by: Stefan Auditor

Next time, please don't add FS# in the subject, I think they belong in the body of the message, including a summary of the bug you fixed, so we don't have to look up an old bug report to see why this had to be changed. Like:

Remove trailing slash from Git link

Fixes FS#45834. The trailing slash made Git create directories with a .git suffix since Git 2.5.0.

I think the FS# is OK as long as the subject is descriptive. I only get annoyed if the subject is only "Fix FS#1234" OR "Fix Bug".

Lukas Fleischer

14 Aug 14 Aug

4:53 a.m.

New subject: [aur-dev] [PATCH] FS#45834 - Remove trailing slash from git https://link.git/

On Wed, 12 Aug 2015 at 13:20:37, Stefan Auditor wrote:

...

Signed-off-by: Stefan Auditor --- conf/config.proto | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/conf/config.proto b/conf/config.proto index 2fbc27a..b2198e5 100644 --- a/conf/config.proto +++ b/conf/config.proto @@ -18,8 +18,8 @@ persistent_cookie_timeout = 2592000 max_filesize_uncompressed = 8388608 disable_http_login = 1 aur_location = https://aur.archlinux.org -git_clone_uri_anon = https://aur.archlinux.org/%s.git/ -git_clone_uri_priv = ssh+git://aur@aur.archlinux.org/%s.git/ +git_clone_uri_anon = https://aur.archlinux.org/%s.git +git_clone_uri_priv = ssh+git://aur@aur.archlinux.org/%s.git [...]

As I already mentioned in the bug report, this is a regression in Git that will be fixed in the next Git maintenance release...

Stefan Auditor

7:58 a.m.

New subject: [aur-dev] [PATCH] FS#45834 - Remove trailing slash from git https://link.git/

On 14.08.2015 06:53, Lukas Fleischer wrote:

...

...
Signed-off-by: Stefan Auditor --- conf/config.proto | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/conf/config.proto b/conf/config.proto index 2fbc27a..b2198e5 100644 --- a/conf/config.proto +++ b/conf/config.proto @@ -18,8 +18,8 @@ persistent_cookie_timeout = 2592000 max_filesize_uncompressed = 8388608 disable_http_login = 1 aur_location = https://aur.archlinux.org -git_clone_uri_anon = https://aur.archlinux.org/%s.git/ -git_clone_uri_priv = ssh+git://aur@aur.archlinux.org/%s.git/ +git_clone_uri_anon = https://aur.archlinux.org/%s.git +git_clone_uri_priv = ssh+git://aur@aur.archlinux.org/%s.git [...] As I already mentioned in the bug report, this is a regression in Git

On Wed, 12 Aug 2015 at 13:20:37, Stefan Auditor wrote: that will be fixed in the next Git maintenance release...

As I already asked in the bug report:

...

Any reason not to remove the trailing slash? In my eyes it looks odd to have one after a file extension. All git hosting services I'm aware of do it that way. The most famos examples being

Github https://github.com/owner/repository.git git@github.com:owner/repository.git Gitlab https://example.org/group/repository.git git@example.org:group/repository.git regards, Stefan -- erdfisch Stefan Auditor, Frank Holldorff & Fabian Lorenzen GbR Internet: http://erdfisch.de E-Mail : stefan.auditor@erdfisch.de Telefon : +49 6221 751 560 0 Fax : +49 6221 751 560 99 Hans-Bunte-Str. 6 69123 Heidelberg

Johannes Löthberg

9:47 a.m.

New subject: [aur-dev] [PATCH] FS#45834 - Remove trailing slash from git https://link.git/

On 14/08, Stefan Auditor wrote:

...

On 14.08.2015 06:53, Lukas Fleischer wrote:

...
...
Signed-off-by: Stefan Auditor --- conf/config.proto | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/conf/config.proto b/conf/config.proto index 2fbc27a..b2198e5 100644 --- a/conf/config.proto +++ b/conf/config.proto @@ -18,8 +18,8 @@ persistent_cookie_timeout = 2592000 max_filesize_uncompressed = 8388608 disable_http_login = 1 aur_location = https://aur.archlinux.org -git_clone_uri_anon = https://aur.archlinux.org/%s.git/ -git_clone_uri_priv = ssh+git://aur@aur.archlinux.org/%s.git/ +git_clone_uri_anon = https://aur.archlinux.org/%s.git +git_clone_uri_priv = ssh+git://aur@aur.archlinux.org/%s.git [...] As I already mentioned in the bug report, this is a regression in Git

On Wed, 12 Aug 2015 at 13:20:37, Stefan Auditor wrote: that will be fixed in the next Git maintenance release...

As I already asked in the bug report:

...
Any reason not to remove the trailing slash? In my eyes it looks odd to have one after a file extension.

It's not a file extension, it's just the suffix of a directory. -- Sincerely, Johannes Löthberg PGP Key ID: 0x50FB9B273A9D0BB5 https://theos.kyriasis.com/~kyrias/

Loui Chang

11 p.m.

New subject: [aur-dev] [PATCH] FS#45834 - Remove trailing slash from git https://link.git/

On Fri 14 Aug 2015 11:47 +0200, Johannes Löthberg wrote:

...

On 14/08, Stefan Auditor wrote:

...
...
Any reason not to remove the trailing slash? In my eyes it looks odd to have one after a file extension.

It's not a file extension, it's just the suffix of a directory.

huh

Stefan Auditor

16 Aug 16 Aug

12:18 p.m.

New subject: [aur-dev] [PATCH] Remove trailing slash from git urls

Circumvents the temporary regression in git that clones a repository as foo-git.git instead of foo-git and matches the format used by other commonly used git hosting providers. Fixes FS#45834 Signed-off-by: Stefan Auditor --- conf/config.proto | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/conf/config.proto b/conf/config.proto index 2fbc27a..b2198e5 100644 --- a/conf/config.proto +++ b/conf/config.proto @@ -18,8 +18,8 @@ persistent_cookie_timeout = 2592000 max_filesize_uncompressed = 8388608 disable_http_login = 1 aur_location = https://aur.archlinux.org -git_clone_uri_anon = https://aur.archlinux.org/%s.git/ -git_clone_uri_priv = ssh+git://aur@aur.archlinux.org/%s.git/ +git_clone_uri_anon = https://aur.archlinux.org/%s.git +git_clone_uri_priv = ssh+git://aur@aur.archlinux.org/%s.git max_rpc_results = 5000 aur_request_ml = aur-requests@archlinux.org request_idle_time = 1209600 -- 2.5.0

Lukas Fleischer

7:38 p.m.

New subject: [aur-dev] [PATCH] Remove trailing slash from git urls

On Sun, 16 Aug 2015 at 14:18:42, Stefan Auditor wrote:

...

Circumvents the temporary regression in git that clones a repository as foo-git.git instead of foo-git and matches the format used by other commonly used git hosting providers.

Fixes FS#45834

Signed-off-by: Stefan Auditor --- conf/config.proto | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) [...]

Applied, thanks!

3185

Age (days ago)

3189

Last active (days ago)

List overview

Download

9 comments

5 participants

participants (5)

Johannes Löthberg
Loui Chang
Lukas Fleischer
Marcel Korpel
Stefan Auditor