On Sat, 27 Jun 2015 at 16:54:04, Lukas Fleischer wrote:

On Sat, 27 Jun 2015 at 16:26:07, Johannes Löthberg wrote:

...

When no changes has been made to the account there's no need for a message, and it is no longer applicable since the setting of SSH keys is done in a separate function now.

Reported-by: Alexis Chotard Signed-off-by: Johannes Löthberg --- web/lib/acctfuncs.inc.php | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) [...]

Applied, thanks!

Just noticed that this doesn't seem to work. PDO::exec() returns false if an error occurs and the number of modified rows otherwise. So this results in an empty page (with just a heading) when no changes are made. Maybe we should just replace "!$result" with "$result === false" instead? Regards, Lukas

On Sat, 27 Jun 2015 at 17:48:39, Johannes Löthberg wrote:

This commit changes the messages printed when changing the accound details so that it only prints that no changes were made if either the account change SQL query or the account_set_ssh_keys call failed.

Reported-by: Alexis Chotard Signed-off-by: Johannes Löthberg --- This should work properly. (And hopefully Lukas won't be mad at me for being so slow-minded today.) [...]

Not at all! Thanks for all your work on aurweb! I replaced the previous patch on pu with this one.