[aur-dev] [PATCH] Make possible to post patches in comments
Altrough maybe it's not the world's better implementation, this makes possibe to post patches in comments, as you can see here: http://imgur.com/kY0EF Regards.
On 29/09/10 16:13, Manuel Tortosa wrote:
Altrough maybe it's not the world's better implementation, this makes possibe to post patches in comments, as you can see here:
Regards.
just an idea, but wouldn't it be better to allow something like a `[code][/code]` tag? benefits are that you can add style to it like limiting the height, specify proper font etc. something like http://konnichi.com/tets/pre.php code at http://konnichi.com/tets/pre.php.txt
On Wednesday 29 September 2010 17:57:37 Nathan Wayde wrote:
On 29/09/10 16:13, Manuel Tortosa wrote:
Altrough maybe it's not the world's better implementation, this makes possibe to post patches in comments, as you can see here:
Regards.
just an idea, but wouldn't it be better to allow something like a `[code][/code]` tag? benefits are that you can add style to it like limiting the height, specify proper font etc.
something like http://konnichi.com/tets/pre.php code at http://konnichi.com/tets/pre.php.txt
Indeed, in this case maybe must be the same user who adds the tags just for the needed parts, like in any forum app. Will think some, at least for ccr. It's nice to see this mailing list so active, i'm not so handy with php/html, the new chakra webpage is my first attempt to do something so i know maybe my patches are not usefull for you... your comments and feedback are quite usefull for me. Best Regards to everybody, keep the good job in Arch :)
On Wed, Sep 29, 2010 at 05:13:18PM +0200, Manuel Tortosa wrote:
+<?php echo str_replace(" ", " ", nl2br(htmlspecialchars($carr['Comments']))) ?>
You should definitely use "<pre></pre>" tags here instead of replacing every occurence of a whitespace (" ") by its HTML entity (" ").
On Wednesday 29 September 2010 19:55:15 Lukas Fleischer wrote:
On Wed, Sep 29, 2010 at 05:13:18PM +0200, Manuel Tortosa wrote:
+<?php echo str_replace(" ", " ", nl2br(htmlspecialchars($carr['Comments']))) ?>
You should definitely use "<pre></pre>" tags here instead of replacing every occurence of a whitespace (" ") by its HTML entity (" ").
Finally i used instead a set of parsing functions from FluxBB, now CCR can show Smilies, patches, and clickable links, and [code] [img] and [b] [i] will follow soon. As example: http://www.chakra-project.org/ccr/packages.php?ID=11 i'll upload the changes to git asap, today gitorious doesn't work :/
participants (3)
-
Lukas Fleischer
-
Manuel Tortosa
-
Nathan Wayde