On 29 June 2013 15:19, Johannes Löthberg <demizide@gmail.com> wrote:
Any reason for still having the _git* variables? They make the PKGBUILD a bit harder to read and seem sort of unnecessary since they're only used once.
On Sat, Jun 29, 2013 at 11:45 AM, Keshav Padram < the.ridikulus.rat@gmail.com
wrote:
On 29 June 2013 15:09, Maxime GAUDUIN <alucryd@gmail.com> wrote:
On Sat, Jun 29, 2013 at 11:18 AM, Keshav Padram < the.ridikulus.rat@gmail.com
wrote:
On 28 June 2013 21:10, Maxime GAUDUIN <alucryd@gmail.com> wrote:
On Fri, Jun 28, 2013 at 5:09 PM, Keshav Padram <the.ridikulus.rat@gmail.com>wrote:
Hi, Please merge syslinux-bios-elflink-git [1] and syslinux-efi-git [2] into syslinux-firmware-git [3]. Thanks in advance.
[1]: https://aur.archlinux.org/packages/syslinux-bios-elflink-git/ [2]: https://aur.archlinux.org/packages/syslinux-efi-git/ [3]: https://aur.archlinux.org/packages/syslinux-firmware-git/
Best Regards.
Keshav Padram
Merged.
Thanks
What is the difference between the firmware and master branches? Unless differences are huge, seems to me that the syslinux-git package with an optional branch tag (using the new source array for vcs packages) would suffice.
The differences are huge. The master branch contains code for syslinux 4.XX (which is in maintenance mode). The elflink branch contains code for syslinux 5.XX which changed the internal structure of syslinux to use ELF modules in preparation for EFI support in 6.XX . The firmware branch contains syslinux 6.XX code which introduces EFI support and contains is written on top of elflink branch. The new syslinux-firmware-git pkg now contains both bios and efi modules built from firmware branch (as the name implies), even for bios modules as the code form elfink branch is anyway part of firmware branch.
I see, thx for the explanation! You might want to update your PKGBUILD for pacman 4.1 then, see here<https://wiki.archlinux.org/index.php/VCS_PKGBUILD_Guidelines>for a good overview on how to do it.
The PKGBUILD ( https://aur.archlinux.org/packages/sy/syslinux-firmware-git/PKGBUILD ) already uses makepkg 4.1 features wrt git checkout in sources=() array and pkgver() function.
Those _git* variables are from pre-makepkg 4.1 PKGBUILD. I just made a common source=() array for all my -git PKGBUILDs and was lazy to update the array for individual PKGBUILDs source=("${_gitname}::git+${_gitroot}#branch=${_gitbranch}") Best Regards. Keshav Padram