Le 24/01/2023 à 13:33, Polarian a écrit :
Hello,
While this is not mandatory, here are 2 suggestions I could eventually make: - Declare a custom `_pkgname=eureka` variable (since it's the real name of the software) and make use of that variable instead of repeating "eureka" multiple times in the PKGBUILD
You guys are laughable, Robin says to use a variable, and T.J says that using the variable is redundant and recommended me to remove it, so which should I do? You all have different ideas on what a PKGBUILD should look like and I am unsure which way I should do it :/ As I said, this is mostly a "style" choice, it is up to the maintainer to adopt the use of such variables or not.
Some prefer using them /(like I do, because I tend to find that it makes the PKGBUILD more "portable" as you can keep the same structure for another package by just modifying the top variables' value)/ and some don't /(as it could be redundant and it eventually makes some information more difficult to read at first glance) /but, as far as I know, there's no real stated rule about this (please, someone correct me if I'm wrong about that). So once again, I think this is up to you. If you also think that using such variables is redundant, you don't have to use them ;) /By the way, I wasn't aware of T.J.'s recommandations since they don't seem to appear in this discussion thread?/
- There are still some useless usages of the `$srcdir` variable in the `install` commands inside the `package ()` function (since PKGBUILDs' functions implicitly and automatically "cd" into "srcdir" by default)
Whoops, forgot to remove them, let me try removing and building it and then committing it if they aren't needed. Thanks for the suggestion.
As I said, those points are not mandatory. That's mostly style changes, it's up to you to decide whether you want to implement them or not I guess. Other than that, I think the PKGBUILD looks good that way.
Thanks for the help Robin, highly appreciated!
You're welcome :) -- Cordialement, Robin Candau