On Tue, Oct 14, 2008 at 12:15 PM, Sergej Pupykin <pupykin.s@gmail.com> wrote:
List of packages: http://aur.archlinux.org/packages.php?O=0&L=0&C=0&K=xhemi&SeB=m&SB=n&SO=a
On Tue, Oct 14, 2008 at 2:12 PM, Sergej Pupykin <pupykin.s@gmail.com> wrote:
Hi,
I want to sponsor Edward Tjörnhammar(xhemi). His packages have small issues such as backup lines or missing ' || return 1', but they are good.
So I ask to start discussion.
I recently contributed a package 'inn' which I intend to continue working on. The package was added to [community] so I will continue with as inn-orig in AUR, user xhemi. If I were to become TU I believe that I can help to improve any number of packages in need of love but would continue with 'inn'. My sponsor is Sergej Pupykin.
Sorry to say, but I found quite a few things from a very quick look: - errors in licenses. This is an array and you need to install custom licenses in /usr/share/licenses/$pkgname - you need to include patches and such in the source array - Do not introduce new variables into your PKGBUILD build scripts, unless the package cannot be built without doing so. Further some of them are already defined by a variable so why creating a new one? I really have trouble reading it. - what is up with the use of pushd and popd? There is clearly no use in using those. What else can I say...I still think 8 packages is not enough as I already indicated in a previous thread. Ronald