On Mon, 23 Jan 2023 18:08:04 -0600 Doug Newgard <dnewgard@outlook.com> wrote:
On Mon, 23 Jan 2023 23:36:34 +0000 Polarian <polarian@polarian.dev> wrote:
Hello,
Could anyone who has experience with AUR packages please check over the PKGBUILD I have submitted to the AUR.
It works, and I have already written up the ArchWiki page for it (https://wiki.archlinux.org/title/Eureka) but I want a second set of eyes to read through my work to ensure I have not screwed anything up, and to ensure my package is sticking to conventions (and in case anyone has any improvements).
You can either read it from the git interface provided by the AUR (this can be a little annoying) or you can read it on the git repository which is hosted elsewhere here: https://onedev.polarian.dev/aur/eureka-notes/~files/master/PKGBUILD
Any issues with the package let me know :)
Thank you,
pkgver should not have the leading 'v'.
No reason to specify pkgbase here, but it's not a problem.
Is git really needed at build time?
You need to rename the source archive, the name is too generic. See the warning at https://wiki.archlinux.org/title/PKGBUILD#source
You need to install the license file.
For rust PKGBUILDs, see https://wiki.archlinux.org/title/Rust_package_guidelines
Hope this helps!
Oh, I also forgot, it is strongly suggested that non-standard variables begin with an underscore to make sure they don't conflict with anything makepkg uses.