Le 24/01/2023 à 12:44, Polarian a écrit :
Hello All, Hi,
I have attempted to combine all of your suggestions into one, I have followed to the rust packaging guidelines which was linked, and I have taken into consideration all the other suggestions you have made.
https://onedev.polarian.dev/aur/eureka-notes/~files/master/PKGBUILD
Or check the AUR package to read the source.
Looks better now ;) While this is not mandatory, here are 2 suggestions I could eventually make: - Declare a custom `_pkgname=eureka` variable (since it's the real name of the software) and make use of that variable instead of repeating "eureka" multiple times in the PKGBUILD - There are still some useless usages of the `$srcdir` variable in the `install` commands inside the `package ()` function (since PKGBUILDs' functions implicitly and automatically "cd" into "srcdir" by default) As I said, those points are not mandatory. That's mostly style changes, it's up to you to decide whether you want to implement them or not I guess. Other than that, I think the PKGBUILD looks good that way. -- Regards, Antiz (Robin C.)