On 5/17/20 5:06 AM, Frederik Schwan via aur-general wrote:
Changes can be found here: https://github.com/freswa/aur/commit/c3778f6bda345f0165289f3a57d36047e6ba593...
Thank you for doing the review :)
Time for the next round: Package: datagrip datagrip-jre 'commercial' on line 9 is not a valid license[1], in case of a custom license prefix with 'custom:' Offending line: license=('commercial') Package: or-tools-java Variable ${srcdir} on line 44 should be quoted as it may contain spaces Offending line: sed -i "s#${src#git+}#${srcdir}/${srcfolder}#" ${srcdir}/${pkgname%-java}-${pkgver}/makefiles/Makefile.third_party.unix.mk ---------------------------------------------------^^^^^^^^^ Package: pass-sshaskpass 'GPLv2' on line 8 is not a valid license[1], in case of a custom license prefix with 'custom:' Offending line: license=('GPLv2') Package: pass-sshaskpass-git 'GPLv2' on line 8 is not a valid license[1], in case of a custom license prefix with 'custom:' Offending line: license=('GPLv2') Package: tomighty Variable ${srcdir} on line 32 should be quoted as it may contain spaces Offending line: convert ${srcdir}/tomato.ico ${srcdir}/tomato.png Package: tpacpi-bat-git Error: 'GPLv3' on line 9 is not a valid license[1], in case of a custom license prefix with 'custom:' Offending line: license=('GPLv3') Package: unifi-beta Potentionally unintentional HTTP URL http://www.ubnt.com/ on line 10 should be https Offending line: url='http://www.ubnt.com/' Package: youtrack 'commercial:jetbrains' on line 8 is not a valid license[1], in case of a custom license prefix with 'custom:' Offending line: license=('commercial:jetbrains')
Cheers Frederik
:P [1] (Currently) valid non-custom licenses are: AGPL3, Apache, Artistic2.0, Boost, CCPL, CDDL, CPL, EPL, FDL1.2, FDL1.3, GPL2, GPL3, LGPL2.1, LGPL3, LPPL, MPL, MPL2, PHP, PSF, PerlArtistic, RUBY, W3C, ZPL, AGPL, APACHE, FDL, GPL, LGPL, Unlicense, BSD, ISC, MIT, OFL, Python, ZLIB -- Rob (coderobe) O< ascii ribbon campaign - stop html mail - www.asciiribbon.org