Some improvements: 1. Add zetacoin-qt.desktop to the `source` and `sha256sums` arrays. 2. Add a function named `pkgver` to the PKGBUILD file. [1] This function will allow `makepkg` to update the version number automatically, relieving you of the need to update the version number by hand. 3. The comment at the top of the package should say "Based on terracoin-qt PKGBUILD", not "Based in terracoin-qt PKGBUILD". 4. Consider explicitly `cd`-ing into the `$srcdir` directory. Though this step is not strictly necessary, it makes your intent more clear to others reading through the PKGBUILD. As a Python programmer would say, "Explicit is better than implicit." 5. Consider removing the "miniupnpc" dependency from the package. `namcap` warns that it is not necessary. Do not remote the dependency blindly, though: namcap is sometimes wrong about dependencies. I am not knowledgeable about GUI applications, so I cannot comment on the .desktop or .install files. [1] https://wiki.archlinux.org/index.php/VCS_PKGBUILD_Guidelines#The_pkgver.28.2... On Fri, Nov 1, 2013 at 4:51 AM, Bruno Jimenez <brunojimen@gmail.com> wrote:
Oh, I's so sorry, I didn't know that the list removed attachments from emails.
Here's the PKGBUILD: http://pastebin.com/gVP8UeJq
Thanks in advance! Bruno
On Thu, 2013-10-31 at 20:33 -0400, Jeremy Audet wrote:
Where is the PKGBUILD file? Can you provide a link?
I think the mailing list strips attachments off emails. If so, your best bet is to use a service like pastebin or gist.
--Jeremy "Ichimonji10" Audet
On Thu, Oct 31, 2013 at 11:27 AM, Bruno Jimenez <brunojimen@gmail.com wrote:
Hi,
I have been interested lately in alt-currency and I wanted to try zetacoin, but I couldn't find a package in the repos or the AUR.
So, using terracoin-qt's PKGBUILD (which is outdated, by the way) I have created the PKGBUILD for zetacoin-qt-git.
As it is the first PKGBUILD I make, I wanted to make sure that it is well written.
Thanks in Advance! Bruno
P.S: Maybe tomorrow, I'll make also the zetacoin-daemon-git PKGBUILD in case you want to advice me on something